diff options
| author | Zsolt Kozaroczy <[email protected]> | 2023-10-19 10:18:46 +0200 |
|---|---|---|
| committer | GitHub <[email protected]> | 2023-10-19 10:18:46 +0200 |
| commit | d6a3d5a65d070bf6083be1c01aa099b58d6e3464 (patch) | |
| tree | bc0d861d8e54b9d7c61eeebeaff44763f6983ea5 | |
| parent | e15ceb41bbcbdbeed33e304101cc66114ef1cf7d (diff) | |
| parent | 9e5bc61c60f8775150163d6d2da73d60083f0dbd (diff) | |
| download | caxlsx-d6a3d5a65d070bf6083be1c01aa099b58d6e3464.tar.gz caxlsx-d6a3d5a65d070bf6083be1c01aa099b58d6e3464.zip | |
Merge pull request #273 from tagliala/chore/fix-unused-block-argument
Fix Lint/UnusedBlockArgument offenses
| -rw-r--r-- | .rubocop_todo.yml | 8 | ||||
| -rw-r--r-- | lib/axlsx/drawing/axes.rb | 2 | ||||
| -rw-r--r-- | lib/axlsx/workbook/worksheet/pivot_table.rb | 4 | ||||
| -rw-r--r-- | lib/axlsx/workbook/worksheet/sheet_view.rb | 2 |
4 files changed, 4 insertions, 12 deletions
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 16d5bcb6..6e233ce4 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -49,14 +49,6 @@ Lint/DisjunctiveAssignmentInConstructor: - 'lib/axlsx/drawing/num_data_source.rb' # This cop supports safe autocorrection (--autocorrect). -# Configuration parameters: IgnoreEmptyBlocks, AllowUnusedKeywordArguments. -Lint/UnusedBlockArgument: - Exclude: - - 'lib/axlsx/drawing/axes.rb' - - 'lib/axlsx/workbook/worksheet/pivot_table.rb' - - 'lib/axlsx/workbook/worksheet/sheet_view.rb' - -# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: AllowUnusedKeywordArguments, IgnoreEmptyMethods, IgnoreNotImplementedMethods. Lint/UnusedMethodArgument: Exclude: diff --git a/lib/axlsx/drawing/axes.rb b/lib/axlsx/drawing/axes.rb index 010fe8cd..f63ef95d 100644 --- a/lib/axlsx/drawing/axes.rb +++ b/lib/axlsx/drawing/axes.rb @@ -32,7 +32,7 @@ module Axlsx def to_xml_string(str = +'', options = {}) if options[:ids] # CatAxis must come first in the XML (for Microsoft Excel at least) - sorted = axes.sort_by { |name, axis| axis.is_a?(CatAxis) ? 0 : 1 } + sorted = axes.sort_by { |_name, axis| axis.is_a?(CatAxis) ? 0 : 1 } sorted.each { |axis| str << '<c:axId val="' << axis[1].id.to_s << '"/>' } else axes.each { |axis| axis[1].to_xml_string(str) } diff --git a/lib/axlsx/workbook/worksheet/pivot_table.rb b/lib/axlsx/workbook/worksheet/pivot_table.rb index afad9483..62349288 100644 --- a/lib/axlsx/workbook/worksheet/pivot_table.rb +++ b/lib/axlsx/workbook/worksheet/pivot_table.rb @@ -210,7 +210,7 @@ module Axlsx end str << '</rowFields>' str << '<rowItems count="' << rows.size.to_s << '">' - rows.size.times do |i| + rows.size.times do str << '<i/>' end str << '</rowItems>' @@ -220,7 +220,7 @@ module Axlsx str << '<colFields count="1"><field x="-2"/></colFields>' str << "<colItems count=\"#{data.size}\">" str << '<i><x/></i>' - data[1..-1].each_with_index do |datum_value, i| + (data.size - 1).times do |i| str << "<i i=\"#{i + 1}\"><x v=\"#{i + 1}\"/></i>" end str << '</colItems>' diff --git a/lib/axlsx/workbook/worksheet/sheet_view.rb b/lib/axlsx/workbook/worksheet/sheet_view.rb index 02e20b33..1ecfc7ab 100644 --- a/lib/axlsx/workbook/worksheet/sheet_view.rb +++ b/lib/axlsx/workbook/worksheet/sheet_view.rb @@ -198,7 +198,7 @@ module Axlsx serialized_attributes str str << '>' @pane.to_xml_string(str) if @pane - @selections.each do |key, selection| + @selections.each_value do |selection| selection.to_xml_string(str) end str << '</sheetView>' |