summaryrefslogtreecommitdiffhomepage
AgeCommit message (Collapse)Author
2023-05-31Merge pull request #262 from tagliala/chore/fix-if-inside-else-offenseZsolt Kozaroczy
Fix Style/IfInsideElse offense
2023-05-31Merge pull request #261 from ↵Zsolt Kozaroczy
tagliala/chore/fix-string-concatenation-in-non-production-code Fix StringConcatenation offenses (non-production)
2023-05-31Merge pull request #260 from ↵Zsolt Kozaroczy
tagliala/chore/fix-redundant-file-extension-in-require-offenses Fix Style/RedundantFileExtensionInRequire offenses
2023-05-31Merge pull request #259 from tagliala/chore/enable-naming-copsZsolt Kozaroczy
Enable Naming cops
2023-05-31Merge pull request #255 from pkmiec/fixSimpleTypeListRegressionZsolt Kozaroczy
Use #== and #eql? from BasicObject
2023-05-31Merge pull request #238 from tagliala/chore/use-case-whenZsolt Kozaroczy
Remove duplicate branch condition
2023-05-25Enable Naming copsGeremia Taglialatela
Also fix safe minor offenses - Naming/BinaryOperatorParameterName - Naming/HeredocDelimiterCase
2023-05-25Fix StringConcatenation offenses (non-production)Geremia Taglialatela
Prefer interpolation over concatenation ``` Comparison ("String#{'String'}" vs 'String' + 'String'): interpolation: 11821321.0 i/s concatenation: 8849491.7 i/s - 1.34x (± 0.00) slower ```
2023-05-25Remove duplicate checkGeremia Taglialatela
Axlsx::Row is now an Array, so it is possible to remove the extra duplicate branch
2023-05-25Merge pull request #258 from tagliala/chore/enable-gemspec-copsZsolt Kozaroczy
Enable Gemspec cops
2023-05-25Merge pull request #234 from tagliala/chore/fix-collection-literal-in-loopZsolt Kozaroczy
Do not use collection literal in loops
2023-05-25Merge pull request #212 from westonganger/masterZsolt Kozaroczy
Fix axlsx_styler gem deprecation error
2023-05-24Fix axlsx_styler gem errorWeston Ganger
2023-05-24Fix Style/IfInsideElse offenseGeremia Taglialatela
2023-05-24Fix Style/RedundantFileExtensionInRequire offensesGeremia Taglialatela
2023-05-24Do not use collection literal in loopsGeremia Taglialatela
Also refactors Page margins to avoid code duplication
2023-05-24Enable Gemspec copsGeremia Taglialatela
Gemspec/RequireMFA will be fixed via #197
2023-05-24Merge pull request #257 from tagliala/chore/improve-cell-type-from-valueZsolt Kozaroczy
Improve cell type from value implementation
2023-05-24Merge pull request #256 from tagliala/chore/fix-profiler-deprecationsZsolt Kozaroczy
Fix profiler deprecations
2023-05-24Merge pull request #254 from tagliala/chore/performance-redundant-block-callZsolt Kozaroczy
Fix Performance/RedundantBlockCall offense
2023-05-24Merge pull request #253 from tagliala/chore/fix-line-end-concatenation-offensesZsolt Kozaroczy
Fix Style/LineEndConcatenation offenses
2023-05-24Merge pull request #252 from tagliala/security/enable-security-copsZsolt Kozaroczy
Enable Security cops
2023-05-24Merge pull request #251 from ↵Zsolt Kozaroczy
tagliala/chore/use-ruby-19-hash-syntax-non-production Use Ruby 1.9 hash syntax (non-production code)
2023-05-24Merge pull request #250 from tagliala/chore/fix-style-non-nil-check-offensesZsolt Kozaroczy
Fix Style/NonNilCheck offenses
2023-05-24Merge pull request #248 from tagliala/chore/fix-class-check-offensesZsolt Kozaroczy
Fix safe class comparison offenses
2023-05-23Add benchmark with merge cellsPaul Kmiec
This is an extreme case, but it really shows the impact of merging cells.
2023-05-23Improve Regexp validatorGeremia Taglialatela
Replace `.match` with `.match?`
2023-05-23Improve cell type from value implementationGeremia Taglialatela
- Use `Regexp.match?` instead of `=~` when match is not needed - Use `Regexp.match` instead of `string.match` for uniformity ``` match?: 7335121.2 i/s =~: 2329358.3 i/s - 3.15x (± 0.00) slower ```
2023-05-23Fix profiler deprecationsGeremia Taglialatela
``` NOTE: RubyProf.profile is deprecated; use Profile.profile instead. It will be removed on or after 2023-06. RubyProf.profile called from ./test/profile.rb:14. NOTE: RubyProf.running? is deprecated; use Profile#running? instead. It will be removed on or after 2023-06. NOTE: RubyProf.measure_mode is deprecated; use Profile#measure_mode instead. It will be removed on or after 2023-06. NOTE: RubyProf.exclude_threads is deprecated; use Profile#exclude_threads instead. It will be removed on or after 2023-06. ```
2023-05-22Use #== and #eql? from BasicObjectPaul Kmiec
Prior to https://github.com/caxlsx/caxlsx/pull/223, SimpleTypeList was just an object and inheritied #== / #eql? from BasicObject. These versions are fast as they just compare whether two objects sit in the same memory location. After https://github.com/caxlsx/caxlsx/pull/223, we started to inherit #== / #eql? from Array. These are slow as they crawl all the elements in the Array. This commit restores the original version of #== / #eql?.
2023-05-23Fix Performance/RedundantBlockCall offenseGeremia Taglialatela
Ref: https://github.com/fastruby/fast-ruby#proccall-and-block-arguments-vs-yieldcode
2023-05-23Fix Style/LineEndConcatenation offensesGeremia Taglialatela
2023-05-23Enable Security copsGeremia Taglialatela
Also fixes a Security/Open offense that couldn't be exploited, because the only invocation of `get_mime_type_from_uri` was validating the input with a `URI::DEFAULT_PARSER` regexp
2023-05-22Use Ruby 1.9 hash syntax (non-production code)Geremia Taglialatela
2023-05-22Fix Style/NonNilCheck offensesGeremia Taglialatela
There were 8 occurrences of `!nil?` and 4 of `!= nil`. This change will standardize the usage of non-nil checks
2023-05-22Fix safe class comparison offensesGeremia Taglialatela
Fixes: - Style/ClassCheck - Style/ClassEqualityComparison While `is_a?` and `kind_of?` are equivalent, there is a 5% gain when switching from class comparison to `intance_of?` ``` Comparison: instance_of: 16902635.9 i/s class comparison: 16061288.3 i/s - 1.05x (± 0.00) slower ```
2023-05-22Merge pull request #236 from pkmiec/smallPerfTweaksZsolt Kozaroczy
Add `Cell#style_str` so that we can directly return '0'
2023-05-22Merge pull request #246 from tagliala/chore/fix-useless-assignment-offensesZsolt Kozaroczy
Fix Lint/UselessAssignment offenses
2023-05-22Merge pull request #245 from tagliala/chore/test-against-jruby-headZsolt Kozaroczy
Test against JRuby head
2023-05-22Merge pull request #244 from tagliala/chore/remove-ruby-pre-25-codeZsolt Kozaroczy
Remove check needed for Ruby < 2.5
2023-05-22Merge pull request #243 from tagliala/chore/fix-zero-length-predicate-offensesZsolt Kozaroczy
Fix Style/ZeroLengthPredicate unsafe offenses
2023-05-22Merge pull request #242 from tagliala/chore/fix-minor-safe-offensesZsolt Kozaroczy
Remove minor safe offenses
2023-05-22Merge pull request #241 from tagliala/chore/fix-style-and-or-offenseZsolt Kozaroczy
Fix Style/AndOr offenses
2023-05-22Merge pull request #240 from tagliala/chore/fix-void-contextsZsolt Kozaroczy
Fix Lint/Void offenses
2023-05-22Merge pull request #237 from tagliala/chore/fix-hash-transform-keysZsolt Kozaroczy
Fix hash transformation related offenses
2023-05-22Merge pull request #235 from tagliala/chore/fix-yard-warningsZsolt Kozaroczy
Fix YARD warnings
2023-05-22Merge pull request #239 from adamkiczula/bug/fix-sheet-by-name-encodingZsolt Kozaroczy
Fix sheet_by_name for sheets with escaped characters
2023-05-21Improve commentsGeremia Taglialatela
- Use https where possible - Capitalize Excel
2023-05-21Fix Lint/UselessAssignment offensesGeremia Taglialatela
2023-05-20Test against JRuby headGeremia Taglialatela
Also provide a better user message in workflow results when failures are allowed ("allow failures" instead of "true")
generated by cgit v1.2.3 (git 2.39.1) at 2026-09-18 15:53:40 +0000