summaryrefslogtreecommitdiffhomepage
path: root/test/workbook/worksheet
AgeCommit message (Collapse)Author
2023-10-19Add optional interpolation points to icon setsKoza
2023-10-02Fix failing specjohnnyshields
2023-10-02Set escape_formulas as "true" as a global default.johnnyshields
2023-08-15Added sorting to the AutoFilter class - add sort conditions to the xml (#286)rikweelvoormedia
--------- Co-authored-by: SarahVanHaute <[email protected]> Co-authored-by: Geremia Taglialatela <[email protected]>
2023-07-05Fix offenses in sheet protectionGeremia Taglialatela
- Lint/AmbiguousOperatorPrecedence - Style/PerlBackrefs - Style/StringChars - Style/UnpackFirst
2023-06-10Fix safe Style/ColonMethodCall offensesGeremia Taglialatela
Caxlsx is using both `.` and `::`, 220 occurrences vs 280 to invoke methods on `Axlsx` module. This commit standardizes the approach towards `.`, which will also allow shorter lines. Performance is not affected ``` Comparison: Axlsx.validate: 8515252.3 i/s Axlsx::validate: 8512863.7 i/s - same-ish: difference falls within error ```
2023-06-05Prefer `Kernel#format` to `String#%`Geremia Taglialatela
This commit fixes cases that cannot be detected by RuboCop Ref: https://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Style/FormatString
2023-06-05Fix Style/RedundantInterpolation offensesGeremia Taglialatela
`%` is an operation on `String` that will return a new `String`, so the interpolation is redundant Also adds a missing spec on PivotTable#rels_pn ``` IPS: uninterpolated: 4045715.7 i/s interpolated: 2359775.6 i/s - 1.71x (± 0.00) slower Memory: uninterpolated: 160 allocated interpolated: 232 allocated - 1.45x more ```
2023-05-25Fix StringConcatenation offenses (non-production)Geremia Taglialatela
Prefer interpolation over concatenation ``` Comparison ("String#{'String'}" vs 'String' + 'String'): interpolation: 11821321.0 i/s concatenation: 8849491.7 i/s - 1.34x (± 0.00) slower ```
2023-05-22Use Ruby 1.9 hash syntax (non-production code)Geremia Taglialatela
2023-05-15Remove ability to set `u=` to true in favor of :singlePaul Kmiec
The `u=` would convert `true` to `:single` for backwards compatibility. However, it is more explicit to set it to `:single` or one of the other underline options instead of relying on the conversion.
2023-05-04Fix tests / code to work with frozen string literalsPaul Kmiec
2023-05-04Enable Style/FrozenStringLiteralComment and autocorrectPaul Kmiec
2023-05-03Fix non-production Style/NumericLiterals offensesGeremia Taglialatela
2023-05-03Remove redundant load pathsGeremia Taglialatela
2023-05-03Fix Style/RedundantFileExtensionInRequire offenseGeremia Taglialatela
2023-05-03Fix tests not using valuesGeremia Taglialatela
2023-05-03Fix time testsGeremia Taglialatela
Remove some old code related to Ruby 1.x
2023-05-03Add RuboCop MinitestGeremia Taglialatela
2023-05-03Fix offenses to non-production codeGeremia Taglialatela
- Lint/AmbiguousBlockAssociation - Lint/AmbiguousOperatorPrecedence - Lint/EmptyBlock - Lint/RedundantSplatExpansion - Lint/RedundantStringCoercion - Lint/SymbolConversion - Lint/UnusedBlockArgument - Style/BlockDelimiters - Style/CommentAnnotation - Style/EachForSimpleLoop - Style/EmptyMethod - Style/ExpandPathArguments - Style/FileWrite - Style/GlobalStdStream (UNSAFE) - Style/HashEachMethods (UNSAFE) - Style/NestedParenthesizedCalls - Style/NilComparison - Style/NumericLiteralPrefix (manually fixed) - Style/ParallelAssignment - Style/PreferredHashMethods (UNSAFE) - Style/RedundantInterpolation (UNSAFE) - Style/RedundantParentheses (UNSAFE) - Style/RegexpLiteral - Style/RescueStandardError - Style/SpecialGlobalVars (UNSAFE) - Style/SymbolProc (UNSAFE) - Style/ZeroLengthPredicate (UNSAFE)
2023-04-23Add test to ensure various OWASP prefixes are never parsed as formulaStefan
2023-04-13Merge branch 'master' into escape-formulas-improvementJohnny Shields
2023-04-10Fix some Layout/HashAlignment offensesGeremia Taglialatela
Some offenses have been selected and fixed automatically
2023-04-10Fix Layout/LeadingCommentSpace offensesGeremia Taglialatela
``` rubocop --only Layout/LeadingCommentSpace -a ```
2023-04-09Fix Layout/ExtraSpacing offensesGeremia Taglialatela
Configure with `AllowBeforeTrailingComments: true`
2023-04-09Fix offenses related to indentation consistencyGeremia Taglialatela
2023-04-08Fix space-related offensesGeremia Taglialatela
- Layout/SpaceAfterComma - Layout/SpaceAroundEqualsInParameterDefault - Layout/SpaceAroundOperators - Layout/SpaceBeforeBlockBraces - Layout/SpaceInsideBlockBraces - Layout/SpaceInsideHashLiteralBraces - Layout/SpaceInsideParens
2023-04-08Fix offenses related to trailing commasGeremia Taglialatela
2023-04-08Fix EmptyLines related offensesGeremia Taglialatela
2023-04-08Fix Layout/SpaceBeforeFirstArg offensesGeremia Taglialatela
``` rubocop --only Layout/SpaceBeforeFirstArg -a ```
2023-04-07Fix Layout/SpaceInsideArrayLiteralBrackets offensesGeremia Taglialatela
``` rubocop --only Layout/SpaceInsideArrayLiteralBrackets -a ```
2023-04-07Fix Layout/SpaceBeforeComma offensesGeremia Taglialatela
``` rubocop --only Layout/SpaceBeforeComma -a ```
2023-04-07Fix Layout/SpaceAroundBlockParameters offensesGeremia Taglialatela
``` rubocop --only Layout/SpaceAroundBlockParameters -a ```
2023-04-07Fix Layout/ElseAlignmentGeremia Taglialatela
Manually fixed
2023-04-07Fix Layout/BlockAlignment offensesGeremia Taglialatela
Manually fixed
2023-04-06Fix Layout/CommentIndentation offensesGeremia Taglialatela
``` rubocop --only Layout/CommentIndentation -a ```
2023-04-06Fix Layout/EmptyLineBetweenDefs offensesGeremia Taglialatela
``` rubocop --only Layout/EmptyLineBetweenDefs -a ```
2023-04-06Fix Layout/EmptyLines offensesGeremia Taglialatela
``` rubocop --only Layout/EmptyLines -a ```
2023-04-06Fix Style/Encoding offensesGeremia Taglialatela
``` rubocop --only Style/Encoding -a ```
2023-04-06Fix Layout/TrailingEmptyLines offensesGeremia Taglialatela
``` rubocop --only Layout/TrailingEmptyLines -a ```
2023-04-06Remove Layout/TrailingWhitespace offensesGeremia Taglialatela
``` rubocop --only Layout/TrailingWhitespace -a ```
2023-04-03Escape array formulasjohnnyshields
2023-04-02`escape_formulas` should handle all [OWASP-designated formula ↵johnnyshields
prefixes](https://owasp.org/www-community/attacks/CSV_Injection).
2023-03-31Add settings for escape_formulas at global, workbook, worksheet, row and ↵johnnyshields
cell levels.
2022-11-02Improve BorderCreator argsWeston Ganger
2022-10-22Fix bug in BorderCreator when second arg is nilWeston Ganger
2022-10-21Merge pull request #156 from basefarm/pivot_multiple_data_columnsNoel Peden
Prevent Excel from crashing when multiple data columns added to PivotTable
2022-10-12Resolve all TODOsWeston Ganger
2022-10-09ImprovementsWeston Ganger
2022-07-21Prevent Excel from crashing when multiple data columns are added to PivotTableKnut Stenmark
Excel will crash unless both `colFields` and `colItems` are declared in the PivotTable xml. First `field` of `colFields` needs to be set to -2 to tell Excel that the value columns comes from individual columns and not groups. I do not know why `colItems` are needed, but when set, the Excel document opens without crashing.
generated by cgit v1.2.3 (git 2.39.1) at 2026-04-19 03:47:48 +0000