From 2a70161abe24ae130041aaca3eec79e63d08a5f5 Mon Sep 17 00:00:00 2001 From: Geremia Taglialatela Date: Thu, 25 May 2023 14:17:12 +0200 Subject: Fix StringConcatenation offenses (non-production) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Prefer interpolation over concatenation ``` Comparison ("String#{'String'}" vs 'String' + 'String'): interpolation: 11821321.0 i/s concatenation: 8849491.7 i/s - 1.34x (± 0.00) slower ``` --- .rubocop_todo.yml | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) (limited to '.rubocop_todo.yml') diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index a0260f2e..82fc6a22 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -423,7 +423,14 @@ Style/StringChars: # This cop supports unsafe autocorrection (--autocorrect-all). # Configuration parameters: Mode. Style/StringConcatenation: - Enabled: false + Exclude: + - 'lib/axlsx/drawing/area_series.rb' + - 'lib/axlsx/drawing/line_series.rb' + - 'lib/axlsx/drawing/pie_series.rb' + - 'lib/axlsx/drawing/scatter_series.rb' + - 'lib/axlsx/stylesheet/color.rb' + - 'lib/axlsx/util/constants.rb' + - 'lib/axlsx/workbook/worksheet/worksheet.rb' # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle, ConsistentQuotesInMultiline. -- cgit v1.2.3