From ee14c1bf5c6aaa96867eb4b90b510f91c3a614f8 Mon Sep 17 00:00:00 2001 From: Geremia Taglialatela Date: Sat, 10 Jun 2023 11:48:13 +0200 Subject: Fix safe Style/ColonMethodCall offenses Caxlsx is using both `.` and `::`, 220 occurrences vs 280 to invoke methods on `Axlsx` module. This commit standardizes the approach towards `.`, which will also allow shorter lines. Performance is not affected ``` Comparison: Axlsx.validate: 8515252.3 i/s Axlsx::validate: 8512863.7 i/s - same-ish: difference falls within error ``` --- .rubocop_todo.yml | 4 ---- 1 file changed, 4 deletions(-) (limited to '.rubocop_todo.yml') diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 1af7d16e..f3a8e5ae 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -156,10 +156,6 @@ Style/ClassVars: - 'lib/axlsx/workbook/workbook.rb' - 'lib/axlsx/workbook/worksheet/dimension.rb' -# This cop supports safe autocorrection (--autocorrect). -Style/ColonMethodCall: - Enabled: false - # This cop supports unsafe autocorrection (--autocorrect-all). Style/ConcatArrayLiterals: Exclude: -- cgit v1.2.3