From 191f8d31c71f43ee2c898bfedec657dd3e00a0f0 Mon Sep 17 00:00:00 2001 From: Geremia Taglialatela Date: Thu, 13 Apr 2023 16:31:13 +0200 Subject: Fix other non-production offenses - Style/MethodCallWithoutArgsParentheses - Style/StringLiteralsInInterpolation --- .rubocop_todo.yml | 12 ------------ test/benchmark.rb | 2 +- test/content_type/tc_content_type.rb | 4 ++-- 3 files changed, 3 insertions(+), 15 deletions(-) diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index f17b6eda..b91e702b 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -326,7 +326,6 @@ Style/LineEndConcatenation: Style/MethodCallWithoutArgsParentheses: Exclude: - 'lib/axlsx/package.rb' - - 'test/benchmark.rb' # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle. @@ -428,10 +427,6 @@ Style/NumericPredicate: - 'lib/axlsx/workbook/worksheet/cell.rb' - 'lib/axlsx/workbook/worksheet/sheet_pr.rb' - 'lib/axlsx/workbook/worksheet/worksheet.rb' - - 'test/drawing/tc_marker.rb' - - 'test/drawing/tc_one_cell_anchor.rb' - - 'test/drawing/tc_two_cell_anchor.rb' - - 'test/util/tc_simple_typed_list.rb' # This cop supports safe autocorrection (--autocorrect). Style/OperatorMethodCall: @@ -651,13 +646,6 @@ Style/StringConcatenation: Style/StringLiterals: Enabled: false -# This cop supports safe autocorrection (--autocorrect). -# Configuration parameters: EnforcedStyle. -# SupportedStyles: single_quotes, double_quotes -Style/StringLiteralsInInterpolation: - Exclude: - - 'test/content_type/tc_content_type.rb' - # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: MinSize. # SupportedStyles: percent, brackets diff --git a/test/benchmark.rb b/test/benchmark.rb index 7cbffa32..9e651596 100755 --- a/test/benchmark.rb +++ b/test/benchmark.rb @@ -57,7 +57,7 @@ Benchmark.bmbm(30) do |x| end end end - s = p.to_stream() + s = p.to_stream File.binwrite('example_streamed.xlsx', s.read) end diff --git a/test/content_type/tc_content_type.rb b/test/content_type/tc_content_type.rb index b9d36063..7cbaf5d5 100644 --- a/test/content_type/tc_content_type.rb +++ b/test/content_type/tc_content_type.rb @@ -70,14 +70,14 @@ class TestContentType < Test::Unit::TestCase c = ws.add_chart Axlsx::Pie3DChart doc = Nokogiri::XML(@package.send(:content_types).to_xml_string) - assert_equal(7, doc.xpath("//xmlns:Override").size, "expected 7 types got #{doc.css("Types Override").size}") + assert_equal(7, doc.xpath("//xmlns:Override").size, "expected 7 types got #{doc.css('Types Override').size}") assert_equal(doc.xpath(o_path % Axlsx::DRAWING_CT).first["PartName"], "/xl/#{ws.drawing.pn}", "Drawing part name invlid") assert_equal(doc.xpath(o_path % Axlsx::CHART_CT).last["PartName"], "/xl/#{c.pn}", "Chart part name invlid") c = ws.add_chart Axlsx::Pie3DChart doc = Nokogiri::XML(@package.send(:content_types).to_xml_string) - assert_equal(8, doc.xpath("//xmlns:Override").size, "expected 7 types got #{doc.css("Types Override").size}") + assert_equal(8, doc.xpath("//xmlns:Override").size, "expected 7 types got #{doc.css('Types Override').size}") assert_equal(doc.xpath(o_path % Axlsx::CHART_CT).last["PartName"], "/xl/#{c.pn}", "Chart part name invlid") end end -- cgit v1.2.3