From e75a5215c465ad70e5ea82bd48035531517a3b45 Mon Sep 17 00:00:00 2001 From: Randy Morgan Date: Fri, 20 Jul 2012 22:22:47 +0900 Subject: fix for #115 and README update as we do support charts in Google Docs --- README.md | 5 +++-- lib/axlsx.rb | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/README.md b/README.md index a55e038e..c9891724 100644 --- a/README.md +++ b/README.md @@ -117,7 +117,9 @@ This gem has 100% test coverage using test/unit. To execute tests for this gem, --------- - **July.??.12**: 1.1.9 release - lots of code clean up for worksheet - - added in data labels for pie charts + - added in data labels for pie charts, line charts and bar charts. + - bugfix chard with data in a sheet that has a space in the name are + now auto updating formula based values - **July.14.12**: 1.1.8 release - added html entity encoding for sheet names. This allows you to use characters like '<' and '&' in your sheet names. @@ -193,7 +195,6 @@ related to themes, which axlsx does not implement at this time. 2. Google Docs - Images are known to not work with google docs - border colors do not work - - Charts, for the most part, do not work. Google docs has some specific requirements about how the worksheet is set up to create a chart. 3. Numbers - you must set 'use_shared_strings' to true diff --git a/lib/axlsx.rb b/lib/axlsx.rb index 2fb1fa36..ad14cd7a 100644 --- a/lib/axlsx.rb +++ b/lib/axlsx.rb @@ -45,7 +45,7 @@ module Axlsx return "" unless cells.first.is_a? Cell sort_cells(cells) reference = "#{cells.first.reference(absolute)}:#{cells.last.reference(absolute)}" - absolute ? "#{cells.first.row.worksheet.name}!#{reference}" : reference + absolute ? "'#{cells.first.row.worksheet.name}'!#{reference}" : reference end def self.sort_cells(cells) -- cgit v1.2.3