From ee14c1bf5c6aaa96867eb4b90b510f91c3a614f8 Mon Sep 17 00:00:00 2001 From: Geremia Taglialatela Date: Sat, 10 Jun 2023 11:48:13 +0200 Subject: Fix safe Style/ColonMethodCall offenses Caxlsx is using both `.` and `::`, 220 occurrences vs 280 to invoke methods on `Axlsx` module. This commit standardizes the approach towards `.`, which will also allow shorter lines. Performance is not affected ``` Comparison: Axlsx.validate: 8515252.3 i/s Axlsx::validate: 8512863.7 i/s - same-ish: difference falls within error ``` --- lib/axlsx/stylesheet/cell_style.rb | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) (limited to 'lib/axlsx/stylesheet/cell_style.rb') diff --git a/lib/axlsx/stylesheet/cell_style.rb b/lib/axlsx/stylesheet/cell_style.rb index 5cdb4842..3bc9faec 100644 --- a/lib/axlsx/stylesheet/cell_style.rb +++ b/lib/axlsx/stylesheet/cell_style.rb @@ -48,17 +48,17 @@ module Axlsx attr_reader :customBuiltin # @see name - def name=(v) Axlsx::validate_string v; @name = v end + def name=(v) Axlsx.validate_string v; @name = v end # @see xfId - def xfId=(v) Axlsx::validate_unsigned_int v; @xfId = v end + def xfId=(v) Axlsx.validate_unsigned_int v; @xfId = v end # @see builtinId - def builtinId=(v) Axlsx::validate_unsigned_int v; @builtinId = v end + def builtinId=(v) Axlsx.validate_unsigned_int v; @builtinId = v end # @see iLivel - def iLevel=(v) Axlsx::validate_unsigned_int v; @iLevel = v end + def iLevel=(v) Axlsx.validate_unsigned_int v; @iLevel = v end # @see hidden - def hidden=(v) Axlsx::validate_boolean v; @hidden = v end + def hidden=(v) Axlsx.validate_boolean v; @hidden = v end # @see customBuiltin - def customBuiltin=(v) Axlsx::validate_boolean v; @customBuiltin = v end + def customBuiltin=(v) Axlsx.validate_boolean v; @customBuiltin = v end # Serializes the object # @param [String] str -- cgit v1.2.3