From 2bb450b398239a10d78cae519d342f5626dec711 Mon Sep 17 00:00:00 2001 From: Geremia Taglialatela Date: Thu, 13 Apr 2023 14:25:06 +0200 Subject: Fix tests not using values --- test/workbook/worksheet/tc_data_validation.rb | 8 ++++---- test/workbook/worksheet/tc_sheet_protection.rb | 5 ++--- test/workbook/worksheet/tc_sheet_view.rb | 8 ++++---- 3 files changed, 10 insertions(+), 11 deletions(-) (limited to 'test') diff --git a/test/workbook/worksheet/tc_data_validation.rb b/test/workbook/worksheet/tc_data_validation.rb index aa4efd55..01a7cd13 100644 --- a/test/workbook/worksheet/tc_data_validation.rb +++ b/test/workbook/worksheet/tc_data_validation.rb @@ -44,16 +44,16 @@ class TestDataValidation < Test::Unit::TestCase end def test_boolean_attribute_validation - @boolean_options.each do |key, _value| + @boolean_options.each do |key, value| assert_raise(ArgumentError, "#{key} must be boolean") { @dv.send("#{key}=".to_sym, 'A') } - assert_nothing_raised { @dv.send("#{key}=".to_sym, true) } + assert_nothing_raised { @dv.send("#{key}=".to_sym, value) } end end def test_string_attribute_validation - @string_options.each do |key, _value| + @string_options.each do |key, value| assert_raise(ArgumentError, "#{key} must be string") { @dv.send("#{key}=".to_sym, :symbol) } - assert_nothing_raised { @dv.send("#{key}=".to_sym, "foo") } + assert_nothing_raised { @dv.send("#{key}=".to_sym, value) } end end diff --git a/test/workbook/worksheet/tc_sheet_protection.rb b/test/workbook/worksheet/tc_sheet_protection.rb index 08fe1cb9..1586afd5 100644 --- a/test/workbook/worksheet/tc_sheet_protection.rb +++ b/test/workbook/worksheet/tc_sheet_protection.rb @@ -44,10 +44,9 @@ class TestSheetProtection < Test::Unit::TestCase end def test_boolean_attribute_validation - @boolean_options.each do |key, _value| + @boolean_options.each do |key, value| assert_raise(ArgumentError, "#{key} must be boolean") { @sp.send("#{key}=".to_sym, 'A') } - assert_nothing_raised { @sp.send("#{key}=".to_sym, true) } - assert_nothing_raised { @sp.send("#{key}=".to_sym, true) } + assert_nothing_raised { @sp.send("#{key}=".to_sym, value) } end end diff --git a/test/workbook/worksheet/tc_sheet_view.rb b/test/workbook/worksheet/tc_sheet_view.rb index f53eb506..3d5b7f26 100644 --- a/test/workbook/worksheet/tc_sheet_view.rb +++ b/test/workbook/worksheet/tc_sheet_view.rb @@ -45,16 +45,16 @@ class TestSheetView < Test::Unit::TestCase end def test_boolean_attribute_validation - @boolean_options.each do |key, _value| + @boolean_options.each do |key, value| assert_raise(ArgumentError, "#{key} must be boolean") { @sv.send("#{key}=".to_sym, 'A') } - assert_nothing_raised { @sv.send("#{key}=".to_sym, true) } + assert_nothing_raised { @sv.send("#{key}=".to_sym, value) } end end def test_string_attribute_validation - @string_options.each do |key, _value| + @string_options.each do |key, value| assert_raise(ArgumentError, "#{key} must be string") { @sv.send("#{key}=".to_sym, :symbol) } - assert_nothing_raised { @sv.send("#{key}=".to_sym, "foo") } + assert_nothing_raised { @sv.send("#{key}=".to_sym, value) } end end -- cgit v1.2.3