From 8df90fd696334e13fdf32e76ed1df292f4590e4b Mon Sep 17 00:00:00 2001 From: Randy Morgan Date: Fri, 6 Jul 2012 22:38:46 +0900 Subject: make fit_to_page MOAR readable Implement some of the feedback from devolves session on readable code - and remove some garbage that found its way into the repo --- github.app you are too convenient. --- test/workbook/worksheet/tc_page_setup.rb | 23 ++++++++++++++++++++--- test/workbook/worksheet/tc_worksheet.rb | 5 +++-- 2 files changed, 23 insertions(+), 5 deletions(-) (limited to 'test') diff --git a/test/workbook/worksheet/tc_page_setup.rb b/test/workbook/worksheet/tc_page_setup.rb index cdf94b65..2fdbab59 100644 --- a/test/workbook/worksheet/tc_page_setup.rb +++ b/test/workbook/worksheet/tc_page_setup.rb @@ -54,6 +54,23 @@ class TestPageSetup < Test::Unit::TestCase assert_equal(nil, @ps.scale) end + def test_default_fit_to_page? + assert(@ps.fit_to_width == nil && @ps.fit_to_height == nil) + assert(@ps.fit_to_page? == false) + end + + def test_with_height_fit_to_page? + assert(@ps.fit_to_width == nil && @ps.fit_to_height == nil) + @ps.set(:fit_to_height => 1) + assert(@ps.fit_to_page?) + end + + def test_with_width_fit_to_page? + assert(@ps.fit_to_width == nil && @ps.fit_to_height == nil) + @ps.set(:fit_to_width => 1) + assert(@ps.fit_to_page?) + end + def test_to_xml_all_values @ps.set(:fit_to_height => 1, :fit_to_width => 2, :orientation => :landscape, :paper_height => "297mm", :paper_width => "210mm", :scale => 50) doc = Nokogiri::XML.parse(@ps.to_xml_string) @@ -106,7 +123,7 @@ class TestPageSetup < Test::Unit::TestCase assert_nothing_raised { @ps.scale = 99 } assert_equal(99, @ps.scale) end - + def test_fit_to fits = @ps.fit_to(:width => 1) assert_equal([1, 9999], fits) @@ -115,7 +132,7 @@ class TestPageSetup < Test::Unit::TestCase fits = @ps.fit_to :height => 7, :width => 2 assert_equal(fits, [2, 7]) assert_raise(ArgumentError) { puts @ps.fit_to(:width => true)} - - + + end end diff --git a/test/workbook/worksheet/tc_worksheet.rb b/test/workbook/worksheet/tc_worksheet.rb index 931ec51b..ed3fdfe6 100644 --- a/test/workbook/worksheet/tc_worksheet.rb +++ b/test/workbook/worksheet/tc_worksheet.rb @@ -201,8 +201,9 @@ class TestWorksheet < Test::Unit::TestCase end def test_fit_to_page_assignation_does_nothing - @ws.fit_to_page = false - assert_equal(@ws.fit_to_page, false) + @ws.fit_to_page = true + assert_equal(@ws.fit_to_page?, false) + end def test_to_xml_string_selected -- cgit v1.2.3