summaryrefslogtreecommitdiffhomepage
path: root/spec/dispatch/tools/definition_spec.rb
blob: ada2012b89f60ea453a99c4e13a767d831b59f4b (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
# frozen_string_literal: true

RSpec.describe Dispatch::Tools::Definition do
  let(:parameters_schema) do
    {
      type: "object",
      properties: {
        path: { type: "string", description: "File path" },
        start_line: { type: "integer", description: "Start line (0-based)" },
        end_line: { type: "integer", description: "End line (0-based, -1 for EOF)" }
      },
      required: [ "path" ]
    }
  end

  let(:tool) do
    described_class.new(
      name: "read_file",
      description: "Read the contents of a file",
      parameters: parameters_schema
    ) do |params, _context|
      Dispatch::Tools::Result.success(output: "contents of #{params[:path]}")
    end
  end

  describe "#initialize" do
    it "creates a definition with all attributes" do
      expect(tool.name).to eq("read_file")
      expect(tool.description).to eq("Read the contents of a file")
      expect(tool.parameters).to eq(parameters_schema)
    end

    it "has read-only attributes" do
      expect(tool).to respond_to(:name)
      expect(tool).to respond_to(:description)
      expect(tool).to respond_to(:parameters)
      expect(tool).not_to respond_to(:name=)
      expect(tool).not_to respond_to(:description=)
      expect(tool).not_to respond_to(:parameters=)
    end
  end

  describe "#call" do
    it "executes the block and returns a Result" do
      result = tool.call({ path: "src/main.rb" })

      expect(result).to be_a(Dispatch::Tools::Result)
      expect(result.success?).to be true
      expect(result.output).to eq("contents of src/main.rb")
    end

    it "passes context to the block" do
      context_tool = described_class.new(
        name: "context_test",
        description: "Test context passing",
        parameters: { type: "object", properties: {}, required: [] }
      ) do |_params, context|
        Dispatch::Tools::Result.success(output: "worktree: #{context[:worktree_path]}")
      end

      result = context_tool.call({}, context: { worktree_path: "/path/to/worktree" })

      expect(result.output).to eq("worktree: /path/to/worktree")
    end

    it "defaults context to an empty hash" do
      context_tool = described_class.new(
        name: "context_default",
        description: "Test default context",
        parameters: { type: "object", properties: {}, required: [] }
      ) do |_params, context|
        Dispatch::Tools::Result.success(output: "context is #{context.class}")
      end

      result = context_tool.call({})

      expect(result.output).to eq("context is Hash")
    end

    it "never raises when the block raises an exception" do
      failing_tool = described_class.new(
        name: "failing",
        description: "A tool that fails",
        parameters: { type: "object", properties: {}, required: [] }
      ) do |_params, _context|
        raise StandardError, "something broke"
      end

      result = nil
      expect { result = failing_tool.call({}) }.not_to raise_error

      expect(result.failure?).to be true
      expect(result.error).to include("something broke")
    end

    it "catches non-StandardError exceptions from the block" do
      failing_tool = described_class.new(
        name: "type_error_tool",
        description: "Raises TypeError",
        parameters: { type: "object", properties: {}, required: [] }
      ) do |_params, _context|
        raise TypeError, "wrong type"
      end

      result = nil
      expect { result = failing_tool.call({}) }.not_to raise_error

      expect(result.failure?).to be true
      expect(result.error).to include("wrong type")
    end

    it "returns Result.failure when params fail validation" do
      result = tool.call({})

      expect(result.failure?).to be true
      expect(result.error).to be_a(String)
      expect(result.error).not_to be_empty
    end

    it "symbolizes string-keyed params before passing to the block" do
      received_params = nil

      spy_tool = described_class.new(
        name: "spy",
        description: "Records params",
        parameters: {
          type: "object",
          properties: {
            name: { type: "string" }
          },
          required: []
        }
      ) do |params, _context|
        received_params = params
        Dispatch::Tools::Result.success(output: "ok")
      end

      spy_tool.call({ "name" => "Alice" })

      expect(received_params).to have_key(:name)
      expect(received_params).not_to have_key("name")
      expect(received_params[:name]).to eq("Alice")
    end

    it "handles deeply nested string keys by symbolizing top-level keys" do
      received_params = nil

      spy_tool = described_class.new(
        name: "deep_spy",
        description: "Records params",
        parameters: {
          type: "object",
          properties: {
            options: { type: "object" }
          },
          required: []
        }
      ) do |params, _context|
        received_params = params
        Dispatch::Tools::Result.success(output: "ok")
      end

      spy_tool.call({ "options" => { "nested" => true } })

      expect(received_params).to have_key(:options)
    end
  end

  describe "#to_h" do
    it "returns a hash with name, description, and parameters" do
      hash = tool.to_h

      expect(hash).to eq({
                           name: "read_file",
                           description: "Read the contents of a file",
                           parameters: parameters_schema
                         })
    end

    it "returns a plain hash, not a struct" do
      expect(tool.to_h).to be_a(Hash)
    end
  end

  describe "#to_tool_definition" do
    it "returns the same shape as to_h" do
      expect(tool.to_tool_definition).to eq(tool.to_h)
    end

    it "returns a plain hash" do
      expect(tool.to_tool_definition).to be_a(Hash)
    end
  end

  describe "#validate_params" do
    it "returns [true, []] for valid params" do
      valid, errors = tool.validate_params({ path: "src/main.rb" })

      expect(valid).to be true
      expect(errors).to eq([])
    end

    it "returns [true, []] for valid params with optional fields" do
      valid, errors = tool.validate_params({ path: "src/main.rb", start_line: 0, end_line: 10 })

      expect(valid).to be true
      expect(errors).to eq([])
    end

    it "returns [false, errors] when required params are missing" do
      valid, errors = tool.validate_params({})

      expect(valid).to be false
      expect(errors).not_to be_empty
    end

    it "returns [false, errors] when params have wrong types" do
      valid, errors = tool.validate_params({ path: 123 })

      expect(valid).to be false
      expect(errors).not_to be_empty
    end

    it "handles string-keyed params for validation" do
      valid, errors = tool.validate_params({ "path" => "src/main.rb" })

      expect(valid).to be true
      expect(errors).to eq([])
    end
  end
end