diff options
| author | Adam Malczewski <[email protected]> | 2026-06-05 13:07:23 +0900 |
|---|---|---|
| committer | Adam Malczewski <[email protected]> | 2026-06-05 13:07:23 +0900 |
| commit | c48d8ac7160c3cdcf32ed4e488807d3daeb8d457 (patch) | |
| tree | 1fccd7f35f051d8bae6bc8c6c5e3ffa22e816d0b /.dispatch/rules | |
| parent | 94dd5334b0277f3cf3b0588150a6615af86a32b3 (diff) | |
| download | dispatch-c48d8ac7160c3cdcf32ed4e488807d3daeb8d457.tar.gz dispatch-c48d8ac7160c3cdcf32ed4e488807d3daeb8d457.zip | |
feat(observability): Phase A logging substrate — Logger/Span ABI + journal sink (250 tests)
Structured, agent-first logging captured durably to an append-only journal file.
Kernel (contracts/logging.ts): leveled/attributed Logger + Span, auto-scoped per extension (host stamps manifest.id, unspoofable), incremental span records (open/close) for crash-reconstructable traces, injected LogSink (pure record-builder). ctx.log on ToolContract; runTurn opens turn/step/tool-call spans and captures the verbatim pre-mutation prompt (the 'before') on the step span.
journal-sink (new package, bootstrap dep — not an extension): LogSink appending NDJSON to a rotating journal; pure serialize + thin fs edge; fail-safe drop, never blocks a turn. host-bin injects it via HostDeps; session-orchestrator threads host.logger (childed per turn) into runTurn.
Redaction is per-extension self-redaction (no shared helper — isolation over DRY). The out-of-process collector + SQLite store + the verbatim 'after' provider.request capture are Phase B / next (notes/observability-design.md §10/§11).
Verified: tsc -b clean, 250 tests (218→+32), biome clean. Live boot: a turn's journal holds host logs + turn/step spans (open+close) + the prompt:before record with the verbatim messages array.
Harness: ORCHESTRATOR §3 rule-scoping map; .dispatch/rules/isolation-over-dry.md; notes/observability-design.md (design D1–D10 + Phase A/B plan).
Diffstat (limited to '.dispatch/rules')
| -rw-r--r-- | .dispatch/rules/isolation-over-dry.md | 12 |
1 files changed, 12 insertions, 0 deletions
diff --git a/.dispatch/rules/isolation-over-dry.md b/.dispatch/rules/isolation-over-dry.md new file mode 100644 index 0000000..55ac13a --- /dev/null +++ b/.dispatch/rules/isolation-over-dry.md @@ -0,0 +1,12 @@ +# Rule: isolation over DRY + +Prefer self-contained, even DUPLICATED, code in each extension over a shared helper +that two+ extensions import. A shared module wired between sibling features is a +coupling smell — it breaks feature-as-a-library (P1) and ties their fates together. +Get consistency by sharing KNOWLEDGE in the harness (`.dispatch/rules`, skills, +`GLOSSARY.md`), never shared runtime code. +The ONLY sanctioned shared surfaces are the kernel ABI (host-provided, injected) and +typed contracts — NOT a new utility module between features. +When tempted to "extract a helper for consistency," stop: that is reputation-driven +DRY (P4). Duplicating a small function across the few features that need it is the +intended trade. |