diff options
| author | Adam Malczewski <[email protected]> | 2026-06-02 22:50:11 +0900 |
|---|---|---|
| committer | Adam Malczewski <[email protected]> | 2026-06-02 22:50:11 +0900 |
| commit | 66e5d3b105bfd2b34c6f35876bf33dbb3cb9dcae (patch) | |
| tree | c3e039e09c89231f84dfd16f7bbbf8aedcc2dc7d /packages/frontend/src/lib/components | |
| parent | 4b45d33c256cf580a53054078be6fd7148fa6302 (diff) | |
| download | dispatch-66e5d3b105bfd2b34c6f35876bf33dbb3cb9dcae.tar.gz dispatch-66e5d3b105bfd2b34c6f35876bf33dbb3cb9dcae.zip | |
feat(chat): paste-to-attach images/PDFs with model capability check
Add multimodal image/PDF input to the chat box via clipboard paste, gated by a
graceful per-model capability check.
UX: a pasted image/PDF inserts an inline token (【image:…】 / 【pdf:…】) into the
draft, so attachments have ORDER relative to typed text and can be referenced
positionally. The token is the only handle — deleting it (atomic Backspace/
Delete, or selection overlap) detaches the file; an input-reconciliation safety
net detaches any attachment whose token is no longer intact. No preview strip.
Capability check: resolveModelCapabilities reads models.dev modalities.input
(new GET /models/capabilities, mirrors /context-limit). The input blocks Send
(no tokens spent) only on a definitive 'no'; unknown capability (catalog offline
/ unmapped provider) stays permissive. Attachments require a fresh turn — Send is
blocked while generating and /chat rejects content mid-turn (409).
Attachments are EPHEMERAL: forwarded to the model for the turn via ordered AI SDK
ImagePart/FilePart content, but never persisted (history keeps the text with
[image]/[pdf] markers). Text-only turns serialize byte-identically to before.
Limits (Anthropic-aligned, enforced at paste + re-validated server-side):
PNG/JPEG/WebP/GIF/PDF; image ≤5MB, PDF ≤32MB, ≤20 attachments, ≤32MB total.
core: UserContentPart types, models/attachments validator, capability resolver,
agent.run+toModelMessages thread ordered content. api: /chat content validation +
passthrough. frontend: attachment-tokens helper, ChatInput paste/token/gating,
per-tab staged attachments, App.svelte capability fetch. +44 tests.
Diffstat (limited to 'packages/frontend/src/lib/components')
| -rw-r--r-- | packages/frontend/src/lib/components/ChatInput.svelte | 223 |
1 files changed, 214 insertions, 9 deletions
diff --git a/packages/frontend/src/lib/components/ChatInput.svelte b/packages/frontend/src/lib/components/ChatInput.svelte index 079ef4a..4067b78 100644 --- a/packages/frontend/src/lib/components/ChatInput.svelte +++ b/packages/frontend/src/lib/components/ChatInput.svelte @@ -1,12 +1,40 @@ <script lang="ts"> +import { + ACCEPTED_PDF_MEDIA_TYPE, + isImageMediaType, + isPdfMediaType, + MAX_ATTACHMENTS, + MAX_IMAGE_BYTES, + MAX_PDF_BYTES, +} from "@dispatch/core/src/models/attachments.js"; +import { + type AttachmentKind, + computeTokenDeletion, + generateTokenId, + makeAttachmentToken, + parseDraft, + type StagedAttachment, +} from "../attachment-tokens.js"; import { computeContextUsage } from "../context-window.js"; import { tabStore } from "../tabs.svelte.js"; -const { contextLimit = null }: { contextLimit?: number | null } = $props(); +const { + contextLimit = null, + imageSupport = null, +}: { + contextLimit?: number | null; + // Image/PDF INPUT capability for the active model, or `null` when unknown + // (catalog offline / unsupported provider) — null means "can't verify" + // (optimistic allow), not a hard no. + imageSupport?: { image: boolean; pdf: boolean } | null; +} = $props(); const MAX_LINES = 7; let inputEl: HTMLTextAreaElement | undefined; +// Transient error shown when a paste is rejected (bad type / too large / too +// many). Cleared on the next successful paste or any keystroke. +let pasteError = $state<string | null>(null); const agentStatus = $derived(tabStore.activeTab?.agentStatus ?? "idle"); const tabId = $derived(tabStore.activeTab?.id ?? ""); @@ -14,13 +42,47 @@ const tabId = $derived(tabStore.activeTab?.id ?? ""); // switching tabs saves the current draft and restores the target tab's text // automatically — drafts are never lost or clobbered by tab switching. const inputValue = $derived(tabStore.activeTab?.draft ?? ""); +const attachments = $derived(tabStore.activeTab?.attachments ?? []); const cacheStats = $derived(tabStore.activeTab?.cacheStats ?? null); const isRunning = $derived(agentStatus === "running"); const hasText = $derived(inputValue.trim().length > 0); +const hasAttachments = $derived(attachments.length > 0); // While generating with an empty box, the primary action is "stop". With text // in the box, it stays "send" (the message is queued behind the live turn). -const showStop = $derived(isRunning && !hasText); +const showStop = $derived(isRunning && !hasText && !hasAttachments); + +// ─── Attachment capability gating ────────────────────────────── +// A definitive "no" from the catalog (imageSupport.image === false with an +// image staged, or .pdf === false with a pdf staged) blocks the send so no +// tokens are spent. Unknown capability (imageSupport === null) is permissive. +const hasImageAttachment = $derived(attachments.some((a) => a.kind === "image")); +const hasPdfAttachment = $derived(attachments.some((a) => a.kind === "pdf")); +const imageBlocked = $derived( + hasImageAttachment && imageSupport !== null && imageSupport.image === false, +); +const pdfBlocked = $derived( + hasPdfAttachment && imageSupport !== null && imageSupport.pdf === false, +); +// Attachments require a fresh turn — they can't ride the queue path (which is +// text-only), so block sending an attachment while the agent is generating. +const attachmentsWhileRunning = $derived(hasAttachments && isRunning); + +const attachmentWarning = $derived.by(() => { + if (pasteError) return pasteError; + if (attachmentsWhileRunning) + return "Wait for the current response to finish before sending images."; + if (imageBlocked && pdfBlocked) + return "The selected model doesn't support image or PDF input. Remove the attachments to send."; + if (imageBlocked) + return "The selected model doesn't support image input. Remove the image to send."; + if (pdfBlocked) return "The selected model doesn't support PDF input. Remove the PDF to send."; + return null; +}); + +// Send is blocked (but not the box) when an attachment is definitively +// unsupported or when attachments are staged mid-generation. +const sendBlocked = $derived(imageBlocked || pdfBlocked || attachmentsWhileRunning); const usage = $derived(computeContextUsage(cacheStats, contextLimit)); const hasUsage = $derived((cacheStats?.last ?? null) !== null); @@ -77,21 +139,153 @@ $effect(() => { function handleInput(e: Event) { if (!tabId) return; + pasteError = null; + // setDraft also reconciles staged attachments against the surviving tokens, + // so deleting a token (by any means) detaches its attachment. tabStore.setDraft(tabId, (e.currentTarget as HTMLTextAreaElement).value); } +function kindForMediaType(mediaType: string): AttachmentKind | null { + if (isImageMediaType(mediaType)) return "image"; + if (isPdfMediaType(mediaType)) return "pdf"; + return null; +} + +function readAsBase64(file: File): Promise<string> { + return new Promise((resolve, reject) => { + const reader = new FileReader(); + reader.onload = () => { + const result = reader.result; + if (typeof result !== "string") { + reject(new Error("unexpected reader result")); + return; + } + // Strip the `data:<mediaType>;base64,` prefix → bare base64. + const comma = result.indexOf(","); + resolve(comma === -1 ? result : result.slice(comma + 1)); + }; + reader.onerror = () => reject(reader.error ?? new Error("read failed")); + reader.readAsDataURL(file); + }); +} + +/** Insert `insert` at the textarea's caret, returning the new caret offset. */ +function insertAtCaret(insert: string): number { + const el = inputEl; + const text = inputValue; + const start = el?.selectionStart ?? text.length; + const end = el?.selectionEnd ?? text.length; + const next = text.slice(0, start) + insert + text.slice(end); + if (tabId) tabStore.setDraft(tabId, next); + return start + insert.length; +} + +async function handlePaste(e: ClipboardEvent) { + if (!tabId) return; + const items = e.clipboardData?.items; + if (!items) return; + const files: File[] = []; + for (const item of items) { + if (item.kind === "file") { + const file = item.getAsFile(); + if (file) files.push(file); + } + } + // No files in the clipboard → let the default text paste happen. + if (files.length === 0) return; + // We're handling at least one file; stop the browser from also pasting a + // filename / image fallback into the textarea. + e.preventDefault(); + pasteError = null; + + for (const file of files) { + const kind = kindForMediaType(file.type); + if (!kind) { + pasteError = `Unsupported file type: ${file.type || "unknown"}. Allowed: PNG, JPEG, WebP, GIF, PDF.`; + continue; + } + const current = tabStore.activeTab?.attachments ?? []; + if (current.length >= MAX_ATTACHMENTS) { + pasteError = `You can attach at most ${MAX_ATTACHMENTS} files per message.`; + break; + } + const limit = kind === "pdf" ? MAX_PDF_BYTES : MAX_IMAGE_BYTES; + if (file.size > limit) { + const mb = Math.round(limit / (1024 * 1024)); + pasteError = `${kind === "pdf" ? "PDF" : "Image"} is too large (max ${mb} MB).`; + continue; + } + try { + const data = await readAsBase64(file); + const id = generateTokenId(); + const mediaType = kind === "pdf" ? ACCEPTED_PDF_MEDIA_TYPE : file.type; + const staged: StagedAttachment = { + id, + kind, + mediaType, + data, + ...(file.name ? { name: file.name } : {}), + }; + // Stage first, then insert the token — `setDraft` reconciles against + // staged attachments, so the attachment must exist before its token + // appears in the draft. + tabStore.addAttachment(tabId, staged); + const caret = insertAtCaret(makeAttachmentToken(kind, id)); + // Restore the caret after the value updates. + requestAnimationFrame(() => { + const el = inputEl; + if (el) { + el.focus(); + el.setSelectionRange(caret, caret); + } + }); + } catch { + pasteError = "Failed to read the pasted file."; + } + } +} + function handleKeydown(e: KeyboardEvent) { if (e.key === "Enter" && !e.shiftKey) { e.preventDefault(); submit(); + return; + } + if ((e.key === "Backspace" || e.key === "Delete") && inputEl && tabId) { + // Atomic token delete: a single Backspace/Delete next to (or a selection + // overlapping) a `【…】` token removes the whole token in one stroke. + const result = computeTokenDeletion( + inputValue, + inputEl.selectionStart ?? 0, + inputEl.selectionEnd ?? 0, + e.key, + ); + if (result) { + e.preventDefault(); + tabStore.setDraft(tabId, result.text); + requestAnimationFrame(() => { + const el = inputEl; + if (el) { + el.focus(); + el.setSelectionRange(result.caret, result.caret); + } + }); + } } } function submit() { - const text = inputValue.trim(); - if (!text) return; - if (tabId) tabStore.setDraft(tabId, ""); - tabStore.sendMessage(text); + if (!tabId) return; + const map = new Map(attachments.map((a) => [a.id, a] as const)); + const { displayText, content } = parseDraft(inputValue, map); + const trimmed = displayText.trim(); + // Nothing to send (no text and no usable attachment). + if (!trimmed && !content) return; + // Don't send when a staged attachment is unsupported / mid-generation. + if (sendBlocked) return; + const text = trimmed || displayText; + tabStore.setDraft(tabId, ""); + void tabStore.sendMessage(text, content ?? undefined); } function primaryAction() { @@ -104,25 +298,36 @@ function primaryAction() { </script> <div class="flex flex-col"> + {#if attachmentWarning} + <div class="px-3 pt-2 text-xs text-warning flex items-start gap-1"> + <svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2" stroke-linecap="round" stroke-linejoin="round" class="w-3.5 h-3.5 mt-0.5 shrink-0" aria-hidden="true"> + <path d="M10.29 3.86 1.82 18a2 2 0 0 0 1.71 3h16.94a2 2 0 0 0 1.71-3L13.71 3.86a2 2 0 0 0-3.42 0z"></path> + <line x1="12" y1="9" x2="12" y2="13"></line> + <line x1="12" y1="17" x2="12.01" y2="17"></line> + </svg> + <span>{attachmentWarning}</span> + </div> + {/if} <!-- Top bar: expanding textarea + send/stop action --> <div class="flex items-end gap-2 px-3 pt-3 pb-2"> <textarea bind:this={inputEl} value={inputValue} rows="1" - placeholder="Type a message..." + placeholder="Type a message... (paste an image or PDF to attach)" class="textarea textarea-ghost flex-1 resize-none leading-normal !min-h-0 h-auto" onkeydown={handleKeydown} oninput={handleInput} + onpaste={handlePaste} ></textarea> <!-- Single fixed-width button across all states so the layout never shifts when it morphs between Send and Stop. --> <button type="button" class="btn w-20 shrink-0 {showStop ? 'btn-error btn-outline' : 'btn-primary'}" - disabled={!showStop && !hasText} + disabled={!showStop && !hasText && !hasAttachments || sendBlocked} onclick={primaryAction} - title={showStop ? "Stop generation" : "Send message"} + title={showStop ? "Stop generation" : sendBlocked ? (attachmentWarning ?? "Cannot send") : "Send message"} > {#if showStop} <span class="loading loading-spinner loading-sm"></span> |
