From de6df4abdd8a6eb9a0217050ce17e0925f04602b Mon Sep 17 00:00:00 2001 From: Adam Malczewski Date: Tue, 19 May 2026 20:50:12 +0900 Subject: fix: review findings — multi-turn history, race condition, collapse UI MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - Core: toCoreMessages now includes tool calls and tool results in history - Core: isError read from step tool results instead of hardcoded false - API: status set synchronously before async generator to prevent race - Frontend: DaisyUI collapse-open class applied dynamically on expanded state - Frontend: removed duplicate isConnected update in wsClient.onEvent --- packages/frontend/src/lib/chat.svelte.ts | 4 ---- packages/frontend/src/lib/components/ToolCallDisplay.svelte | 2 +- 2 files changed, 1 insertion(+), 5 deletions(-) (limited to 'packages/frontend') diff --git a/packages/frontend/src/lib/chat.svelte.ts b/packages/frontend/src/lib/chat.svelte.ts index e5367c2..fc5f68c 100644 --- a/packages/frontend/src/lib/chat.svelte.ts +++ b/packages/frontend/src/lib/chat.svelte.ts @@ -66,10 +66,6 @@ function createChatStore() { let currentAssistantId: string | null = null; wsClient.onEvent((event) => { - const connected = wsClient.connectionStatus === "connected"; - if (connected !== isConnected) { - isConnected = connected; - } handleEvent(event); }); diff --git a/packages/frontend/src/lib/components/ToolCallDisplay.svelte b/packages/frontend/src/lib/components/ToolCallDisplay.svelte index f8e1f38..83d21ba 100644 --- a/packages/frontend/src/lib/components/ToolCallDisplay.svelte +++ b/packages/frontend/src/lib/components/ToolCallDisplay.svelte @@ -10,7 +10,7 @@ function toggle() { } -
+