1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
|
import type { SurfaceSpec } from "@dispatch/ui-contract";
import type { QueuedMessage, QueuePayload } from "@dispatch/wire";
import { describe, expect, it } from "vitest";
import { buildQueueSpec, combine } from "./pure.js";
import { createMessageQueueService, type MessageQueueDeps } from "./service.js";
interface Recorder extends MessageQueueDeps {
readonly calls: { value: number };
}
function makeDeps(): Recorder {
let idCounter = 0;
let now = 1_000;
const calls = { value: 0 };
return {
id: () => `q-${++idCounter}`,
now: () => (now += 10),
notify: () => {
calls.value += 1;
},
calls,
};
}
function queueMessages(spec: SurfaceSpec): readonly QueuedMessage[] {
const field = spec.fields[0];
if (field === undefined || field.kind !== "custom") {
throw new Error("expected a custom field");
}
return (field.payload as QueuePayload).messages;
}
describe("message-queue service", () => {
it("enqueue pushes a surface update (snapshot grew)", () => {
const deps = makeDeps();
const svc = createMessageQueueService(deps);
expect(deps.calls.value).toBe(0);
const snapshot = svc.enqueue("c1", "hello");
expect(deps.calls.value).toBe(1); // surface update pushed
expect(snapshot).toHaveLength(1);
const first = snapshot[0];
if (first === undefined) throw new Error("expected a message");
expect(first.text).toBe("hello");
expect(typeof first.id).toBe("string");
expect(first.queuedAt).toBe(1_010);
// the surface spec reflects the grown snapshot
expect(queueMessages(buildQueueSpec(svc.getQueue("c1")))).toHaveLength(1);
});
it("drain pushes a surface update (empty)", () => {
const deps = makeDeps();
const svc = createMessageQueueService(deps);
svc.enqueue("c1", "a");
svc.enqueue("c1", "b");
expect(deps.calls.value).toBe(2); // two enqueues notified
const drained = svc.drain("c1");
expect(deps.calls.value).toBe(3); // drain pushed a surface update
expect(drained).toHaveLength(2);
expect(drained.map((m) => m.text)).toEqual(["a", "b"]);
// cleared + surface now shows empty
expect(svc.getQueue("c1")).toEqual([]);
expect(queueMessages(buildQueueSpec(svc.getQueue("c1")))).toEqual([]);
});
it("drain on empty does NOT push a surface update (already empty)", () => {
const deps = makeDeps();
const svc = createMessageQueueService(deps);
expect(svc.drain("c1")).toEqual([]);
expect(deps.calls.value).toBe(0); // no notify — no change
// after a real drain empties it, a further drain is a no-op (no notify)
svc.enqueue("c1", "x");
expect(deps.calls.value).toBe(1);
svc.drain("c1");
expect(deps.calls.value).toBe(2);
svc.drain("c1");
expect(deps.calls.value).toBe(2); // unchanged — queue was already empty
});
it("getQueue returns current snapshot; empty for unknown conversation", () => {
const deps = makeDeps();
const svc = createMessageQueueService(deps);
expect(svc.getQueue("nope")).toEqual([]);
svc.enqueue("c1", "hi");
expect(svc.getQueue("c1")).toHaveLength(1);
});
it("drain returns the raw QueuedMessage[] the orchestrator combines", () => {
const deps = makeDeps();
const svc = createMessageQueueService(deps);
svc.enqueue("c1", "alpha");
svc.enqueue("c1", "beta");
const drained = svc.drain("c1");
expect(combine(drained)).toBe("alpha\n\nbeta");
});
});
describe("message-queue service cancel", () => {
it("cancel removes the message and pushes a surface update (queue shrank)", () => {
const deps = makeDeps();
const svc = createMessageQueueService(deps);
svc.enqueue("c1", "a"); // q-1
svc.enqueue("c1", "b"); // q-2
svc.enqueue("c1", "c"); // q-3
expect(deps.calls.value).toBe(3); // three enqueues notified
const snapshot = svc.cancel("c1", "q-2");
expect(deps.calls.value).toBe(4); // cancel pushed a surface update
expect(snapshot.map((m) => m.id)).toEqual(["q-1", "q-3"]);
// live state reflects the removal
expect(svc.getQueue("c1").map((m) => m.id)).toEqual(["q-1", "q-3"]);
});
it("cancel of the only message empties the queue + pushes a surface update", () => {
const deps = makeDeps();
const svc = createMessageQueueService(deps);
svc.enqueue("c1", "only"); // q-1
expect(deps.calls.value).toBe(1);
const snapshot = svc.cancel("c1", "q-1");
expect(deps.calls.value).toBe(2); // surface update (queue → empty)
expect(snapshot).toEqual([]);
expect(svc.getQueue("c1")).toEqual([]);
});
it("cancel of a missing id does NOT push a surface update (no change)", () => {
const deps = makeDeps();
const svc = createMessageQueueService(deps);
svc.enqueue("c1", "a"); // q-1
expect(deps.calls.value).toBe(1);
// unknown message id — no-op, no notify
const snapshot = svc.cancel("c1", "nope");
expect(deps.calls.value).toBe(1); // unchanged — no change
expect(snapshot.map((m) => m.id)).toEqual(["q-1"]);
// unknown conversation — also a no-op, no notify
expect(svc.cancel("nope", "q-1")).toEqual([]);
expect(deps.calls.value).toBe(1); // still unchanged
});
it("cancel after a drain (queue empty) is a no-op with no surface update", () => {
const deps = makeDeps();
const svc = createMessageQueueService(deps);
svc.enqueue("c1", "a"); // q-1
svc.drain("c1");
expect(deps.calls.value).toBe(2); // enqueue + drain
expect(svc.cancel("c1", "q-1")).toEqual([]);
expect(deps.calls.value).toBe(2); // no notify — queue was already empty
});
it("cancel is scoped per conversation", () => {
const deps = makeDeps();
const svc = createMessageQueueService(deps);
svc.enqueue("c1", "a"); // q-1
svc.enqueue("c2", "b"); // q-2
const snapshot = svc.cancel("c1", "q-1");
expect(snapshot).toEqual([]);
expect(svc.getQueue("c1")).toEqual([]);
expect(svc.getQueue("c2").map((m) => m.id)).toEqual(["q-2"]);
});
});
|
