summaryrefslogtreecommitdiffhomepage
diff options
context:
space:
mode:
authorChristopher Aue <[email protected]>2017-07-18 22:27:11 +0200
committerChristopher Aue <[email protected]>2017-07-18 22:55:37 +0200
commit468cc34c930bb3169e559354497202edf66c22fc (patch)
tree36e33d9bde1a4a3ca16b2dc6f89d1e926ee8071b
parent52aafcd001095470ac1c397bdf83ce10e919c753 (diff)
downloadmruby-468cc34c930bb3169e559354497202edf66c22fc.tar.gz
mruby-468cc34c930bb3169e559354497202edf66c22fc.zip
Fixed Module#to_s and #name for #const_set modules
-rw-r--r--mrbgems/mruby-class-ext/test/module.rb26
-rw-r--r--src/class.c3
-rw-r--r--test/t/module.rb22
3 files changed, 43 insertions, 8 deletions
diff --git a/mrbgems/mruby-class-ext/test/module.rb b/mrbgems/mruby-class-ext/test/module.rb
index f721ad0c6..cfe6a540f 100644
--- a/mrbgems/mruby-class-ext/test/module.rb
+++ b/mrbgems/mruby-class-ext/test/module.rb
@@ -1,10 +1,24 @@
assert 'Module#name' do
- module A
- class B
- end
+ module Outer
+ class Inner; end
+ const_set :SetInner, Class.new
end
- assert_nil A::B.singleton_class.name
- assert_equal 'Fixnum', Fixnum.name
- assert_equal 'A::B', A::B.name
+ assert_equal 'Outer', Outer.name
+ assert_equal 'Outer::Inner', Outer::Inner.name
+ assert_equal 'Outer::SetInner', Outer::SetInner.name
+
+ outer = Module.new do
+ const_set :SetInner, Class.new
+ end
+ Object.const_set :SetOuter, outer
+
+ assert_equal 'SetOuter', SetOuter.name
+ assert_equal 'SetOuter::SetInner', SetOuter::SetInner.name
+
+ mod = Module.new
+ cls = Class.new
+
+ assert_nil mod.name
+ assert_nil cls.name
end
diff --git a/src/class.c b/src/class.c
index e4e177f04..dd889cbbf 100644
--- a/src/class.c
+++ b/src/class.c
@@ -2178,6 +2178,9 @@ mrb_mod_const_set(mrb_state *mrb, mrb_value mod)
mrb_get_args(mrb, "no", &id, &value);
check_const_name_sym(mrb, id);
+ if (mrb_type(value) == MRB_TT_CLASS || mrb_type(value) == MRB_TT_MODULE) {
+ setup_class(mrb, mrb_class_ptr(mod), mrb_class_ptr(value), id);
+ }
mrb_const_set(mrb, mod, id, value);
return value;
}
diff --git a/test/t/module.rb b/test/t/module.rb
index cfdca8503..419b0bfd5 100644
--- a/test/t/module.rb
+++ b/test/t/module.rb
@@ -787,10 +787,28 @@ end
# @!endgroup prepend
assert('Module#to_s') do
- module Test4to_sModules
+ module Outer
+ class Inner; end
+ const_set :SetInner, Class.new
+ end
+
+ assert_equal 'Outer', Outer.to_s
+ assert_equal 'Outer::Inner', Outer::Inner.to_s
+ assert_equal 'Outer::SetInner', Outer::SetInner.to_s
+
+ outer = Module.new do
+ const_set :SetInner, Class.new
end
+ Object.const_set :SetOuter, outer
+
+ assert_equal 'SetOuter', SetOuter.to_s
+ assert_equal 'SetOuter::SetInner', SetOuter::SetInner.to_s
+
+ mod = Module.new
+ cls = Class.new
- assert_equal 'Test4to_sModules', Test4to_sModules.to_s
+ assert_equal "#<Module:0x", mod.to_s[0,11]
+ assert_equal "#<Class:0x", cls.to_s[0,10]
end
assert('Module#inspect') do