summaryrefslogtreecommitdiffhomepage
diff options
context:
space:
mode:
authorMasaki Muranaka <[email protected]>2013-06-11 16:09:12 +0900
committerMasaki Muranaka <[email protected]>2013-06-11 16:09:12 +0900
commit97b9caf8924c0aec76d53c56666e3bf0d13f39fd (patch)
treeea47a63640fe7843c548eadec859447f4f36d9df
parent4e877bc92f4faac950d2b6269cd4f8a0d153a432 (diff)
downloadmruby-97b9caf8924c0aec76d53c56666e3bf0d13f39fd.tar.gz
mruby-97b9caf8924c0aec76d53c56666e3bf0d13f39fd.zip
Check parameters strictly.
calloc in C99 is expected to return NULL when nelem * len == 0.
-rw-r--r--src/gc.c12
1 files changed, 8 insertions, 4 deletions
diff --git a/src/gc.c b/src/gc.c
index 6419726eb..293fbf948 100644
--- a/src/gc.c
+++ b/src/gc.c
@@ -184,15 +184,19 @@ mrb_malloc(mrb_state *mrb, size_t len)
void*
mrb_calloc(mrb_state *mrb, size_t nelem, size_t len)
{
- void *p = NULL;
- size_t size;
+ void *p;
- if (nelem <= SIZE_MAX / len) {
+ if (nelem > 0 && len > 0 &&
+ nelem <= SIZE_MAX / len) {
+ size_t size;
size = nelem * len;
p = mrb_realloc(mrb, 0, size);
- if (p && size > 0)
+ if (p) {
memset(p, 0, size);
+ }
+ } else {
+ p = NULL;
}
return p;