diff options
| author | Yukihiro "Matz" Matsumoto <[email protected]> | 2020-11-21 16:55:40 +0900 |
|---|---|---|
| committer | Yukihiro "Matz" Matsumoto <[email protected]> | 2020-11-21 16:55:40 +0900 |
| commit | 734f6b1cc40f9397b3cca0ecfcd7e19ad683562a (patch) | |
| tree | 51d40e8a773c59857621579d90b1dfbd2108adaa /CONTRIBUTING.md | |
| parent | 55e127577863e0f913a4b7b8653fcba577c29b86 (diff) | |
| download | mruby-734f6b1cc40f9397b3cca0ecfcd7e19ad683562a.tar.gz mruby-734f6b1cc40f9397b3cca0ecfcd7e19ad683562a.zip | |
Remove 2 restrictions from `CONTRIBUTING.md`; close #5159
* Allow mixed declarations, especially loop variables
* Allow C++ style commends `//`
Diffstat (limited to 'CONTRIBUTING.md')
| -rw-r--r-- | CONTRIBUTING.md | 11 |
1 files changed, 0 insertions, 11 deletions
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index ec25f89b1..fec2e8907 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -33,11 +33,6 @@ mruby should be highly portable to other systems and compilers. For this it is recommended to keep your code as close as possible to the C99 standard (http://www.open-std.org/jtc1/sc22/WG14/www/docs/n1256.pdf). -Although we target C99, we've heard some compilers in the embedded environment -still requires declarations of local variables to be at the beginning of a -scope. Until we confirm the situation has changed, we use the old-style -variable declaration. - Visual C++ is also an important target for mruby (supported version is 2013 or later). For this reason features that are not supported by Visual C++ may not be used (e.g. `%z` of `strftime()`). @@ -50,12 +45,6 @@ The dependencies to libraries should be kept to an absolute minimum. This increases the portability but makes it also easier to cut away parts of mruby on-demand. -#### Don't use C++ style comments - - /* This is the preferred comment style */ - -Use C++ style comments only for temporary comment e.g. commenting out some code lines. - #### Insert a break after the function return value: int |
