diff options
| author | Nobuyoshi Nakada <[email protected]> | 2017-04-29 10:07:04 +0900 |
|---|---|---|
| committer | Nobuyoshi Nakada <[email protected]> | 2017-04-29 10:10:31 +0900 |
| commit | e05c30738ead860f7d59fe1de7cd14cad2b36cc0 (patch) | |
| tree | 7d169b7e8108af6315dab0abd98eb60962eade74 /mrbgems/mruby-sprintf/src/sprintf.c | |
| parent | 3c1078376918c8b8d30b86585655c343dfb3ad16 (diff) | |
| download | mruby-e05c30738ead860f7d59fe1de7cd14cad2b36cc0.tar.gz mruby-e05c30738ead860f7d59fe1de7cd14cad2b36cc0.zip | |
Use `FILL` and `PUSH`
Instead of loop or `memcpy` after `CHECK`, use dedicated macros,
`FILL` and `PUSH`, respectively.
Diffstat (limited to 'mrbgems/mruby-sprintf/src/sprintf.c')
| -rw-r--r-- | mrbgems/mruby-sprintf/src/sprintf.c | 45 |
1 files changed, 10 insertions, 35 deletions
diff --git a/mrbgems/mruby-sprintf/src/sprintf.c b/mrbgems/mruby-sprintf/src/sprintf.c index 7dab63a17..d99d74efc 100644 --- a/mrbgems/mruby-sprintf/src/sprintf.c +++ b/mrbgems/mruby-sprintf/src/sprintf.c @@ -716,21 +716,15 @@ retry: c = RSTRING_PTR(tmp); n = RSTRING_LEN(tmp); if (!(flags & FWIDTH)) { - CHECK(n); - memcpy(buf+blen, c, n); - blen += n; + PUSH(c, n); } else if ((flags & FMINUS)) { - CHECK(n); - memcpy(buf+blen, c, n); - blen += n; + PUSH(c, n); if (width>0) FILL(' ', width-1); } else { if (width>0) FILL(' ', width-1); - CHECK(n); - memcpy(buf+blen, c, n); - blen += n; + PUSH(c, n); } } break; @@ -768,19 +762,11 @@ retry: if ((flags&FWIDTH) && (width > slen)) { width -= (int)slen; if (!(flags&FMINUS)) { - CHECK(width); - while (width-- > 0) { - buf[blen++] = ' '; - } + FILL(' ', width); } - CHECK(len); - memcpy(&buf[blen], RSTRING_PTR(str), len); - blen += len; + PUSH(RSTRING_PTR(str), len); if (flags&FMINUS) { - CHECK(width); - while (width-- > 0) { - buf[blen++] = ' '; - } + FILL(' ', width); } break; } @@ -986,10 +972,7 @@ retry: } if (!(flags&FMINUS) && width > 0) { - CHECK(width); - while (width-- > 0) { - buf[blen++] = ' '; - } + FILL(' ', width); } if (sc) PUSH(&sc, 1); @@ -998,28 +981,20 @@ retry: int plen = (int)strlen(prefix); PUSH(prefix, plen); } - CHECK(prec - len); if (dots) PUSH("..", 2); if (v < 0) { char c = sign_bits(base, p); - while (len < prec--) { - buf[blen++] = c; - } + FILL(c, prec - len); } else if ((flags & (FMINUS|FPREC)) != FMINUS) { char c = '0'; - while (len < prec--) { - buf[blen++] = c; - } + FILL(c, prec - len); } PUSH(s, len); if (width > 0) { - CHECK(width); - while (width-- > 0) { - buf[blen++] = ' '; - } + FILL(' ', width); } } break; |
