summaryrefslogtreecommitdiffhomepage
path: root/mrbgems/mruby-string-ext
diff options
context:
space:
mode:
authordearblue <[email protected]>2019-08-18 15:34:14 +0900
committerdearblue <[email protected]>2019-08-18 15:38:25 +0900
commit05a873c25c270072cf979bbe730e7989e8fc4cc9 (patch)
tree1ed0d2d36616f12cc230764154dbabd03324cb31 /mrbgems/mruby-string-ext
parent83dab1ee0d0d3aa76e44f7fbf14360ee501be151 (diff)
downloadmruby-05a873c25c270072cf979bbe730e7989e8fc4cc9.tar.gz
mruby-05a873c25c270072cf979bbe730e7989e8fc4cc9.zip
Simplify get arguments
- `mrb_str_index_m()` and `mrb_str_rindex()` Make `mrb_get_args()` called only once from called twice. - `mrb_str_byteslice()` Replace `goto` with `if ~ else`.
Diffstat (limited to 'mrbgems/mruby-string-ext')
-rw-r--r--mrbgems/mruby-string-ext/src/string.c17
1 files changed, 8 insertions, 9 deletions
diff --git a/mrbgems/mruby-string-ext/src/string.c b/mrbgems/mruby-string-ext/src/string.c
index a946140dd..e3b8d9960 100644
--- a/mrbgems/mruby-string-ext/src/string.c
+++ b/mrbgems/mruby-string-ext/src/string.c
@@ -134,19 +134,18 @@ mrb_str_byteslice(mrb_state *mrb, mrb_value str)
if (mrb_get_args(mrb, "o|o", &a1, &a2) == 2) {
beg = mrb_fixnum(mrb_to_int(mrb, a1));
len = mrb_fixnum(mrb_to_int(mrb, a2));
- goto subseq;
}
- if (mrb_type(a1) == MRB_TT_RANGE) {
- if (mrb_range_beg_len(mrb, a1, &beg, &len, str_len, TRUE) == MRB_RANGE_OK) {
- goto subseq;
+ else if (mrb_type(a1) == MRB_TT_RANGE) {
+ if (mrb_range_beg_len(mrb, a1, &beg, &len, str_len, TRUE) != MRB_RANGE_OK) {
+ return mrb_nil_value();
}
- return mrb_nil_value();
+ }
+ else {
+ beg = mrb_fixnum(mrb_to_int(mrb, a1));
+ len = 1;
+ empty = FALSE;
}
- beg = mrb_fixnum(mrb_to_int(mrb, a1));
- len = 1;
- empty = FALSE;
-subseq:
if (mrb_str_beg_len(str_len, &beg, &len) && (empty || len != 0)) {
return mrb_str_byte_subseq(mrb, str, beg, len);
}