diff options
| author | KOBAYASHI Shuji <[email protected]> | 2020-11-16 20:20:30 +0900 |
|---|---|---|
| committer | KOBAYASHI Shuji <[email protected]> | 2020-11-16 20:20:30 +0900 |
| commit | 7c470e25b8f1e2308e47a3b49b5910e8115ab500 (patch) | |
| tree | 100d68e888e109460de84cffc438c9c4a4bf4858 /src/codedump.c | |
| parent | 8a6614d30e4d1d55f06de2ff77c528dfc6729ab5 (diff) | |
| download | mruby-7c470e25b8f1e2308e47a3b49b5910e8115ab500.tar.gz mruby-7c470e25b8f1e2308e47a3b49b5910e8115ab500.zip | |
Avoid undefined behavior
### ASAN report (`MRB_INT32`)
```console
$ bin/mruby -ve '-0x40000000'
mruby 3.0.0preview (2020-10-16)
00001 NODE_SCOPE:
00001 NODE_BEGIN:
00001 NODE_NEGATE:
00001 NODE_INT 40000000 base 16
irep 0x6070000001e0 nregs=2 nlocals=1 pools=0 syms=0 reps=0 iseq=9
file: -e
/mruby/src/codedump.c:173:49: runtime error: left shift of 49152 by 16 places cannot be represented in type 'int'
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /mruby/src/codedump.c:173:49 in
1 000 OP_LOADI32 R1 -1073741824
1 006 OP_RETURN R1
1 008 OP_STOP
/mruby/src/vm.c:1138:7: runtime error: left shift of 49152 by 16 places cannot be represented in type 'mrb_int' (aka 'int')
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /mruby/src/vm.c:1138:7 in
```
Diffstat (limited to 'src/codedump.c')
| -rw-r--r-- | src/codedump.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/codedump.c b/src/codedump.c index 5acc274c3..e70df3205 100644 --- a/src/codedump.c +++ b/src/codedump.c @@ -170,7 +170,7 @@ codedump(mrb_state *mrb, const mrb_irep *irep) print_lv_a(mrb, irep, a); break; CASE(OP_LOADI32, BSS); - printf("OP_LOADI32\tR%d\t%d\t", a, (int)(b<<16)+c); + printf("OP_LOADI32\tR%d\t%d\t", a, (int)(((uint32_t)b<<16)+c)); print_lv_a(mrb, irep, a); break; CASE(OP_LOADI__1, B); |