diff options
| author | Yukihiro "Matz" Matsumoto <[email protected]> | 2014-04-12 16:30:45 +0900 |
|---|---|---|
| committer | Yukihiro "Matz" Matsumoto <[email protected]> | 2014-04-12 16:30:45 +0900 |
| commit | 1ef77ab3ff655dc5557064a7d63909a4acdcac9c (patch) | |
| tree | 3cb8c36f729ccd293ae92415b2df632ac6da5683 /src/numeric.c | |
| parent | 8321ad3f56d206ba53ac59281ac94c28ba3fce0a (diff) | |
| download | mruby-1ef77ab3ff655dc5557064a7d63909a4acdcac9c.tar.gz mruby-1ef77ab3ff655dc5557064a7d63909a4acdcac9c.zip | |
simplify Numeric#eql?
Diffstat (limited to 'src/numeric.c')
| -rw-r--r-- | src/numeric.c | 24 |
1 files changed, 14 insertions, 10 deletions
diff --git a/src/numeric.c b/src/numeric.c index 091162197..7c30449fb 100644 --- a/src/numeric.c +++ b/src/numeric.c @@ -361,20 +361,23 @@ flo_mod(mrb_state *mrb, mrb_value x) * (1.0).eql?(1.0) #=> true */ static mrb_value -num_eql(mrb_state *mrb, mrb_value x) +fix_eql(mrb_state *mrb, mrb_value x) { mrb_value y; - mrb_bool eql_p; mrb_get_args(mrb, "o", &y); - if (mrb_type(x) != mrb_type(y)) { - eql_p = 0; - } - else { - eql_p = mrb_equal(mrb, x, y); - } + if (!mrb_fixnum_p(y)) return mrb_false_value(); + return mrb_bool_value(mrb_fixnum(x) == mrb_fixnum(y)); +} - return mrb_bool_value(eql_p); +static mrb_value +flo_eql(mrb_state *mrb, mrb_value x) +{ + mrb_value y; + + mrb_get_args(mrb, "o", &y); + if (!mrb_float_p(y)) return mrb_false_value(); + return mrb_bool_value(mrb_float(x) == (mrb_float)mrb_fixnum(y)); } /* 15.2.9.3.7 */ @@ -1355,7 +1358,7 @@ mrb_init_numeric(mrb_state *mrb) mrb_define_method(mrb, fixnum, "^", fix_xor, MRB_ARGS_REQ(1)); /* 15.2.8.3.11 */ mrb_define_method(mrb, fixnum, "<<", fix_lshift, MRB_ARGS_REQ(1)); /* 15.2.8.3.12 */ mrb_define_method(mrb, fixnum, ">>", fix_rshift, MRB_ARGS_REQ(1)); /* 15.2.8.3.13 */ - mrb_define_method(mrb, fixnum, "eql?", num_eql, MRB_ARGS_REQ(1)); /* 15.2.8.3.16 */ + mrb_define_method(mrb, fixnum, "eql?", fix_eql, MRB_ARGS_REQ(1)); /* 15.2.8.3.16 */ mrb_define_method(mrb, fixnum, "hash", flo_hash, MRB_ARGS_NONE()); /* 15.2.8.3.18 */ mrb_define_method(mrb, fixnum, "to_f", fix_to_f, MRB_ARGS_NONE()); /* 15.2.8.3.23 */ mrb_define_method(mrb, fixnum, "to_s", fix_to_s, MRB_ARGS_NONE()); /* 15.2.8.3.25 */ @@ -1380,6 +1383,7 @@ mrb_init_numeric(mrb_state *mrb) mrb_define_method(mrb, fl, "to_int", flo_truncate, MRB_ARGS_NONE()); mrb_define_method(mrb, fl, "truncate", flo_truncate, MRB_ARGS_NONE()); /* 15.2.9.3.15 */ mrb_define_method(mrb, fl, "divmod", flo_divmod, MRB_ARGS_REQ(1)); + mrb_define_method(mrb, fl, "eql?", flo_eql, MRB_ARGS_REQ(1)); /* 15.2.8.3.16 */ mrb_define_method(mrb, fl, "to_s", flo_to_s, MRB_ARGS_NONE()); /* 15.2.9.3.16(x) */ mrb_define_method(mrb, fl, "inspect", flo_to_s, MRB_ARGS_NONE()); |