diff options
| author | Yukihiro "Matz" Matsumoto <[email protected]> | 2018-02-12 09:32:35 +0900 |
|---|---|---|
| committer | GitHub <[email protected]> | 2018-02-12 09:32:35 +0900 |
| commit | 2c84d948543d4321f9bfe5b0208ee05a42ef7954 (patch) | |
| tree | 602ebf3fa9d2e66328e78d13ab05207a76aa6e77 /tasks/toolchains/visualcpp.rake | |
| parent | 4790f28d6248fd6884783cc33995fa36c270cb0a (diff) | |
| parent | a9d0d90f7417007db510b77caa6098ebcb6d5b7a (diff) | |
| download | mruby-2c84d948543d4321f9bfe5b0208ee05a42ef7954.tar.gz mruby-2c84d948543d4321f9bfe5b0208ee05a42ef7954.zip | |
Merge pull request #3915 from llothar/master
Uncommented the Visual Studio version check
Diffstat (limited to 'tasks/toolchains/visualcpp.rake')
| -rw-r--r-- | tasks/toolchains/visualcpp.rake | 19 |
1 files changed, 10 insertions, 9 deletions
diff --git a/tasks/toolchains/visualcpp.rake b/tasks/toolchains/visualcpp.rake index 5bc24a73a..b008273a2 100644 --- a/tasks/toolchains/visualcpp.rake +++ b/tasks/toolchains/visualcpp.rake @@ -55,14 +55,15 @@ MRuby::Toolchain.new(:visualcpp) do |conf, _params| conf.file_separator = '\\' - if require 'open3' - Open3.popen3 conf.cc.command do |_, _, e, _| - if /Version (\d{2})\.\d{2}\.\d{5}/ =~ e.gets && $1.to_i <= 17 - m = "# VS2010/2012 support will be dropped after the next release! #" - h = "#" * m.length - puts h, m, h - end - end - end + # Unreliable detection and will result in invalid encoding errors for localized versions of Visual C++ + # if require 'open3' + # Open3.popen3 conf.cc.command do |_, _, e, _| + # if /Version (\d{2})\.\d{2}\.\d{5}/ =~ e.gets && $1.to_i <= 17 + # m = "# VS2010/2012 support will be dropped after the next release! #" + # h = "#" * m.length + # puts h, m, h + # end + # end + # end end |