From 1cc44cfd78e00879e983ffa320e16a2d99558067 Mon Sep 17 00:00:00 2001 From: skandhas Date: Fri, 9 Nov 2012 23:00:24 +0800 Subject: add Module#class_variables --- include/mruby/variable.h | 1 + src/class.c | 1 + src/variable.c | 44 ++++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 46 insertions(+) diff --git a/include/mruby/variable.h b/include/mruby/variable.h index e805b4b2b..5126315c4 100644 --- a/include/mruby/variable.h +++ b/include/mruby/variable.h @@ -53,6 +53,7 @@ void mrb_gv_set(mrb_state *mrb, mrb_sym sym, mrb_value val); mrb_value mrb_obj_instance_variables(mrb_state*, mrb_value); mrb_value mrb_obj_iv_inspect(mrb_state*, struct RObject*); mrb_sym mrb_class_sym(mrb_state *mrb, struct RClass *c, struct RClass *outer); +mrb_value mrb_mod_class_variables(mrb_state*, mrb_value); /* GC functions */ void mrb_gc_mark_gv(mrb_state*); diff --git a/src/class.c b/src/class.c index cf2f6df50..4df422e26 100644 --- a/src/class.c +++ b/src/class.c @@ -1440,6 +1440,7 @@ mrb_init_class(mrb_state *mrb) mrb_define_method(mrb, mod, "const_get", mrb_mod_const_get, ARGS_REQ(1)); /* 15.2.2.4.21 */ mrb_define_method(mrb, mod, "const_set", mrb_mod_const_set, ARGS_REQ(2)); /* 15.2.2.4.23 */ mrb_define_method(mrb, mod, "define_method", mod_define_method, ARGS_REQ(1)); + mrb_define_method(mrb, mod, "class_variables", mrb_mod_class_variables, ARGS_ANY()); /* 15.2.2.4.19 */ mrb_define_method(mrb, mod, "===", mrb_mod_eqq, ARGS_REQ(1)); mrb_undef_method(mrb, cls, "append_features"); diff --git a/src/variable.c b/src/variable.c index b3b3b3d87..19853685c 100644 --- a/src/variable.c +++ b/src/variable.c @@ -615,6 +615,50 @@ mrb_obj_instance_variables(mrb_state *mrb, mrb_value self) return ary; } +static int +cv_i(mrb_state *mrb, mrb_sym sym, mrb_value v, void *p) +{ + mrb_value ary; + const char* s; + int len; + + ary = *(mrb_value*)p; + s = mrb_sym2name_len(mrb, sym, &len); + if (len > 2 && s[0] == '@' && s[1] == '@') { + mrb_ary_push(mrb, ary, mrb_symbol_value(sym)); + } + return 0; +} + +/* 15.2.2.4.19 */ +/* + * call-seq: + * mod.class_variables -> array + * + * Returns an array of the names of class variables in mod. + * + * class One + * @@var1 = 1 + * end + * class Two < One + * @@var2 = 2 + * end + * One.class_variables #=> [:@@var1] + * Two.class_variables #=> [:@@var2] + */ +mrb_value +mrb_mod_class_variables(mrb_state *mrb, mrb_value mod) +{ + mrb_value ary; + + ary = mrb_ary_new(mrb); + if (obj_iv_p(mod) && mrb_obj_ptr(mod)->iv) { + iv_foreach(mrb, mrb_obj_ptr(mod)->iv, cv_i, &ary); + } + return ary; +} + + mrb_value mrb_vm_cv_get(mrb_state *mrb, mrb_sym sym) { -- cgit v1.2.3 From 9dbbd02ac5e57a2b135642784f75665f8afe229b Mon Sep 17 00:00:00 2001 From: skandhas Date: Fri, 9 Nov 2012 23:10:28 +0800 Subject: add Module#class_variables test --- test/t/module.rb | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/test/t/module.rb b/test/t/module.rb index 1827d5758..bec1d7b45 100644 --- a/test/t/module.rb +++ b/test/t/module.rb @@ -31,6 +31,18 @@ assert('Module#append_features', '15.2.2.4.10') do Test4AppendFeatures2.const_get(:Const4AppendFeatures2) == Test4AppendFeatures2 end +assert('Module#class_variables', '15.2.2.4.19') do + class Test4ClassVariables1 + @@var1 = 1 + @@var2 = 2 + end + class Test4ClassVariables2 + @@var3 =2 + end + Test4ClassVariables1.class_variables == [:@@var1, :@@var2] && + Test4ClassVariables2.class_variables == [:@@var3] +end + assert('Module#const_defined?', '15.2.2.4.20') do module Test4ConstDefined Const4Test4ConstDefined = true -- cgit v1.2.3 From 38ce9516aa4611110b3084699db6c18cf7e99ad9 Mon Sep 17 00:00:00 2001 From: skandhas Date: Mon, 12 Nov 2012 20:18:40 +0800 Subject: modify Module#class_variables test --- test/t/module.rb | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/test/t/module.rb b/test/t/module.rb index bec1d7b45..ff8178cb0 100644 --- a/test/t/module.rb +++ b/test/t/module.rb @@ -36,9 +36,10 @@ assert('Module#class_variables', '15.2.2.4.19') do @@var1 = 1 @@var2 = 2 end - class Test4ClassVariables2 - @@var3 =2 + class Test4ClassVariables2 < Test4ClassVariables1 + @@var3 = 2 end + Test4ClassVariables1.class_variables == [:@@var1, :@@var2] && Test4ClassVariables2.class_variables == [:@@var3] end -- cgit v1.2.3 From 611cfee3c2ff1a06760cbe4d0d1415f65087b505 Mon Sep 17 00:00:00 2001 From: skandhas Date: Mon, 12 Nov 2012 20:43:10 +0800 Subject: modify aspec --- src/class.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/class.c b/src/class.c index 4df422e26..e737a1201 100644 --- a/src/class.c +++ b/src/class.c @@ -1440,7 +1440,7 @@ mrb_init_class(mrb_state *mrb) mrb_define_method(mrb, mod, "const_get", mrb_mod_const_get, ARGS_REQ(1)); /* 15.2.2.4.21 */ mrb_define_method(mrb, mod, "const_set", mrb_mod_const_set, ARGS_REQ(2)); /* 15.2.2.4.23 */ mrb_define_method(mrb, mod, "define_method", mod_define_method, ARGS_REQ(1)); - mrb_define_method(mrb, mod, "class_variables", mrb_mod_class_variables, ARGS_ANY()); /* 15.2.2.4.19 */ + mrb_define_method(mrb, mod, "class_variables", mrb_mod_class_variables, ARGS_NONE()); /* 15.2.2.4.19 */ mrb_define_method(mrb, mod, "===", mrb_mod_eqq, ARGS_REQ(1)); mrb_undef_method(mrb, cls, "append_features"); -- cgit v1.2.3