From 7aabc657f1c8ef7e8f433e5fc584c5592f8a16d4 Mon Sep 17 00:00:00 2001 From: "Yukihiro \"Matz\" Matsumoto" Date: Sat, 9 Nov 2013 04:08:24 +0900 Subject: protect returning irep (in proc) from GC --- src/codegen.c | 1 + src/load.c | 10 ++++++++-- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/src/codegen.c b/src/codegen.c index 0e9ad0ebb..bb8cece7d 100644 --- a/src/codegen.c +++ b/src/codegen.c @@ -2906,6 +2906,7 @@ mrb_generate_code(mrb_state *mrb, parser_state *p) // prepare irep codegen(scope, p->tree, NOVAL); proc = mrb_proc_new(mrb, scope->irep); + mrb_irep_decref(mrb, scope->irep); mrb_pool_close(scope->mpool); return proc; } diff --git a/src/load.c b/src/load.c index 2b222b6c1..b6e2df47a 100644 --- a/src/load.c +++ b/src/load.c @@ -462,12 +462,15 @@ mrb_value mrb_load_irep(mrb_state *mrb, const uint8_t *bin) { mrb_irep *irep = mrb_read_irep(mrb, bin); + mrb_value val; if (!irep) { irep_error(mrb); return mrb_nil_value(); } - return mrb_context_run(mrb, mrb_proc_new(mrb, irep), mrb_top_self(mrb), 0); + val = mrb_context_run(mrb, mrb_proc_new(mrb, irep), mrb_top_self(mrb), 0); + mrb_irep_decref(mrb, irep); + return val; } #ifdef ENABLE_STDIO @@ -694,11 +697,14 @@ mrb_value mrb_load_irep_file(mrb_state *mrb, FILE* fp) { mrb_irep *irep = mrb_read_irep_file(mrb, fp); + mrb_value val; if (!irep) { irep_error(mrb); return mrb_nil_value(); } - return mrb_context_run(mrb, mrb_proc_new(mrb, irep), mrb_top_self(mrb), 0); + val = mrb_context_run(mrb, mrb_proc_new(mrb, irep), mrb_top_self(mrb), 0); + mrb_irep_decref(mrb, irep); + return val; } #endif /* ENABLE_STDIO */ -- cgit v1.2.3