From 5e4626c9ba43027ba7bc6d6f6bbee7016512d0e6 Mon Sep 17 00:00:00 2001 From: ksss Date: Sun, 23 Mar 2014 00:38:35 +0900 Subject: Hash#{select,select!} support return Enumerator if non block given --- mrblib/hash.rb | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/mrblib/hash.rb b/mrblib/hash.rb index cd6ba8935..9dcfb7e94 100644 --- a/mrblib/hash.rb +++ b/mrblib/hash.rb @@ -162,6 +162,8 @@ class Hash # 1.9 Hash#select! returns Hash; ISO says nothing. def select!(&b) + return to_enum :select! unless block_given? + keys = [] self.each_key{|k| v = self[k] @@ -178,6 +180,8 @@ class Hash # 1.9 Hash#select returns Hash; ISO says nothing. def select(&b) + return to_enum :select unless block_given? + h = {} self.each_key{|k| v = self[k] -- cgit v1.2.3 From d09e4475bf3272d594e88b41ad1265da2c5517ec Mon Sep 17 00:00:00 2001 From: ksss Date: Sun, 23 Mar 2014 09:48:51 +0900 Subject: Hash#{select,select!} fix yield value --- mrbgems/mruby-enumerator/test/enumerator.rb | 14 ++++++++++++++ mrblib/hash.rb | 4 ++-- 2 files changed, 16 insertions(+), 2 deletions(-) diff --git a/mrbgems/mruby-enumerator/test/enumerator.rb b/mrbgems/mruby-enumerator/test/enumerator.rb index fdee06450..6c224eaa3 100644 --- a/mrbgems/mruby-enumerator/test/enumerator.rb +++ b/mrbgems/mruby-enumerator/test/enumerator.rb @@ -494,6 +494,20 @@ assert 'Hash#each_value' do assert_equal [1,2], {a:1,b:2}.each_value.to_a.sort end +assert 'Hash#select' do + h = {1=>2,3=>4,5=>6} + hret = h.select.with_index {|a,b| a[1] == 4} + assert_equal({3=>4}, hret) + assert_equal({1=>2,3=>4,5=>6}, h) +end + +assert 'Hash#select!' do + h = {1=>2,3=>4,5=>6} + hret = h.select!.with_index {|a,b| a[1] == 4} + assert_equal h, hret + assert_equal({3=>4}, h) +end + assert 'Range#each' do a = (1..5) b = a.each diff --git a/mrblib/hash.rb b/mrblib/hash.rb index 9dcfb7e94..491d2a0ee 100644 --- a/mrblib/hash.rb +++ b/mrblib/hash.rb @@ -167,7 +167,7 @@ class Hash keys = [] self.each_key{|k| v = self[k] - unless b.call(k, v) + unless b.call([k, v]) keys.push(k) end } @@ -185,7 +185,7 @@ class Hash h = {} self.each_key{|k| v = self[k] - if b.call(k, v) + if b.call([k, v]) h[k] = v end } -- cgit v1.2.3