From d55a74c4187837347f8edbdd034e28cfee1e9a15 Mon Sep 17 00:00:00 2001 From: John Bampton Date: Sat, 13 Feb 2021 16:23:00 +1000 Subject: feat(CI): check for trailing whitespace Run on pull request only. Use a shell script to check for trailing whitespace in all files. Fail if trailing whitespace is found. --- .github/workflows/lint.yml | 9 +++++++++ mrbgems/mruby-hash-ext/src/hash-ext.c | 2 +- test/check-for-trailing-whitespace.sh | 13 +++++++++++++ 3 files changed, 23 insertions(+), 1 deletion(-) create mode 100755 test/check-for-trailing-whitespace.sh diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index b2ba316b2..48af6619f 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -31,3 +31,12 @@ jobs: node-version: '12.x' - run: npm install -g markdownlint-cli@0.25.0 - run: markdownlint '**/*.md' + trailing-whitespace: + name: ๐ŸŒŒ Trailing whitespace + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v2 + - name: ๐Ÿงน Check for trailing whitespace + run: | + cd test || exit + sh ./check-for-trailing-whitespace.sh || exit 1 diff --git a/mrbgems/mruby-hash-ext/src/hash-ext.c b/mrbgems/mruby-hash-ext/src/hash-ext.c index 6345420ed..9c85858fe 100644 --- a/mrbgems/mruby-hash-ext/src/hash-ext.c +++ b/mrbgems/mruby-hash-ext/src/hash-ext.c @@ -74,7 +74,7 @@ hash_slice(mrb_state *mrb, mrb_value hash) * hsh.except(*keys) -> a_hash * * Returns a hash excluding the given keys and their values. - * + * * h = { a: 100, b: 200, c: 300 } * h.except(:a) #=> {:b=>200, :c=>300} * h.except(:b, :c, :d) #=> {:a=>100} diff --git a/test/check-for-trailing-whitespace.sh b/test/check-for-trailing-whitespace.sh new file mode 100755 index 000000000..00be038f3 --- /dev/null +++ b/test/check-for-trailing-whitespace.sh @@ -0,0 +1,13 @@ +#!/usr/bin/env bash + +cd .. || exit +# print first +grep -EHInr '( +)$' ./* + +var=$(grep -EHInr '( +)$' ./*) +# then exit with fail if found +if test -z "$var"; then + exit 0 +else + exit 1 +fi -- cgit v1.2.3