From 776a680e89701e2d1ea5c6ff3e952fc4b8e72cba Mon Sep 17 00:00:00 2001 From: Jun Hiroe Date: Sun, 23 Mar 2014 11:41:23 +0900 Subject: Enumerable#minmax_by --- mrbgems/mruby-enum-ext/mrblib/enum.rb | 39 +++++++++++++++++++++++++++++++++++ mrbgems/mruby-enum-ext/test/enum.rb | 4 ++++ 2 files changed, 43 insertions(+) diff --git a/mrbgems/mruby-enum-ext/mrblib/enum.rb b/mrbgems/mruby-enum-ext/mrblib/enum.rb index 873de1fbc..4b0b87bcc 100644 --- a/mrbgems/mruby-enum-ext/mrblib/enum.rb +++ b/mrbgems/mruby-enum-ext/mrblib/enum.rb @@ -374,4 +374,43 @@ module Enumerable end [min, max] end + + ## + # call-seq: + # enum.minmax_by { |obj| block } -> [min, max] + # enum.minmax_by -> an_enumerator + # + # Returns a two element array containing the objects in + # enum that correspond to the minimum and maximum values respectively + # from the given block. + # + # If no block is given, an enumerator is returned instead. + # + # %w(albatross dog horse).minmax_by { |x| x.length } #=> ["dog", "albatross"] + + def minmax_by(&block) + max = nil + max_cmp = nil + min = nil + min_cmp = nil + first = true + + self.each do |val| + if first + max = min = val + max_cmp = min_cmp = block.call(val) + first = false + else + if (cmp = block.call(val)) > max_cmp + max = val + max_cmp = cmp + end + if (cmp = block.call(val)) < min_cmp + min = val + min_cmp = cmp + end + end + end + [min, max] + end end diff --git a/mrbgems/mruby-enum-ext/test/enum.rb b/mrbgems/mruby-enum-ext/test/enum.rb index 2f7ed7aaa..4dfa2fec0 100644 --- a/mrbgems/mruby-enum-ext/test/enum.rb +++ b/mrbgems/mruby-enum-ext/test/enum.rb @@ -90,3 +90,7 @@ assert("Enumerable#minmax") do assert_equal ["albatross", "horse"], a.minmax assert_equal ["dog", "albatross"], a.minmax { |a, b| a.length <=> b.length } end + +assert("Enumerable#minmax_by") do + assert_equal ["dog", "albatross"], %w(albatross dog horse).minmax_by { |x| x.length } +end -- cgit v1.2.3 From 5b31ee9a2ab463561ee8793ab6387d2ca2c6e21f Mon Sep 17 00:00:00 2001 From: Jun Hiroe Date: Sun, 23 Mar 2014 11:48:46 +0900 Subject: Suppoert multiple values in Enumerable#minmax_by --- mrbgems/mruby-enum-ext/mrblib/enum.rb | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/mrbgems/mruby-enum-ext/mrblib/enum.rb b/mrbgems/mruby-enum-ext/mrblib/enum.rb index 4b0b87bcc..8a2cdd5f1 100644 --- a/mrbgems/mruby-enum-ext/mrblib/enum.rb +++ b/mrbgems/mruby-enum-ext/mrblib/enum.rb @@ -395,18 +395,18 @@ module Enumerable min_cmp = nil first = true - self.each do |val| + self.each do |*val| if first - max = min = val - max_cmp = min_cmp = block.call(val) + max = min = val.__svalue + max_cmp = min_cmp = block.call(*val) first = false else - if (cmp = block.call(val)) > max_cmp - max = val + if (cmp = block.call(*val)) > max_cmp + max = val.__svalue max_cmp = cmp end - if (cmp = block.call(val)) < min_cmp - min = val + if (cmp = block.call(*val)) < min_cmp + min = val.__svalue min_cmp = cmp end end -- cgit v1.2.3