From 68027317b0401f621de9d89676160522b3238b07 Mon Sep 17 00:00:00 2001 From: "Yukihiro \"Matz\" Matsumoto" Date: Wed, 23 Apr 2014 00:25:50 +0900 Subject: Array#insert: simpler (and faster) implementation; ref #2107 --- mrbgems/mruby-array-ext/mrblib/array.rb | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-) (limited to 'mrbgems/mruby-array-ext/mrblib/array.rb') diff --git a/mrbgems/mruby-array-ext/mrblib/array.rb b/mrbgems/mruby-array-ext/mrblib/array.rb index df7635e8f..49d0db0d5 100644 --- a/mrbgems/mruby-array-ext/mrblib/array.rb +++ b/mrbgems/mruby-array-ext/mrblib/array.rb @@ -504,17 +504,9 @@ class Array # a.insert(2, 99) #=> ["a", "b", 99, "c", "d"] # a.insert(-2, 1, 2, 3) #=> ["a", "b", 99, "c", 1, 2, 3, "d"] - def insert(idx, *obj) + def insert(idx, *args) idx += self.size + 1 if idx < 0 - ary = [] - before_ary = self[0, idx] - after_ary = self[idx, self.size] - before_ary.each {|val| ary << val} unless before_ary == nil - while ary.size < idx - ary << nil - end - obj.each {|val| ary << val} unless obj == nil - after_ary.each {|val| ary << val} unless after_ary == nil - self.replace(ary) + self[idx, 0] = args + self end end -- cgit v1.2.3