From b083c1351f98206aa048d0dea83b83304a1adcc4 Mon Sep 17 00:00:00 2001 From: "Yukihiro \"Matz\" Matsumoto" Date: Tue, 7 Aug 2018 23:01:22 +0900 Subject: Fixed the corner case bug in `String#{gsub!,sub!}`. `"a".sub!("a", "a")` should not return `nil`. --- mrblib/string.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'mrblib') diff --git a/mrblib/string.rb b/mrblib/string.rb index ee98cfa0c..07b80b340 100644 --- a/mrblib/string.rb +++ b/mrblib/string.rb @@ -99,7 +99,7 @@ class String raise FrozenError, "can't modify frozen String" if frozen? return to_enum(:gsub!, *args) if args.length == 1 && !block str = self.gsub(*args, &block) - return nil if str == self + return nil unless self.index(args[0]) self.replace(str) end @@ -161,7 +161,7 @@ class String def sub!(*args, &block) raise FrozenError, "can't modify frozen String" if frozen? str = self.sub(*args, &block) - return nil if str == self + return nil unless self.index(args[0]) self.replace(str) end -- cgit v1.2.3 From b3a1d379268b3019b0f45eac8d5f10704ac99fc5 Mon Sep 17 00:00:00 2001 From: "Yukihiro \"Matz\" Matsumoto" Date: Mon, 13 Aug 2018 15:07:10 +0900 Subject: Make `Array.new` to accept both integers and floats. This time we used `Integral` module which is mruby specific. --- mrblib/array.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'mrblib') diff --git a/mrblib/array.rb b/mrblib/array.rb index 334f4e984..13c5d646c 100644 --- a/mrblib/array.rb +++ b/mrblib/array.rb @@ -66,7 +66,7 @@ class Array # # ISO 15.2.12.5.15 def initialize(size=0, obj=nil, &block) - raise TypeError, "expected Integer for 1st argument" unless size.kind_of? Integer + raise TypeError, "expected Integer for 1st argument" unless size.kind_of? Integral raise ArgumentError, "negative array size" if size < 0 self.clear -- cgit v1.2.3 From a3fb80904dcbbf2aaec0df202e343b10f0518d1c Mon Sep 17 00:00:00 2001 From: "Yukihiro \"Matz\" Matsumoto" Date: Sat, 25 Aug 2018 09:08:49 +0900 Subject: Remove unused `Hash#__update` method. --- mrblib/hash.rb | 5 ----- 1 file changed, 5 deletions(-) (limited to 'mrblib') diff --git a/mrblib/hash.rb b/mrblib/hash.rb index 7e1db905f..96029a230 100644 --- a/mrblib/hash.rb +++ b/mrblib/hash.rb @@ -341,11 +341,6 @@ class Hash } self.replace(h) end - - def __update(h) - h.each_key{|k| self[k] = h[k]} - self - end end ## -- cgit v1.2.3