From 85a400e43d6b5c7ea193c65c70cdcd611869298b Mon Sep 17 00:00:00 2001 From: "Yukihiro \"Matz\" Matsumoto" Date: Fri, 25 Aug 2017 16:05:23 +0900 Subject: Reimplement `Array#shift` to be faster. --- src/array.c | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) (limited to 'src/array.c') diff --git a/src/array.c b/src/array.c index 3ccdd3262..8f33defe6 100644 --- a/src/array.c +++ b/src/array.c @@ -464,12 +464,20 @@ static mrb_value mrb_ary_push_m(mrb_state *mrb, mrb_value self) { mrb_value *argv; - mrb_int len; + mrb_int len, len2, alen; + struct RArray *a; - mrb_get_args(mrb, "*!", &argv, &len); - while (len--) { - mrb_ary_push(mrb, self, *argv++); + mrb_get_args(mrb, "*!", &argv, &alen); + a = mrb_ary_ptr(self); + ary_modify(mrb, a); + len = ARY_LEN(a); + len2 = len + alen; + if (ARY_CAPA(a) < len2) { + ary_expand_capa(mrb, a, len2); } + array_copy(ARY_PTR(a)+len, argv, alen); + ARY_SET_LEN(a, len2); + mrb_write_barrier(mrb, (struct RBasic*)a); return self; } -- cgit v1.2.3