From 8d95e5a0de77afc36f3b6fca6eb4744810e71b7e Mon Sep 17 00:00:00 2001 From: "Yukihiro \"Matz\" Matsumoto" Date: Sun, 13 Apr 2014 18:26:13 +0900 Subject: use kh_put2 in mrb_hash_set for performance improvement --- src/hash.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) (limited to 'src/hash.c') diff --git a/src/hash.c b/src/hash.c index 0090dc5dd..985d5259a 100644 --- a/src/hash.c +++ b/src/hash.c @@ -204,21 +204,23 @@ mrb_hash_set(mrb_state *mrb, mrb_value hash, mrb_value key, mrb_value val) { khash_t(ht) *h; khiter_t k; + int r; mrb_hash_modify(mrb, hash); h = RHASH_TBL(hash); if (!h) h = RHASH_TBL(hash) = kh_init(ht, mrb); - k = kh_get(ht, mrb, h, key); - if (k == kh_end(h)) { + k = kh_put2(ht, mrb, h, key, &r); + kh_value(h, k).v = val; + + if (r != 0) { /* expand */ int ai = mrb_gc_arena_save(mrb); - k = kh_put(ht, mrb, h, KEY(key)); + kh_key(h, k) = KEY(key); mrb_gc_arena_restore(mrb, ai); kh_value(h, k).n = kh_size(h)-1; } - kh_value(h, k).v = val; mrb_write_barrier(mrb, (struct RBasic*)RHASH(hash)); return; } -- cgit v1.2.3