From 7a840e321aa709bfe3dacb757dce239034ce73aa Mon Sep 17 00:00:00 2001 From: Masaki Muranaka Date: Tue, 19 Mar 2013 10:36:17 +0900 Subject: Use mrb_true_or_false_value() / in mrb_obj_equal_m(). --- src/kernel.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) (limited to 'src/kernel.c') diff --git a/src/kernel.c b/src/kernel.c index 973339c95..6db8750b1 100644 --- a/src/kernel.c +++ b/src/kernel.c @@ -96,14 +96,12 @@ static mrb_value mrb_obj_equal_m(mrb_state *mrb, mrb_value self) { mrb_value arg; + mrb_bool eql_p; mrb_get_args(mrb, "o", &arg); - if (mrb_obj_equal(mrb, self, arg)) { - return mrb_true_value(); - } - else { - return mrb_false_value(); - } + eql_p = mrb_obj_equal(mrb, self, arg); + + return mrb_true_or_false_value(eql_p); } static mrb_value -- cgit v1.2.3 From 713c4f9c7572d0b8a69a495b17527168c44d027b Mon Sep 17 00:00:00 2001 From: Masaki Muranaka Date: Tue, 19 Mar 2013 10:36:32 +0900 Subject: Use mrb_true_or_false_value() / in mrb_obj_not_equal_m(). --- src/kernel.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) (limited to 'src/kernel.c') diff --git a/src/kernel.c b/src/kernel.c index 6db8750b1..5d431268e 100644 --- a/src/kernel.c +++ b/src/kernel.c @@ -108,14 +108,12 @@ static mrb_value mrb_obj_not_equal_m(mrb_state *mrb, mrb_value self) { mrb_value arg; + mrb_bool eql_p; mrb_get_args(mrb, "o", &arg); - if (mrb_equal(mrb, self, arg)) { - return mrb_false_value(); - } - else { - return mrb_true_value(); - } + eql_p = mrb_obj_equal(mrb, self, arg); + + return mrb_true_or_false_value(!eql_p); } /* 15.3.1.3.2 */ -- cgit v1.2.3 From 70baae2573f52024e54e460203e5a3d6c28ba963 Mon Sep 17 00:00:00 2001 From: Masaki Muranaka Date: Tue, 19 Mar 2013 10:36:53 +0900 Subject: Use mrb_true_or_false_value() / in mrb_equal_m(). --- src/kernel.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) (limited to 'src/kernel.c') diff --git a/src/kernel.c b/src/kernel.c index 5d431268e..78e5dc1d5 100644 --- a/src/kernel.c +++ b/src/kernel.c @@ -129,14 +129,12 @@ static mrb_value mrb_equal_m(mrb_state *mrb, mrb_value self) { mrb_value arg; + mrb_bool equal_p; mrb_get_args(mrb, "o", &arg); - if (mrb_equal(mrb, self, arg)){ - return mrb_true_value(); - } - else { - return mrb_false_value(); - } + equal_p = mrb_equal(mrb, self, arg); + + return mrb_true_or_false_value(equal_p); } /* 15.3.1.3.3 */ -- cgit v1.2.3 From 57e345c7674e726bb1876865e74b756c5c325439 Mon Sep 17 00:00:00 2001 From: Masaki Muranaka Date: Tue, 19 Mar 2013 10:37:21 +0900 Subject: Use mrb_true_or_false_value() / in mrb_f_block_given_p_m(). --- src/kernel.c | 27 +++++++++++++++++---------- 1 file changed, 17 insertions(+), 10 deletions(-) (limited to 'src/kernel.c') diff --git a/src/kernel.c b/src/kernel.c index 78e5dc1d5..0b8930653 100644 --- a/src/kernel.c +++ b/src/kernel.c @@ -219,21 +219,28 @@ mrb_f_block_given_p_m(mrb_state *mrb, mrb_value self) { mrb_callinfo *ci = mrb->ci; mrb_value *bp; + mrb_bool given_p; bp = mrb->stbase + ci->stackidx + 1; ci--; - if (ci <= mrb->cibase) return mrb_false_value(); - /* block_given? called within block; check upper scope */ - if (ci->proc->env && ci->proc->env->stack) { - if (ci->proc->env->stack == mrb->stbase || mrb_nil_p(ci->proc->env->stack[1])) - return mrb_false_value(); - return mrb_true_value(); + if (ci <= mrb->cibase) { + given_p = 0; } - if (ci->argc > 0) { - bp += ci->argc; + else { + /* block_given? called within block; check upper scope */ + if (ci->proc->env && ci->proc->env->stack) { + given_p = !(ci->proc->env->stack == mrb->stbase || + mrb_nil_p(ci->proc->env->stack[1])); + } + else { + if (ci->argc > 0) { + bp += ci->argc; + } + given_p = !mrb_nil_p(*bp); + } } - if (mrb_nil_p(*bp)) return mrb_false_value(); - return mrb_true_value(); + + return mrb_true_or_false_value(given_p); } /* 15.3.1.3.7 */ -- cgit v1.2.3 From af1ead1ef965900dc5c5df1fefe3050a39584d1f Mon Sep 17 00:00:00 2001 From: Masaki Muranaka Date: Tue, 19 Mar 2013 10:37:49 +0900 Subject: Use mrb_true_or_false_value() / in obj_is_instance_of(). --- src/kernel.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) (limited to 'src/kernel.c') diff --git a/src/kernel.c b/src/kernel.c index 0b8930653..cc7ed9b8c 100644 --- a/src/kernel.c +++ b/src/kernel.c @@ -543,14 +543,12 @@ static mrb_value obj_is_instance_of(mrb_state *mrb, mrb_value self) { mrb_value arg; + mrb_bool instance_of_p; mrb_get_args(mrb, "o", &arg); - if (mrb_obj_is_instance_of(mrb, self, mrb_class_ptr(arg))){ - return mrb_true_value(); - } - else { - return mrb_false_value(); - } + instance_of_p = mrb_obj_is_instance_of(mrb, self, mrb_class_ptr(arg)); + + return mrb_true_or_false_value(instance_of_p); } static void -- cgit v1.2.3 From 739338b86f5bf0883f75f70769937836ac6d4aee Mon Sep 17 00:00:00 2001 From: Masaki Muranaka Date: Tue, 19 Mar 2013 10:38:08 +0900 Subject: Use mrb_true_or_false_value() / in mrb_obj_ivar_defined(). --- src/kernel.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) (limited to 'src/kernel.c') diff --git a/src/kernel.c b/src/kernel.c index cc7ed9b8c..e40c5882a 100644 --- a/src/kernel.c +++ b/src/kernel.c @@ -585,12 +585,13 @@ mrb_value mrb_obj_ivar_defined(mrb_state *mrb, mrb_value self) { mrb_sym mid; + mrb_bool defined_p; mrb_get_args(mrb, "n", &mid); check_iv_name(mrb, mid); - if (mrb_obj_iv_defined(mrb, mrb_obj_ptr(self), mid)) - return mrb_true_value(); - return mrb_false_value(); + defined_p = mrb_obj_iv_defined(mrb, mrb_obj_ptr(self), mid); + + return mrb_true_or_false_value(defined_p); } /* 15.3.1.3.21 */ -- cgit v1.2.3 From 447f110e86cef7612f329e25522b27c16a81e444 Mon Sep 17 00:00:00 2001 From: Masaki Muranaka Date: Tue, 19 Mar 2013 10:38:21 +0900 Subject: Use mrb_true_or_false_value() / in mrb_obj_is_kind_of_m(). --- src/kernel.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) (limited to 'src/kernel.c') diff --git a/src/kernel.c b/src/kernel.c index e40c5882a..9e0ed44e5 100644 --- a/src/kernel.c +++ b/src/kernel.c @@ -688,14 +688,12 @@ mrb_value mrb_obj_is_kind_of_m(mrb_state *mrb, mrb_value self) { mrb_value arg; + mrb_bool kind_of_p; mrb_get_args(mrb, "o", &arg); - if (mrb_obj_is_kind_of(mrb, self, mrb_class_ptr(arg))) { - return mrb_true_value(); - } - else { - return mrb_false_value(); - } + kind_of_p = mrb_obj_is_kind_of(mrb, self, mrb_class_ptr(arg)); + + return mrb_true_or_false_value(kind_of_p); } static void -- cgit v1.2.3 From 872536a800219037de651816620d67a4b9aba44b Mon Sep 17 00:00:00 2001 From: Masaki Muranaka Date: Tue, 19 Mar 2013 10:38:34 +0900 Subject: Use mrb_true_or_false_value() / in obj_respond_to(). --- src/kernel.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) (limited to 'src/kernel.c') diff --git a/src/kernel.c b/src/kernel.c index 9e0ed44e5..445a0b097 100644 --- a/src/kernel.c +++ b/src/kernel.c @@ -1000,15 +1000,17 @@ obj_respond_to(mrb_state *mrb, mrb_value self) int argc; mrb_value mid, priv; mrb_sym id; + mrb_bool respond_to_p; mrb_get_args(mrb, "*", &argv, &argc); mid = argv[0]; if (argc > 1) priv = argv[1]; else priv = mrb_nil_value(); id = mrb_to_id(mrb, mid); - if (basic_obj_respond_to(mrb, self, id, !mrb_test(priv))) - return mrb_true_value(); - return mrb_false_value(); + + respond_to_p = basic_obj_respond_to(mrb, self, id, !mrb_test(priv)); + + return mrb_true_or_false_value(respond_to_p); } /* 15.3.1.3.45 */ -- cgit v1.2.3