From be5e5fd75e9d4294e67987f4152c2551b1fa4b01 Mon Sep 17 00:00:00 2001 From: Masaki Muranaka Date: Tue, 19 Mar 2013 10:42:44 +0900 Subject: Use mrb_true_or_false_value() / in mrb_str_equal_m(). --- src/string.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) (limited to 'src/string.c') diff --git a/src/string.c b/src/string.c index 7fefbefb5..835e476b6 100644 --- a/src/string.c +++ b/src/string.c @@ -596,11 +596,12 @@ static mrb_value mrb_str_equal_m(mrb_state *mrb, mrb_value str1) { mrb_value str2; + mrb_bool equal_p; mrb_get_args(mrb, "o", &str2); - if (mrb_str_equal(mrb, str1, str2)) - return mrb_true_value(); - return mrb_false_value(); + equal_p = mrb_str_equal(mrb, str1, str2); + + return mrb_true_or_false_value(equal_p); } /* ---------------------------------- */ mrb_value -- cgit v1.2.3 From 055cad07391e353c6da3cced9da1684bcb7818f5 Mon Sep 17 00:00:00 2001 From: Masaki Muranaka Date: Tue, 19 Mar 2013 10:42:58 +0900 Subject: Use mrb_true_or_false_value() / in mrb_str_empty_p(). --- src/string.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) (limited to 'src/string.c') diff --git a/src/string.c b/src/string.c index 835e476b6..e93d2ce7f 100644 --- a/src/string.c +++ b/src/string.c @@ -1135,9 +1135,7 @@ mrb_str_empty_p(mrb_state *mrb, mrb_value self) { struct RString *s = mrb_str_ptr(self); - if (s->len == 0) - return mrb_true_value(); - return mrb_false_value(); + return mrb_true_or_false_value(s->len == 0); } /* 15.2.10.5.17 */ -- cgit v1.2.3 From 02a6334d0d074c242a8e5ec2307b01eee30d5ede Mon Sep 17 00:00:00 2001 From: Masaki Muranaka Date: Tue, 19 Mar 2013 10:43:32 +0900 Subject: Use mrb_true_or_false_value() / in mrb_str_eql(). --- src/string.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) (limited to 'src/string.c') diff --git a/src/string.c b/src/string.c index e93d2ce7f..f50725180 100644 --- a/src/string.c +++ b/src/string.c @@ -1149,13 +1149,12 @@ static mrb_value mrb_str_eql(mrb_state *mrb, mrb_value self) { mrb_value str2; + mrb_bool eql_p; mrb_get_args(mrb, "o", &str2); - if (mrb_type(str2) != MRB_TT_STRING) - return mrb_false_value(); - if (str_eql(mrb, self, str2)) - return mrb_true_value(); - return mrb_false_value(); + eql_p = (mrb_type(str2) == MRB_TT_STRING) && str_eql(mrb, self, str2); + + return mrb_true_or_false_value(eql_p); } static mrb_value -- cgit v1.2.3 From 68652da6f692f50073fdd9c3345d2fd29719b6e8 Mon Sep 17 00:00:00 2001 From: Masaki Muranaka Date: Tue, 19 Mar 2013 10:43:45 +0900 Subject: Use mrb_true_or_false_value() / in mrb_str_include(). --- src/string.c | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) (limited to 'src/string.c') diff --git a/src/string.c b/src/string.c index f50725180..41f2e5a06 100644 --- a/src/string.c +++ b/src/string.c @@ -1312,18 +1312,20 @@ mrb_str_include(mrb_state *mrb, mrb_value self) { mrb_int i; mrb_value str2; + mrb_bool include_p; mrb_get_args(mrb, "o", &str2); if (mrb_type(str2) == MRB_TT_FIXNUM) { - if (memchr(RSTRING_PTR(self), mrb_fixnum(str2), RSTRING_LEN(self))) - return mrb_true_value(); - return mrb_false_value(); + include_p = memchr(RSTRING_PTR(self), mrb_fixnum(str2), RSTRING_LEN(self)); + } + else { + mrb_string_value(mrb, &str2); + i = mrb_str_index(mrb, self, str2, 0); + + include_p = (i != -1); } - mrb_string_value(mrb, &str2); - i = mrb_str_index(mrb, self, str2, 0); - if (i == -1) return mrb_false_value(); - return mrb_true_value(); + return mrb_true_or_false_value(include_p); } /* 15.2.10.5.22 */ -- cgit v1.2.3