From 406fb9c80922e2355d0034b2fe9d9baecb61f41f Mon Sep 17 00:00:00 2001 From: cremno Date: Fri, 15 May 2015 22:41:46 +0200 Subject: let the C compiler validate the identifier MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Some C compilers may allow other characters in identifiers such as $. They may also implement C99's extended identifiers (\u30EB\u30D3\u30FC, ルビー). --- src/dump.c | 18 +----------------- 1 file changed, 1 insertion(+), 17 deletions(-) (limited to 'src') diff --git a/src/dump.c b/src/dump.c index 285aa08d9..1ab4c47c5 100644 --- a/src/dump.c +++ b/src/dump.c @@ -1019,22 +1019,6 @@ mrb_dump_irep_binary(mrb_state *mrb, mrb_irep *irep, uint8_t flags, FILE* fp) return result; } -static mrb_bool -is_valid_c_symbol_name(const char *name) -{ - const char *c = NULL; - - if (name == NULL || name[0] == '\0') return FALSE; - if (!ISALPHA(name[0]) && name[0] != '_') return FALSE; - - c = &name[1]; - for (; *c != '\0'; ++c) { - if (!ISALNUM(*c) && *c != '_') return FALSE; - } - - return TRUE; -} - static mrb_bool dump_bigendian_p(uint8_t flags) { @@ -1056,7 +1040,7 @@ mrb_dump_irep_cfunc(mrb_state *mrb, mrb_irep *irep, uint8_t flags, FILE *fp, con size_t bin_size = 0, bin_idx = 0; int result; - if (fp == NULL || initname == NULL || !is_valid_c_symbol_name(initname)) { + if (fp == NULL || initname == NULL || initname[0] == '\0') { return MRB_DUMP_INVALID_ARGUMENT; } flags = dump_flags(flags, FLAG_BYTEORDER_NATIVE); -- cgit v1.2.3