From f312638ecd0d9d884d0600c5ad44f4c00a6c313b Mon Sep 17 00:00:00 2001 From: dearblue Date: Sun, 15 Sep 2019 16:16:22 +0900 Subject: Cache argv first in each specifiers for `mrb_get_args()`; ref #3090 In terms of specifiers, argv is never referenced after a method call as shown in #3090. Reduction of object code can be expected. If you need to refer to argv after a method call in the same loop, update argv after the method call. --- src/class.c | 54 ++++++++++++++++++++++++++++-------------------------- 1 file changed, 28 insertions(+), 26 deletions(-) (limited to 'src') diff --git a/src/class.c b/src/class.c index d037a8abb..1ffec4407 100644 --- a/src/class.c +++ b/src/class.c @@ -619,6 +619,8 @@ mrb_get_args(mrb_state *mrb, const char *format, ...) opt = FALSE; i = 0; while ((c = *format++)) { + mrb_value *argv = ARGV; + switch (c) { case '|': case '*': case '&': case '?': break; @@ -641,7 +643,7 @@ mrb_get_args(mrb_state *mrb, const char *format, ...) p = va_arg(ap, mrb_value*); if (i < argc) { - *p = ARGV[arg_i++]; + *p = argv[arg_i++]; i++; } } @@ -654,7 +656,7 @@ mrb_get_args(mrb_state *mrb, const char *format, ...) if (i < argc) { mrb_value ss; - ss = ARGV[arg_i++]; + ss = argv[arg_i++]; if (!class_ptr_p(ss)) { mrb_raisef(mrb, E_TYPE_ERROR, "%v is not class/module", ss); } @@ -670,14 +672,14 @@ mrb_get_args(mrb_state *mrb, const char *format, ...) p = va_arg(ap, mrb_value*); if (*format == '!') { format++; - if (i < argc && mrb_nil_p(ARGV[arg_i])) { - *p = ARGV[arg_i++]; + if (i < argc && mrb_nil_p(argv[arg_i])) { + *p = argv[arg_i++]; i++; break; } } if (i < argc) { - *p = ARGV[arg_i++]; + *p = argv[arg_i++]; mrb_to_str(mrb, *p); i++; } @@ -690,14 +692,14 @@ mrb_get_args(mrb_state *mrb, const char *format, ...) p = va_arg(ap, mrb_value*); if (*format == '!') { format++; - if (i < argc && mrb_nil_p(ARGV[arg_i])) { - *p = ARGV[arg_i++]; + if (i < argc && mrb_nil_p(argv[arg_i])) { + *p = argv[arg_i++]; i++; break; } } if (i < argc) { - *p = to_ary(mrb, ARGV[arg_i++]); + *p = to_ary(mrb, argv[arg_i++]); i++; } } @@ -709,14 +711,14 @@ mrb_get_args(mrb_state *mrb, const char *format, ...) p = va_arg(ap, mrb_value*); if (*format == '!') { format++; - if (i < argc && mrb_nil_p(ARGV[arg_i])) { - *p = ARGV[arg_i++]; + if (i < argc && mrb_nil_p(argv[arg_i])) { + *p = argv[arg_i++]; i++; break; } } if (i < argc) { - *p = to_hash(mrb, ARGV[arg_i++]); + *p = to_hash(mrb, argv[arg_i++]); i++; } } @@ -731,7 +733,7 @@ mrb_get_args(mrb_state *mrb, const char *format, ...) pl = va_arg(ap, mrb_int*); if (*format == '!') { format++; - if (i < argc && mrb_nil_p(ARGV[arg_i])) { + if (i < argc && mrb_nil_p(argv[arg_i])) { *ps = NULL; *pl = 0; i++; arg_i++; @@ -739,7 +741,7 @@ mrb_get_args(mrb_state *mrb, const char *format, ...) } } if (i < argc) { - ss = ARGV[arg_i++]; + ss = argv[arg_i++]; mrb_to_str(mrb, ss); *ps = RSTRING_PTR(ss); *pl = RSTRING_LEN(ss); @@ -755,14 +757,14 @@ mrb_get_args(mrb_state *mrb, const char *format, ...) ps = va_arg(ap, const char**); if (*format == '!') { format++; - if (i < argc && mrb_nil_p(ARGV[arg_i])) { + if (i < argc && mrb_nil_p(argv[arg_i])) { *ps = NULL; i++; arg_i++; break; } } if (i < argc) { - ss = ARGV[arg_i++]; + ss = argv[arg_i++]; mrb_to_str(mrb, ss); *ps = RSTRING_CSTR(mrb, ss); i++; @@ -780,7 +782,7 @@ mrb_get_args(mrb_state *mrb, const char *format, ...) pl = va_arg(ap, mrb_int*); if (*format == '!') { format++; - if (i < argc && mrb_nil_p(ARGV[arg_i])) { + if (i < argc && mrb_nil_p(argv[arg_i])) { *pb = 0; *pl = 0; i++; arg_i++; @@ -788,7 +790,7 @@ mrb_get_args(mrb_state *mrb, const char *format, ...) } } if (i < argc) { - aa = to_ary(mrb, ARGV[arg_i++]); + aa = to_ary(mrb, argv[arg_i++]); a = mrb_ary_ptr(aa); *pb = ARY_PTR(a); *pl = ARY_LEN(a); @@ -803,7 +805,7 @@ mrb_get_args(mrb_state *mrb, const char *format, ...) p = va_arg(ap, void**); if (i < argc) { - ss = ARGV[arg_i]; + ss = argv[arg_i]; if (mrb_type(ss) != MRB_TT_ISTRUCT) { mrb_raisef(mrb, E_TYPE_ERROR, "%v is not inline struct", ss); @@ -821,7 +823,7 @@ mrb_get_args(mrb_state *mrb, const char *format, ...) p = va_arg(ap, mrb_float*); if (i < argc) { - *p = mrb_to_flo(mrb, ARGV[arg_i]); + *p = mrb_to_flo(mrb, argv[arg_i]); arg_i++; i++; } @@ -834,7 +836,7 @@ mrb_get_args(mrb_state *mrb, const char *format, ...) p = va_arg(ap, mrb_int*); if (i < argc) { - *p = mrb_fixnum(mrb_to_int(mrb, ARGV[arg_i])); + *p = mrb_fixnum(mrb_to_int(mrb, argv[arg_i])); arg_i++; i++; } @@ -845,7 +847,7 @@ mrb_get_args(mrb_state *mrb, const char *format, ...) mrb_bool *boolp = va_arg(ap, mrb_bool*); if (i < argc) { - mrb_value b = ARGV[arg_i++]; + mrb_value b = argv[arg_i++]; *boolp = mrb_test(b); i++; } @@ -859,7 +861,7 @@ mrb_get_args(mrb_state *mrb, const char *format, ...) if (i < argc) { mrb_value ss; - ss = ARGV[arg_i++]; + ss = argv[arg_i++]; *symp = to_sym(mrb, ss); i++; } @@ -874,14 +876,14 @@ mrb_get_args(mrb_state *mrb, const char *format, ...) type = va_arg(ap, struct mrb_data_type const*); if (*format == '!') { format++; - if (i < argc && mrb_nil_p(ARGV[arg_i])) { + if (i < argc && mrb_nil_p(argv[arg_i])) { *datap = 0; i++; arg_i++; break; } } if (i < argc) { - *datap = mrb_data_get_ptr(mrb, ARGV[arg_i++], type); + *datap = mrb_data_get_ptr(mrb, argv[arg_i++], type); ++i; } } @@ -936,10 +938,10 @@ mrb_get_args(mrb_state *mrb, const char *format, ...) *pl = argc-i; if (*pl > 0) { if (nocopy) { - *var = ARGV+arg_i; + *var = argv+arg_i; } else { - mrb_value args = mrb_ary_new_from_values(mrb, *pl, ARGV+arg_i); + mrb_value args = mrb_ary_new_from_values(mrb, *pl, argv+arg_i); RARRAY(args)->c = NULL; *var = RARRAY_PTR(args); } -- cgit v1.2.3 From 62499c62507033d37222e0492e2062a2ea781d56 Mon Sep 17 00:00:00 2001 From: dearblue Date: Sun, 15 Sep 2019 19:56:30 +0900 Subject: Shrink `mrb_get_args()` As a side effect, all specifiers now accept the `!` modifier. --- src/class.c | 136 +++++++++++++++++++++++++----------------------------------- 1 file changed, 56 insertions(+), 80 deletions(-) (limited to 'src') diff --git a/src/class.c b/src/class.c index 1ffec4407..82ad3cf0a 100644 --- a/src/class.c +++ b/src/class.c @@ -620,6 +620,7 @@ mrb_get_args(mrb_state *mrb, const char *format, ...) i = 0; while ((c = *format++)) { mrb_value *argv = ARGV; + mrb_bool altmode; switch (c) { case '|': case '*': case '&': case '?': @@ -636,6 +637,14 @@ mrb_get_args(mrb_state *mrb, const char *format, ...) break; } + if (*format == '!') { + format ++; + altmode = TRUE; + } + else { + altmode = FALSE; + } + switch (c) { case 'o': { @@ -670,18 +679,12 @@ mrb_get_args(mrb_state *mrb, const char *format, ...) mrb_value *p; p = va_arg(ap, mrb_value*); - if (*format == '!') { - format++; - if (i < argc && mrb_nil_p(argv[arg_i])) { - *p = argv[arg_i++]; - i++; - break; - } - } if (i < argc) { *p = argv[arg_i++]; - mrb_to_str(mrb, *p); i++; + if (!(altmode && mrb_nil_p(*p))) { + mrb_to_str(mrb, *p); + } } } break; @@ -690,17 +693,12 @@ mrb_get_args(mrb_state *mrb, const char *format, ...) mrb_value *p; p = va_arg(ap, mrb_value*); - if (*format == '!') { - format++; - if (i < argc && mrb_nil_p(argv[arg_i])) { - *p = argv[arg_i++]; - i++; - break; - } - } if (i < argc) { - *p = to_ary(mrb, argv[arg_i++]); + *p = argv[arg_i++]; i++; + if (!(altmode && mrb_nil_p(*p))) { + *p = to_ary(mrb, *p); + } } } break; @@ -709,17 +707,12 @@ mrb_get_args(mrb_state *mrb, const char *format, ...) mrb_value *p; p = va_arg(ap, mrb_value*); - if (*format == '!') { - format++; - if (i < argc && mrb_nil_p(argv[arg_i])) { - *p = argv[arg_i++]; - i++; - break; - } - } if (i < argc) { - *p = to_hash(mrb, argv[arg_i++]); + *p = argv[arg_i++]; i++; + if (!(altmode && mrb_nil_p(*p))) { + *p = to_hash(mrb, *p); + } } } break; @@ -731,21 +724,18 @@ mrb_get_args(mrb_state *mrb, const char *format, ...) ps = va_arg(ap, char**); pl = va_arg(ap, mrb_int*); - if (*format == '!') { - format++; - if (i < argc && mrb_nil_p(argv[arg_i])) { - *ps = NULL; - *pl = 0; - i++; arg_i++; - break; - } - } if (i < argc) { ss = argv[arg_i++]; - mrb_to_str(mrb, ss); - *ps = RSTRING_PTR(ss); - *pl = RSTRING_LEN(ss); i++; + if (altmode && mrb_nil_p(ss)) { + *ps = NULL; + *pl = 0; + } + else { + mrb_to_str(mrb, ss); + *ps = RSTRING_PTR(ss); + *pl = RSTRING_LEN(ss); + } } } break; @@ -755,19 +745,16 @@ mrb_get_args(mrb_state *mrb, const char *format, ...) const char **ps; ps = va_arg(ap, const char**); - if (*format == '!') { - format++; - if (i < argc && mrb_nil_p(argv[arg_i])) { - *ps = NULL; - i++; arg_i++; - break; - } - } if (i < argc) { ss = argv[arg_i++]; - mrb_to_str(mrb, ss); - *ps = RSTRING_CSTR(mrb, ss); i++; + if (altmode && mrb_nil_p(ss)) { + *ps = NULL; + } + else { + mrb_to_str(mrb, ss); + *ps = RSTRING_CSTR(mrb, ss); + } } } break; @@ -780,21 +767,19 @@ mrb_get_args(mrb_state *mrb, const char *format, ...) pb = va_arg(ap, mrb_value**); pl = va_arg(ap, mrb_int*); - if (*format == '!') { - format++; - if (i < argc && mrb_nil_p(argv[arg_i])) { + if (i < argc) { + aa = argv[arg_i++]; + i++; + if (altmode && mrb_nil_p(aa)) { *pb = 0; *pl = 0; - i++; arg_i++; - break; } - } - if (i < argc) { - aa = to_ary(mrb, argv[arg_i++]); - a = mrb_ary_ptr(aa); - *pb = ARY_PTR(a); - *pl = ARY_LEN(a); - i++; + else { + aa = to_ary(mrb, aa); + a = mrb_ary_ptr(aa); + *pb = ARY_PTR(a); + *pl = ARY_LEN(a); + } } } break; @@ -874,17 +859,15 @@ mrb_get_args(mrb_state *mrb, const char *format, ...) datap = va_arg(ap, void**); type = va_arg(ap, struct mrb_data_type const*); - if (*format == '!') { - format++; - if (i < argc && mrb_nil_p(argv[arg_i])) { + if (i < argc) { + mrb_value dd = argv[arg_i++]; + i++; + if (altmode && mrb_nil_p(dd)) { *datap = 0; - i++; arg_i++; - break; } - } - if (i < argc) { - *datap = mrb_data_get_ptr(mrb, argv[arg_i++], type); - ++i; + else { + *datap = mrb_data_get_ptr(mrb, dd, type); + } } } break; @@ -900,11 +883,8 @@ mrb_get_args(mrb_state *mrb, const char *format, ...) else { bp = mrb->c->stack + mrb->c->ci->argc + 1; } - if (*format == '!') { - format ++; - if (mrb_nil_p(*bp)) { - mrb_raise(mrb, E_ARGUMENT_ERROR, "no block given"); - } + if (altmode && mrb_nil_p(*bp)) { + mrb_raise(mrb, E_ARGUMENT_ERROR, "no block given"); } *p = *bp; } @@ -926,12 +906,8 @@ mrb_get_args(mrb_state *mrb, const char *format, ...) { mrb_value **var; mrb_int *pl; - mrb_bool nocopy = array_argv ? TRUE : FALSE; + mrb_bool nocopy = altmode || array_argv ? TRUE : FALSE; - if (*format == '!') { - format++; - nocopy = TRUE; - } var = va_arg(ap, mrb_value**); pl = va_arg(ap, mrb_int*); if (argc > i) { -- cgit v1.2.3