From 70eaf92d8a29ff8cb6135b9c7df547a0320e95bf Mon Sep 17 00:00:00 2001 From: skandhas Date: Fri, 9 Nov 2012 15:55:09 +0800 Subject: fix incorrect mrb->irep initialization --- src/state.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src') diff --git a/src/state.c b/src/state.c index db31d7037..106ab2aa3 100644 --- a/src/state.c +++ b/src/state.c @@ -126,7 +126,7 @@ mrb_add_irep(mrb_state *mrb, int idx) mrb->irep_capa *= 2; } mrb->irep = (mrb_irep **)mrb_realloc(mrb, mrb->irep, sizeof(mrb_irep*)*mrb->irep_capa); - for (i = old_capa; i < mrb->irep_capa - old_capa; i++) { + for (i = old_capa; i < mrb->irep_capa; i++) { mrb->irep[i] = NULL; } } -- cgit v1.2.3 From 1cc44cfd78e00879e983ffa320e16a2d99558067 Mon Sep 17 00:00:00 2001 From: skandhas Date: Fri, 9 Nov 2012 23:00:24 +0800 Subject: add Module#class_variables --- include/mruby/variable.h | 1 + src/class.c | 1 + src/variable.c | 44 ++++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 46 insertions(+) (limited to 'src') diff --git a/include/mruby/variable.h b/include/mruby/variable.h index e805b4b2b..5126315c4 100644 --- a/include/mruby/variable.h +++ b/include/mruby/variable.h @@ -53,6 +53,7 @@ void mrb_gv_set(mrb_state *mrb, mrb_sym sym, mrb_value val); mrb_value mrb_obj_instance_variables(mrb_state*, mrb_value); mrb_value mrb_obj_iv_inspect(mrb_state*, struct RObject*); mrb_sym mrb_class_sym(mrb_state *mrb, struct RClass *c, struct RClass *outer); +mrb_value mrb_mod_class_variables(mrb_state*, mrb_value); /* GC functions */ void mrb_gc_mark_gv(mrb_state*); diff --git a/src/class.c b/src/class.c index cf2f6df50..4df422e26 100644 --- a/src/class.c +++ b/src/class.c @@ -1440,6 +1440,7 @@ mrb_init_class(mrb_state *mrb) mrb_define_method(mrb, mod, "const_get", mrb_mod_const_get, ARGS_REQ(1)); /* 15.2.2.4.21 */ mrb_define_method(mrb, mod, "const_set", mrb_mod_const_set, ARGS_REQ(2)); /* 15.2.2.4.23 */ mrb_define_method(mrb, mod, "define_method", mod_define_method, ARGS_REQ(1)); + mrb_define_method(mrb, mod, "class_variables", mrb_mod_class_variables, ARGS_ANY()); /* 15.2.2.4.19 */ mrb_define_method(mrb, mod, "===", mrb_mod_eqq, ARGS_REQ(1)); mrb_undef_method(mrb, cls, "append_features"); diff --git a/src/variable.c b/src/variable.c index b3b3b3d87..19853685c 100644 --- a/src/variable.c +++ b/src/variable.c @@ -615,6 +615,50 @@ mrb_obj_instance_variables(mrb_state *mrb, mrb_value self) return ary; } +static int +cv_i(mrb_state *mrb, mrb_sym sym, mrb_value v, void *p) +{ + mrb_value ary; + const char* s; + int len; + + ary = *(mrb_value*)p; + s = mrb_sym2name_len(mrb, sym, &len); + if (len > 2 && s[0] == '@' && s[1] == '@') { + mrb_ary_push(mrb, ary, mrb_symbol_value(sym)); + } + return 0; +} + +/* 15.2.2.4.19 */ +/* + * call-seq: + * mod.class_variables -> array + * + * Returns an array of the names of class variables in mod. + * + * class One + * @@var1 = 1 + * end + * class Two < One + * @@var2 = 2 + * end + * One.class_variables #=> [:@@var1] + * Two.class_variables #=> [:@@var2] + */ +mrb_value +mrb_mod_class_variables(mrb_state *mrb, mrb_value mod) +{ + mrb_value ary; + + ary = mrb_ary_new(mrb); + if (obj_iv_p(mod) && mrb_obj_ptr(mod)->iv) { + iv_foreach(mrb, mrb_obj_ptr(mod)->iv, cv_i, &ary); + } + return ary; +} + + mrb_value mrb_vm_cv_get(mrb_state *mrb, mrb_sym sym) { -- cgit v1.2.3 From 191d1391c66ddca71bf9e19f5af18478e73428d7 Mon Sep 17 00:00:00 2001 From: Yukihiro Matz Matsumoto Date: Mon, 12 Nov 2012 18:28:33 +0900 Subject: should wrap associ in aref_args; close #529 --- src/parse.y | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src') diff --git a/src/parse.y b/src/parse.y index abec59e3f..bfea1f69c 100644 --- a/src/parse.y +++ b/src/parse.y @@ -1749,7 +1749,7 @@ aref_args : none } | assocs trailer { - $$ = new_hash(p, $1); + $$ = cons(new_hash(p, $1), 0); } ; -- cgit v1.2.3 From 611cfee3c2ff1a06760cbe4d0d1415f65087b505 Mon Sep 17 00:00:00 2001 From: skandhas Date: Mon, 12 Nov 2012 20:43:10 +0800 Subject: modify aspec --- src/class.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src') diff --git a/src/class.c b/src/class.c index 4df422e26..e737a1201 100644 --- a/src/class.c +++ b/src/class.c @@ -1440,7 +1440,7 @@ mrb_init_class(mrb_state *mrb) mrb_define_method(mrb, mod, "const_get", mrb_mod_const_get, ARGS_REQ(1)); /* 15.2.2.4.21 */ mrb_define_method(mrb, mod, "const_set", mrb_mod_const_set, ARGS_REQ(2)); /* 15.2.2.4.23 */ mrb_define_method(mrb, mod, "define_method", mod_define_method, ARGS_REQ(1)); - mrb_define_method(mrb, mod, "class_variables", mrb_mod_class_variables, ARGS_ANY()); /* 15.2.2.4.19 */ + mrb_define_method(mrb, mod, "class_variables", mrb_mod_class_variables, ARGS_NONE()); /* 15.2.2.4.19 */ mrb_define_method(mrb, mod, "===", mrb_mod_eqq, ARGS_REQ(1)); mrb_undef_method(mrb, cls, "append_features"); -- cgit v1.2.3 From 224da1e6ecc1d2f47ea3cdbfac294cdbe7cdc3dd Mon Sep 17 00:00:00 2001 From: Masaki Muranaka Date: Tue, 13 Nov 2012 12:59:00 +0900 Subject: Remove a redundant "%". --- src/sprintf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src') diff --git a/src/sprintf.c b/src/sprintf.c index 630875a88..0e8ac830f 100644 --- a/src/sprintf.c +++ b/src/sprintf.c @@ -671,7 +671,7 @@ retry: tmp = mrb_check_string_type(mrb, val); if (!mrb_nil_p(tmp)) { if (RSTRING_LEN(tmp) != 1 ) { - mrb_raise(mrb, E_ARGUMENT_ERROR, "%%c requires a character"); + mrb_raise(mrb, E_ARGUMENT_ERROR, "%c requires a character"); } c = RSTRING_PTR(tmp)[0]; n = 1; -- cgit v1.2.3 From b1f5840aefe0c4edac9dc3f238bdb757521eb67c Mon Sep 17 00:00:00 2001 From: Tomoyuki Sahara Date: Tue, 13 Nov 2012 16:50:41 +0900 Subject: fix the issue String#slice with Range may return broken String. --- src/range.c | 2 +- test/t/string.rb | 26 ++++++++++++++++++++++++++ 2 files changed, 27 insertions(+), 1 deletion(-) (limited to 'src') diff --git a/src/range.c b/src/range.c index 6fe7964fe..085d5b1c0 100644 --- a/src/range.c +++ b/src/range.c @@ -286,7 +286,7 @@ mrb_range_beg_len(mrb_state *mrb, mrb_value range, mrb_int *begp, mrb_int *lenp, if (end > len) end = len; } if (end < 0) end += len; - if (!r->excl) end++; /* include end point */ + if (!r->excl && end < len) end++; /* include end point */ len = end - beg; if (len < 0) len = 0; diff --git a/test/t/string.rb b/test/t/string.rb index 26b7df584..1e921c668 100644 --- a/test/t/string.rb +++ b/test/t/string.rb @@ -61,6 +61,32 @@ assert('String#[]', '15.2.10.5.6') do a3 == 'bc' and b3 == nil end +assert('String#[] with Range') do + a1 = 'abc'[1..0] + b1 = 'abc'[1..1] + c1 = 'abc'[1..2] + d1 = 'abc'[1..3] + e1 = 'abc'[1..4] + f1 = 'abc'[0..-2] + g1 = 'abc'[-2..3] + h1 = 'abc'[3..4] + i1 = 'abc'[4..5] + a2 = 'abc'[1...0] + b2 = 'abc'[1...1] + c2 = 'abc'[1...2] + d2 = 'abc'[1...3] + e2 = 'abc'[1...4] + f2 = 'abc'[0...-2] + g2 = 'abc'[-2...3] + h2 = 'abc'[3...4] + i2 = 'abc'[4...5] + + a1 == '' and b1 == 'b' and c1 == 'bc' and d1 == 'bc' and e1 == 'bc' and + f1 == 'ab' and g1 == 'bc' and h1 == '' and i2 == nil and + a2 == '' and b2 == '' and c2 == 'b' and d2 == 'bc' and e2 == 'bc' and + f2 == 'a' and g2 == 'bc' and h2 == '' and i2 == nil +end + assert('String#capitalize', '15.2.10.5.7') do a = 'abc' a.capitalize -- cgit v1.2.3 From 3eeef306184f202c106d56a13022afc54dad98cb Mon Sep 17 00:00:00 2001 From: Yukihiro Matz Matsumoto Date: Wed, 14 Nov 2012 14:42:21 +0900 Subject: make mrb_hash_keys() non static function --- include/mruby/hash.h | 1 + src/hash.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) (limited to 'src') diff --git a/include/mruby/hash.h b/include/mruby/hash.h index 7aab80f21..bb12962ca 100644 --- a/include/mruby/hash.h +++ b/include/mruby/hash.h @@ -28,6 +28,7 @@ mrb_value mrb_hash_get(mrb_state *mrb, mrb_value hash, mrb_value key); mrb_value mrb_hash_fetch(mrb_state *mrb, mrb_value hash, mrb_value key, mrb_value def); mrb_value mrb_hash_delete_key(mrb_state *mrb, mrb_value hash, mrb_value key); mrb_value mrb_hash(mrb_state *mrb, mrb_value obj); +mrb_value mrb_hash_keys(mrb_state *mrb, mrb_value hash); /* RHASH_TBL allocates st_table if not available. */ #define RHASH(obj) ((struct RHash*)((obj).value.p)) diff --git a/src/hash.c b/src/hash.c index 229e61db7..c74ac837b 100644 --- a/src/hash.c +++ b/src/hash.c @@ -965,7 +965,7 @@ mrb_hash_to_hash(mrb_state *mrb, mrb_value hash) * */ -static mrb_value +mrb_value mrb_hash_keys(mrb_state *mrb, mrb_value hash) { khash_t(ht) *h = RHASH_TBL(hash); -- cgit v1.2.3 From 1993f934f2c2fd7baa88ca45dc9a0c74743a3920 Mon Sep 17 00:00:00 2001 From: Yukihiro Matz Matsumoto Date: Wed, 14 Nov 2012 17:17:37 +0900 Subject: out of bound access in iv seglist --- src/variable.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'src') diff --git a/src/variable.c b/src/variable.c index 19853685c..7d583da40 100644 --- a/src/variable.c +++ b/src/variable.c @@ -71,13 +71,13 @@ iv_put(mrb_state *mrb, iv_tbl *t, mrb_sym sym, mrb_value val) t->size++; return; } - if (key == 0 && !matched_seg) { + if (!matched_seg && key == 0) { matched_seg = seg; matched_idx = i; } else if (key == sym) { - seg->val[i] = val; - return; + seg->val[i] = val; + return; } } prev = seg; @@ -223,10 +223,10 @@ iv_copy(mrb_state *mrb, iv_tbl *t) mrb_sym key = seg->key[i]; mrb_value val = seg->val[i]; - iv_put(mrb, t2, key, val); if ((seg->next == NULL) && (i >= t->last_len)) { return t2; } + iv_put(mrb, t2, key, val); } seg = seg->next; } -- cgit v1.2.3 From 78be24c87b684d1a18f5772e6020714d9c0caac7 Mon Sep 17 00:00:00 2001 From: Yukihiro Matz Matsumoto Date: Wed, 14 Nov 2012 17:19:01 +0900 Subject: init_copy should copy IV of SCLASS, HASH, DATA as well --- src/kernel.c | 3 +++ 1 file changed, 3 insertions(+) (limited to 'src') diff --git a/src/kernel.c b/src/kernel.c index ac3c10f46..d467a34da 100644 --- a/src/kernel.c +++ b/src/kernel.c @@ -307,6 +307,9 @@ init_copy(mrb_state *mrb, mrb_value dest, mrb_value obj) case MRB_TT_OBJECT: case MRB_TT_CLASS: case MRB_TT_MODULE: + case MRB_TT_SCLASS: + case MRB_TT_HASH: + case MRB_TT_DATA: mrb_iv_copy(mrb, dest, obj); break; -- cgit v1.2.3 From 0f6c1a034bef4ec2661930f2f8db550463edf665 Mon Sep 17 00:00:00 2001 From: Yukihiro Matz Matsumoto Date: Wed, 14 Nov 2012 23:55:06 +0900 Subject: zero initialize singleton_class iv --- src/class.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) (limited to 'src') diff --git a/src/class.c b/src/class.c index e737a1201..79daa6f86 100644 --- a/src/class.c +++ b/src/class.c @@ -74,6 +74,7 @@ make_metaclass(mrb_state *mrb, struct RClass *c) } sc = (struct RClass*)mrb_obj_alloc(mrb, MRB_TT_SCLASS, mrb->class_class); sc->mt = 0; + sc->iv = 0; if (!c->super) { sc->super = mrb->class_class; } @@ -763,9 +764,7 @@ mrb_singleton_class_ptr(mrb_state *mrb, struct RClass *c) { struct RClass *sc; - if (c->tt == MRB_TT_SCLASS) { - return c; - } + if (o->c->tt == MRB_TT_SCLASS) return; sc = (struct RClass*)mrb_obj_alloc(mrb, MRB_TT_SCLASS, mrb->class_class); sc->mt = 0; sc->super = c; -- cgit v1.2.3 From 8856c8924651d0ad9779c9256a1b0d35fb4d748a Mon Sep 17 00:00:00 2001 From: Yukihiro Matz Matsumoto Date: Wed, 14 Nov 2012 23:56:29 +0900 Subject: should print SCLASS as modules and classes --- src/class.c | 1 + 1 file changed, 1 insertion(+) (limited to 'src') diff --git a/src/class.c b/src/class.c index 79daa6f86..a3150fa5f 100644 --- a/src/class.c +++ b/src/class.c @@ -1223,6 +1223,7 @@ mrb_mod_to_s(mrb_state *mrb, mrb_value klass) switch (mrb_type(v)) { case MRB_TT_CLASS: case MRB_TT_MODULE: + case MRB_TT_SCLASS: mrb_str_append(mrb, s, mrb_inspect(mrb, v)); break; default: -- cgit v1.2.3 From a5d7ebbad04ce2f09aa1b603e471b3f161b5cc63 Mon Sep 17 00:00:00 2001 From: Yukihiro Matz Matsumoto Date: Fri, 16 Nov 2012 11:34:16 +0900 Subject: prepare metaclass of metaclass when retrieving by singleton_class(); close #540 --- src/class.c | 66 ++++++++++++++++++++++++++++-------------------------------- src/kernel.c | 3 ++- 2 files changed, 33 insertions(+), 36 deletions(-) (limited to 'src') diff --git a/src/class.c b/src/class.c index a3150fa5f..d95a05789 100644 --- a/src/class.c +++ b/src/class.c @@ -64,26 +64,38 @@ mrb_name_class(mrb_state *mrb, struct RClass *c, mrb_sym name) mrb_intern(mrb, "__classid__"), mrb_symbol_value(name)); } +#define make_metaclass(mrb, c) prepare_singleton_class((mrb), (struct RBasic*)(c)) + static void -make_metaclass(mrb_state *mrb, struct RClass *c) +prepare_singleton_class(mrb_state *mrb, struct RBasic *o) { - struct RClass *sc; + struct RClass *sc, *c; - if (c->c->tt == MRB_TT_SCLASS) { - return; - } + if (o->c->tt == MRB_TT_SCLASS) return; sc = (struct RClass*)mrb_obj_alloc(mrb, MRB_TT_SCLASS, mrb->class_class); sc->mt = 0; sc->iv = 0; - if (!c->super) { - sc->super = mrb->class_class; + if (o->tt == MRB_TT_CLASS) { + c = (struct RClass*)o; + if (!c->super) { + sc->super = mrb->class_class; + } + else { + sc->super = c->super->c; + } } - else { + else if (o->tt == MRB_TT_SCLASS) { + c = (struct RClass*)o; + make_metaclass(mrb, c->super); sc->super = c->super->c; } - c->c = sc; - mrb_field_write_barrier(mrb, (struct RBasic*)c, (struct RBasic*)sc); - mrb_field_write_barrier(mrb, (struct RBasic*)sc, (struct RBasic*)sc->super); + else { + sc->super = o->c; + } + o->c = sc; + mrb_field_write_barrier(mrb, (struct RBasic*)o, (struct RBasic*)sc); + mrb_field_write_barrier(mrb, (struct RBasic*)sc, (struct RBasic*)o); + mrb_obj_iv_set(mrb, (struct RObject*)sc, mrb_intern(mrb, "__attached__"), mrb_obj_value(o)); } struct RClass* @@ -179,7 +191,6 @@ mrb_vm_define_class(mrb_state *mrb, mrb_value outer, mrb_value super, mrb_sym id mrb_raisef(mrb, E_TYPE_ERROR, "superclass mismatch for class %s", mrb_sym2name(mrb, id)); } } - return c; } @@ -759,20 +770,6 @@ mrb_mod_included_modules(mrb_state *mrb, mrb_value self) return result; } -static struct RClass * -mrb_singleton_class_ptr(mrb_state *mrb, struct RClass *c) -{ - struct RClass *sc; - - if (o->c->tt == MRB_TT_SCLASS) return; - sc = (struct RClass*)mrb_obj_alloc(mrb, MRB_TT_SCLASS, mrb->class_class); - sc->mt = 0; - sc->super = c; - mrb_field_write_barrier(mrb, (struct RBasic*)sc, (struct RBasic*)c); - - return sc; -} - mrb_value mrb_singleton_class(mrb_state *mrb, mrb_value v) { @@ -796,14 +793,14 @@ mrb_singleton_class(mrb_state *mrb, mrb_value v) break; } obj = mrb_object(v); - obj->c = mrb_singleton_class_ptr(mrb, obj->c); + prepare_singleton_class(mrb, obj); return mrb_obj_value(obj->c); } void mrb_define_singleton_method(mrb_state *mrb, struct RObject *o, const char *name, mrb_func_t func, int aspec) { - o->c = mrb_singleton_class_ptr(mrb, o->c); + prepare_singleton_class(mrb, (struct RBasic*)o); mrb_define_method_id(mrb, o->c, mrb_intern(mrb, name), func, aspec); } @@ -944,15 +941,14 @@ mrb_value mrb_class_superclass(mrb_state *mrb, mrb_value klass) { struct RClass *c; - mrb_value superclass; c = mrb_class_ptr(klass); - if (c->super) - superclass = mrb_obj_value(mrb_class_real(c->super)); - else - superclass = mrb_nil_value(); - - return superclass; + c = c->super; + while (c && c->tt == MRB_TT_ICLASS) { + c = c->super; + } + if (!c) return mrb_nil_value(); + return mrb_obj_value(c); } static mrb_value diff --git a/src/kernel.c b/src/kernel.c index d467a34da..adb616466 100644 --- a/src/kernel.c +++ b/src/kernel.c @@ -287,7 +287,8 @@ mrb_singleton_class_clone(mrb_state *mrb, mrb_value obj) clone->super = klass->super; if (klass->iv) { - clone->iv = klass->iv; + mrb_iv_copy(mrb, mrb_obj_value(clone), mrb_obj_value(klass)); + mrb_obj_iv_set(mrb, (struct RObject*)clone, mrb_intern(mrb, "__attached__"), obj); } if (klass->mt) { clone->mt = kh_copy(mt, mrb, klass->mt); -- cgit v1.2.3 From 470bb14dc86021926952b99c4e0543c8ef12f7c0 Mon Sep 17 00:00:00 2001 From: Yukihiro Matz Matsumoto Date: Fri, 16 Nov 2012 11:51:51 +0900 Subject: should look for outermost scope to return; close #547 --- src/vm.c | 26 +++++++++++++++++++++----- 1 file changed, 21 insertions(+), 5 deletions(-) (limited to 'src') diff --git a/src/vm.c b/src/vm.c index b5bde896b..ebd505366 100644 --- a/src/vm.c +++ b/src/vm.c @@ -151,6 +151,18 @@ uvset(mrb_state *mrb, int up, int idx, mrb_value v) mrb_write_barrier(mrb, (struct RBasic*)e); } +struct REnv* +top_env(struct RProc *proc) +{ + struct REnv *e = proc->env; + + while (e->c) { + if (!e) return 0; + e = (struct REnv*)e->c; + } + return e; +} + static mrb_callinfo* cipush(mrb_state *mrb) { @@ -1153,11 +1165,15 @@ mrb_run(mrb_state *mrb, struct RProc *proc, mrb_value self) break; case OP_R_RETURN: if (!proc->env) goto NORMAL_RETURN; - if (proc->env->cioff < 0) { - localjump_error(mrb, "return"); - goto L_RAISE; - } - ci = mrb->ci = mrb->cibase + proc->env->cioff; + else { + struct REnv *e = top_env(proc); + + if (e->cioff < 0) { + localjump_error(mrb, "return"); + goto L_RAISE; + } + ci = mrb->ci = mrb->cibase + e->cioff; + } break; default: /* cannot happen */ -- cgit v1.2.3 From 7cea9d7b945a4b00cef699f47c07654f8b7bd579 Mon Sep 17 00:00:00 2001 From: Yukihiro Matz Matsumoto Date: Sat, 17 Nov 2012 02:16:35 +0900 Subject: int and mrb_int should not be mixed under -DMRB_INT64; may fix #557 --- src/array.c | 2 +- src/numeric.c | 3 ++- src/string.c | 2 +- 3 files changed, 4 insertions(+), 3 deletions(-) (limited to 'src') diff --git a/src/array.c b/src/array.c index a200de3aa..ea461e029 100644 --- a/src/array.c +++ b/src/array.c @@ -772,7 +772,7 @@ mrb_value mrb_ary_first(mrb_state *mrb, mrb_value self) { struct RArray *a = mrb_ary_ptr(self); - int size; + mrb_int size; if (mrb_get_args(mrb, "|i", &size) == 0) { return (a->len > 0)? a->ptr[0]: mrb_nil_value(); diff --git a/src/numeric.c b/src/numeric.c index 562562340..98a60ed30 100644 --- a/src/numeric.c +++ b/src/numeric.c @@ -523,7 +523,8 @@ static mrb_value flo_round(mrb_state *mrb, mrb_value num) { double number, f; - int ndigits = 0, i; + mrb_int ndigits = 0; + int i; mrb_get_args(mrb, "|i", &ndigits); number = mrb_float(num); diff --git a/src/string.c b/src/string.c index 2ac4359c8..425b79ca7 100644 --- a/src/string.c +++ b/src/string.c @@ -2125,7 +2125,7 @@ mrb_str_split_m(mrb_state *mrb, mrb_value str) mrb_value spat = mrb_nil_value(); enum {awk, string, regexp} split_type = string; long beg, end, i = 0; - int lim = -1; + mrb_int lim = -1; mrb_value result, tmp; argc = mrb_get_args(mrb, "|oi", &spat, &lim); -- cgit v1.2.3