From a9d0d90f7417007db510b77caa6098ebcb6d5b7a Mon Sep 17 00:00:00 2001 From: Lothar Scholz Date: Sun, 24 Dec 2017 06:28:38 +0100 Subject: Removed the Visual Studio Version Check because it does not work with internationalized versions of Visual Studio. It will capture the returned string in the local codepage encoding and make ruby exits with an invalid UTF8 error message. Also "Version" might be translated and not appear in the output. --- tasks/toolchains/visualcpp.rake | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) (limited to 'tasks') diff --git a/tasks/toolchains/visualcpp.rake b/tasks/toolchains/visualcpp.rake index 5bc24a73a..b008273a2 100644 --- a/tasks/toolchains/visualcpp.rake +++ b/tasks/toolchains/visualcpp.rake @@ -55,14 +55,15 @@ MRuby::Toolchain.new(:visualcpp) do |conf, _params| conf.file_separator = '\\' - if require 'open3' - Open3.popen3 conf.cc.command do |_, _, e, _| - if /Version (\d{2})\.\d{2}\.\d{5}/ =~ e.gets && $1.to_i <= 17 - m = "# VS2010/2012 support will be dropped after the next release! #" - h = "#" * m.length - puts h, m, h - end - end - end + # Unreliable detection and will result in invalid encoding errors for localized versions of Visual C++ + # if require 'open3' + # Open3.popen3 conf.cc.command do |_, _, e, _| + # if /Version (\d{2})\.\d{2}\.\d{5}/ =~ e.gets && $1.to_i <= 17 + # m = "# VS2010/2012 support will be dropped after the next release! #" + # h = "#" * m.length + # puts h, m, h + # end + # end + # end end -- cgit v1.2.3