From fc88dde63f1c4a7f547bbe0634c68c5ce9fc787c Mon Sep 17 00:00:00 2001 From: Adam <2363879+adamdotdevin@users.noreply.github.com> Date: Wed, 11 Feb 2026 09:11:41 -0600 Subject: test(app): more e2e tests (#13162) --- packages/app/e2e/projects/projects-close.spec.ts | 32 +++++++++++------------- 1 file changed, 15 insertions(+), 17 deletions(-) (limited to 'packages/app/e2e/projects/projects-close.spec.ts') diff --git a/packages/app/e2e/projects/projects-close.spec.ts b/packages/app/e2e/projects/projects-close.spec.ts index 95768d21e..4b39ed82c 100644 --- a/packages/app/e2e/projects/projects-close.spec.ts +++ b/packages/app/e2e/projects/projects-close.spec.ts @@ -1,6 +1,6 @@ import { test, expect } from "../fixtures" -import { createTestProject, cleanupTestProject, openSidebar, clickMenuItem } from "../actions" -import { projectCloseHoverSelector, projectCloseMenuSelector, projectSwitchSelector } from "../selectors" +import { createTestProject, cleanupTestProject, openSidebar, clickMenuItem, openProjectMenu } from "../actions" +import { projectCloseHoverSelector, projectSwitchSelector } from "../selectors" import { dirSlug } from "../utils" test("can close a project via hover card close button", async ({ page, withProject }) => { @@ -31,16 +31,15 @@ test("can close a project via hover card close button", async ({ page, withProje } }) -test("can close a project via project header more options menu", async ({ page, withProject }) => { +test("closing active project navigates to another open project", async ({ page, withProject }) => { await page.setViewportSize({ width: 1400, height: 800 }) const other = await createTestProject() - const otherName = other.split("/").pop() ?? other const otherSlug = dirSlug(other) try { await withProject( - async () => { + async ({ slug }) => { await openSidebar(page) const otherButton = page.locator(projectSwitchSelector(otherSlug)).first() @@ -49,21 +48,20 @@ test("can close a project via project header more options menu", async ({ page, await expect(page).toHaveURL(new RegExp(`/${otherSlug}/session`)) - const header = page - .locator(".group\\/project") - .filter({ has: page.locator(`[data-action="project-menu"][data-project="${otherSlug}"]`) }) - .first() - await expect(header).toContainText(otherName) + const menu = await openProjectMenu(page, otherSlug) - const trigger = header.locator(`[data-action="project-menu"][data-project="${otherSlug}"]`).first() - await expect(trigger).toHaveCount(1) - await trigger.focus() - await page.keyboard.press("Enter") + await clickMenuItem(menu, /^Close$/i, { force: true }) - const menu = page.locator('[data-component="dropdown-menu-content"]').first() - await expect(menu).toBeVisible({ timeout: 10_000 }) + await expect + .poll(() => { + const pathname = new URL(page.url()).pathname + if (new RegExp(`^/${slug}/session(?:/[^/]+)?/?$`).test(pathname)) return "project" + if (pathname === "/") return "home" + return "" + }) + .toMatch(/^(project|home)$/) - await clickMenuItem(menu, /^Close$/i, { force: true }) + await expect(page).not.toHaveURL(new RegExp(`/${otherSlug}/session(?:[/?#]|$)`)) await expect(otherButton).toHaveCount(0) }, { extra: [other] }, -- cgit v1.2.3