From 82f718b3cfd19cd79171d240851e29127c9d8077 Mon Sep 17 00:00:00 2001 From: Adam <2363879+adamdotdevin@users.noreply.github.com> Date: Thu, 22 Jan 2026 19:57:51 -0600 Subject: wip(app): line selection --- packages/app/src/pages/session.tsx | 101 ------------------------------------- 1 file changed, 101 deletions(-) (limited to 'packages/app/src/pages') diff --git a/packages/app/src/pages/session.tsx b/packages/app/src/pages/session.tsx index 96de3f117..9470a032f 100644 --- a/packages/app/src/pages/session.tsx +++ b/packages/app/src/pages/session.tsx @@ -1810,8 +1810,6 @@ export default function Page() { let pending: { x: number; y: number } | undefined let codeScroll: HTMLElement[] = [] - const [selectionPopoverTop, setSelectionPopoverTop] = createSignal() - const path = createMemo(() => file.pathFromTab(tab)) const state = createMemo(() => { const p = path() @@ -1855,17 +1853,6 @@ export default function Page() { if (file.ready()) return file.selectedLines(p) ?? null return handoff.files[p] ?? null }) - const selection = createMemo(() => { - const range = selectedLines() - if (!range) return - return selectionFromLines(range) - }) - const selectionLabel = createMemo(() => { - const sel = selection() - if (!sel) return - if (sel.startLine === sel.endLine) return `L${sel.startLine}` - return `L${sel.startLine}-${sel.endLine}` - }) let wrap: HTMLDivElement | undefined let textarea: HTMLTextAreaElement | undefined @@ -1991,7 +1978,6 @@ export default function Page() { commentedLines={commentedLines()} onRendered={() => { requestAnimationFrame(restoreScroll) - requestAnimationFrame(updateSelectionPopover) requestAnimationFrame(scheduleComments) }} onLineSelected={(range: SelectedLineRange | null) => { @@ -2119,61 +2105,6 @@ export default function Page() { ) - const updateSelectionPopover = () => { - const el = scroll - if (!el) { - setSelectionPopoverTop(undefined) - return - } - - const sel = selection() - if (!sel) { - setSelectionPopoverTop(undefined) - return - } - - const host = el.querySelector("diffs-container") - if (!(host instanceof HTMLElement)) { - setSelectionPopoverTop(undefined) - return - } - - const root = host.shadowRoot - if (!root) { - setSelectionPopoverTop(undefined) - return - } - - const marker = - (root.querySelector( - '[data-selected-line="last"], [data-selected-line="single"]', - ) as HTMLElement | null) ?? (root.querySelector("[data-selected-line]") as HTMLElement | null) - - if (!marker) { - setSelectionPopoverTop(undefined) - return - } - - const containerRect = el.getBoundingClientRect() - const markerRect = marker.getBoundingClientRect() - setSelectionPopoverTop(markerRect.bottom - containerRect.top + el.scrollTop + 8) - } - - createEffect( - on( - selection, - (sel) => { - if (!sel) { - setSelectionPopoverTop(undefined) - return - } - - requestAnimationFrame(updateSelectionPopover) - }, - { defer: true }, - ), - ) - const getCodeScroll = () => { const el = scroll if (!el) return [] @@ -2312,41 +2243,9 @@ export default function Page() { ref={(el: HTMLDivElement) => { scroll = el restoreScroll() - updateSelectionPopover() }} onScroll={handleScroll} > - - - {(sel) => ( -
- - - -
- )} -
-
-- cgit v1.2.3