From d7c2d5db3bc261764b415f0e6c50f1d5908a99a6 Mon Sep 17 00:00:00 2001 From: Adam <2363879+adamdotdevin@users.noreply.github.com> Date: Thu, 5 Feb 2026 14:42:56 -0600 Subject: fix(app): hide prompt input when there are perms or questions (#12339) --- packages/app/src/pages/session.tsx | 87 ++++++++++++++++++++++++++------------ 1 file changed, 60 insertions(+), 27 deletions(-) (limited to 'packages/app/src/pages') diff --git a/packages/app/src/pages/session.tsx b/packages/app/src/pages/session.tsx index b0b955ed1..cb07c3b47 100644 --- a/packages/app/src/pages/session.tsx +++ b/packages/app/src/pages/session.tsx @@ -36,6 +36,7 @@ import { BasicTool } from "@opencode-ai/ui/basic-tool" import { createAutoScroll } from "@opencode-ai/ui/hooks" import { SessionReview } from "@opencode-ai/ui/session-review" import { Mark } from "@opencode-ai/ui/logo" +import { QuestionDock } from "@/components/question-dock" import { DragDropProvider, DragDropSensors, DragOverlay, SortableProvider, closestCenter } from "@thisbeyond/solid-dnd" import type { DragEvent } from "@thisbeyond/solid-dnd" @@ -270,15 +271,20 @@ export default function Page() { const comments = useComments() const permission = usePermission() - const request = createMemo(() => { + const permRequest = createMemo(() => { const sessionID = params.id if (!sessionID) return - const next = sync.data.permission[sessionID]?.[0] - if (!next) return - if (next.tool) return - return next + return sync.data.permission[sessionID]?.[0] + }) + + const questionRequest = createMemo(() => { + const sessionID = params.id + if (!sessionID) return + return sync.data.question[sessionID]?.[0] }) + const blocked = createMemo(() => !!permRequest() || !!questionRequest()) + const [ui, setUi] = createStore({ responding: false, pendingMessage: undefined as string | undefined, @@ -292,14 +298,14 @@ export default function Page() { createEffect( on( - () => request()?.id, + () => permRequest()?.id, () => setUi("responding", false), { defer: true }, ), ) const decide = (response: "once" | "always" | "reject") => { - const perm = request() + const perm = permRequest() if (!perm) return if (ui.responding) return @@ -1351,6 +1357,7 @@ export default function Page() { } if (event.key.length === 1 && event.key !== "Unidentified" && !(event.ctrlKey || event.metaKey)) { + if (blocked()) return inputRef?.focus() } } @@ -2693,7 +2700,31 @@ export default function Page() { "md:max-w-200 3xl:max-w-[1200px] 4xl:max-w-[1600px] 5xl:max-w-[1900px]": centered(), }} > - + + {(req) => { + const count = req.questions.length + const subtitle = + count === 0 + ? "" + : `${count} ${language.t(count > 1 ? "ui.common.question.other" : "ui.common.question.one")}` + return ( +
+ + +
+ ) + }} +
+ + {(perm) => (
- - {handoff.session.get(sessionKey())?.prompt || language.t("prompt.loading")} -
- } - > - { - inputRef = el - }} - newSessionWorktree={newSessionWorktree()} - onNewSessionWorktreeReset={() => setStore("newSessionWorktree", "main")} - onSubmit={() => { - comments.clear() - resumeScroll() - }} - /> + + + {handoff.session.get(sessionKey())?.prompt || language.t("prompt.loading")} + + } + > + { + inputRef = el + }} + newSessionWorktree={newSessionWorktree()} + onNewSessionWorktreeReset={() => setStore("newSessionWorktree", "main")} + onSubmit={() => { + comments.clear() + resumeScroll() + }} + /> + -- cgit v1.2.3