From 1b028d0632c78a9061d8c235e329313b8f41646f Mon Sep 17 00:00:00 2001 From: Shoubhit Dash Date: Thu, 26 Mar 2026 19:44:57 +0530 Subject: revert: roll back git-backed review modes (#19295) --- packages/ui/src/components/session-review.tsx | 36 ++++++++++++++------------- packages/ui/src/i18n/en.ts | 2 -- 2 files changed, 19 insertions(+), 19 deletions(-) (limited to 'packages/ui/src') diff --git a/packages/ui/src/components/session-review.tsx b/packages/ui/src/components/session-review.tsx index 2274e93a3..83d2980f6 100644 --- a/packages/ui/src/components/session-review.tsx +++ b/packages/ui/src/components/session-review.tsx @@ -151,6 +151,7 @@ export const SessionReview = (props: SessionReviewProps) => { const open = () => props.open ?? store.open const files = createMemo(() => props.diffs.map((diff) => diff.file)) + const diffs = createMemo(() => new Map(props.diffs.map((diff) => [diff.file, diff] as const))) const diffStyle = () => props.diffStyle ?? (props.split ? "split" : "unified") const hasDiffs = () => files().length > 0 @@ -281,10 +282,11 @@ export const SessionReview = (props: SessionReviewProps) => {
- - {(diff) => { + + {(file) => { let wrapper: HTMLDivElement | undefined - const file = diff.file + + const item = createMemo(() => diffs().get(file)!) const expanded = createMemo(() => open().includes(file)) const force = () => !!store.force[file] @@ -292,9 +294,9 @@ export const SessionReview = (props: SessionReviewProps) => { const comments = createMemo(() => (props.comments ?? []).filter((c) => c.file === file)) const commentedLines = createMemo(() => comments().map((c) => c.selection)) - const beforeText = () => (typeof diff.before === "string" ? diff.before : "") - const afterText = () => (typeof diff.after === "string" ? diff.after : "") - const changedLines = () => diff.additions + diff.deletions + const beforeText = () => (typeof item().before === "string" ? item().before : "") + const afterText = () => (typeof item().after === "string" ? item().after : "") + const changedLines = () => item().additions + item().deletions const mediaKind = createMemo(() => mediaKindFromPath(file)) const tooLarge = createMemo(() => { @@ -305,9 +307,9 @@ export const SessionReview = (props: SessionReviewProps) => { }) const isAdded = () => - diff.status === "added" || (beforeText().length === 0 && afterText().length > 0) + item().status === "added" || (beforeText().length === 0 && afterText().length > 0) const isDeleted = () => - diff.status === "deleted" || (afterText().length === 0 && beforeText().length > 0) + item().status === "deleted" || (afterText().length === 0 && beforeText().length > 0) const selectedLines = createMemo(() => { const current = selection() @@ -344,7 +346,7 @@ export const SessionReview = (props: SessionReviewProps) => { file, selection, comment, - preview: selectionPreview(diff, selection), + preview: selectionPreview(item(), selection), }) }, onUpdate: ({ id, comment, selection }) => { @@ -353,7 +355,7 @@ export const SessionReview = (props: SessionReviewProps) => { file, selection, comment, - preview: selectionPreview(diff, selection), + preview: selectionPreview(item(), selection), }) }, onDelete: (comment) => { @@ -430,7 +432,7 @@ export const SessionReview = (props: SessionReviewProps) => { {i18n.t("ui.sessionReview.change.added")} - +
@@ -444,7 +446,7 @@ export const SessionReview = (props: SessionReviewProps) => { - + @@ -490,7 +492,7 @@ export const SessionReview = (props: SessionReviewProps) => { { props.onDiffRendered?.() @@ -507,17 +509,17 @@ export const SessionReview = (props: SessionReviewProps) => { commentedLines={commentedLines()} before={{ name: file, - contents: typeof diff.before === "string" ? diff.before : "", + contents: typeof item().before === "string" ? item().before : "", }} after={{ name: file, - contents: typeof diff.after === "string" ? diff.after : "", + contents: typeof item().after === "string" ? item().after : "", }} media={{ mode: "auto", path: file, - before: diff.before, - after: diff.after, + before: item().before, + after: item().after, readFile: props.readFile, }} /> diff --git a/packages/ui/src/i18n/en.ts b/packages/ui/src/i18n/en.ts index d9f724fce..18823aeaa 100644 --- a/packages/ui/src/i18n/en.ts +++ b/packages/ui/src/i18n/en.ts @@ -1,7 +1,5 @@ export const dict: Record = { "ui.sessionReview.title": "Session changes", - "ui.sessionReview.title.git": "Git changes", - "ui.sessionReview.title.branch": "Branch changes", "ui.sessionReview.title.lastTurn": "Last turn changes", "ui.sessionReview.diffStyle.unified": "Unified", "ui.sessionReview.diffStyle.split": "Split", -- cgit v1.2.3