From 327f62526a7f60c1c67ae017d1b105466bb730e9 Mon Sep 17 00:00:00 2001 From: Brendan Allan Date: Thu, 2 Apr 2026 17:24:10 +0800 Subject: use solid-primitives/resize-observer across web code (#20613) --- packages/web/src/components/share/common.tsx | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) (limited to 'packages/web/src/components/share') diff --git a/packages/web/src/components/share/common.tsx b/packages/web/src/components/share/common.tsx index aebc95537..ad50e425f 100644 --- a/packages/web/src/components/share/common.tsx +++ b/packages/web/src/components/share/common.tsx @@ -1,5 +1,6 @@ -import { createContext, createSignal, onCleanup, splitProps, useContext } from "solid-js" +import { createContext, createSignal, splitProps, useContext } from "solid-js" import type { JSX } from "solid-js/jsx-runtime" +import { makeResizeObserver } from "@solid-primitives/resize-observer" import { IconCheckCircle, IconHashtag } from "../icons" export type ShareMessages = { locale: string } & Record @@ -87,16 +88,10 @@ export function createOverflow() { setOverflow(el.scrollHeight > el.clientHeight + 1) } - const ro = new ResizeObserver(() => { - sync() - }) + const obs = makeResizeObserver(sync) + obs.observe(el) sync() - ro.observe(el) - - onCleanup(() => { - ro.disconnect() - }) }, } } -- cgit v1.2.3