diff options
| author | Geremia Taglialatela <[email protected]> | 2023-05-23 01:37:22 +0200 |
|---|---|---|
| committer | Geremia Taglialatela <[email protected]> | 2023-05-23 01:37:22 +0200 |
| commit | 1eb9c45c20f2b459ffdb562507e2b6793196dec9 (patch) | |
| tree | 3d12113360c690c61ea8373e6be1cc62bc8964e1 | |
| parent | 6752225bbb8a9eec905ec02a98f1a25a309c404a (diff) | |
| download | caxlsx-1eb9c45c20f2b459ffdb562507e2b6793196dec9.tar.gz caxlsx-1eb9c45c20f2b459ffdb562507e2b6793196dec9.zip | |
Fix Performance/RedundantBlockCall offense
Ref: https://github.com/fastruby/fast-ruby#proccall-and-block-arguments-vs-yieldcode
| -rw-r--r-- | .rubocop_todo.yml | 5 | ||||
| -rw-r--r-- | lib/axlsx/util/zip_command.rb | 4 |
2 files changed, 2 insertions, 7 deletions
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 1de00edb..a6f0c9af 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -89,11 +89,6 @@ Performance/CollectionLiteralInLoop: - 'lib/axlsx/workbook/worksheet/page_margins.rb' # This cop supports safe autocorrection (--autocorrect). -Performance/RedundantBlockCall: - Exclude: - - 'lib/axlsx/util/zip_command.rb' - -# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle. # SupportedStyles: separated, grouped Style/AccessorGrouping: diff --git a/lib/axlsx/util/zip_command.rb b/lib/axlsx/util/zip_command.rb index bc098a92..44e06af5 100644 --- a/lib/axlsx/util/zip_command.rb +++ b/lib/axlsx/util/zip_command.rb @@ -25,10 +25,10 @@ module Axlsx # Create a temporary directory for writing files to. # # The directory and its contents are removed at the end of the block. - def open(output, &block) + def open(output) Dir.mktmpdir do |dir| @dir = dir - block.call(self) + yield(self) write_file zip_parts(output) end |