diff options
| author | Geremia Taglialatela <[email protected]> | 2023-04-05 17:52:33 +0200 |
|---|---|---|
| committer | Geremia Taglialatela <[email protected]> | 2023-04-06 09:56:05 +0200 |
| commit | 412763fbf817da4519c544dd225803a80ca121f3 (patch) | |
| tree | 8f8d11e3f310f5767d346aad57a320ec9b18ca93 | |
| parent | eebb33ab2fac3b04dada178f98d03e3a587f620e (diff) | |
| download | caxlsx-412763fbf817da4519c544dd225803a80ca121f3.tar.gz caxlsx-412763fbf817da4519c544dd225803a80ca121f3.zip | |
Fix Layout offenses related to access modifiers
```
rubocop --only Layout/EmptyLinesAroundAccessModifier,Layout/AccessModifierIndentation -a
```
| -rw-r--r-- | lib/axlsx/drawing/marker.rb | 1 | ||||
| -rw-r--r-- | lib/axlsx/drawing/view_3D.rb | 1 | ||||
| -rw-r--r-- | lib/axlsx/stylesheet/styles.rb | 1 | ||||
| -rw-r--r-- | lib/axlsx/workbook/worksheet/color_scale.rb | 1 | ||||
| -rw-r--r-- | lib/axlsx/workbook/worksheet/data_validation.rb | 3 | ||||
| -rw-r--r-- | lib/axlsx/workbook/worksheet/pane.rb | 1 | ||||
| -rw-r--r-- | lib/axlsx/workbook/worksheet/sheet_format_pr.rb | 1 | ||||
| -rw-r--r-- | lib/axlsx/workbook/worksheet/sheet_protection.rb | 1 |
8 files changed, 9 insertions, 1 deletions
diff --git a/lib/axlsx/drawing/marker.rb b/lib/axlsx/drawing/marker.rb index d884ef3c..94125143 100644 --- a/lib/axlsx/drawing/marker.rb +++ b/lib/axlsx/drawing/marker.rb @@ -60,6 +60,7 @@ module Axlsx str << ('<xdr:' << k.to_s << '>' << self.send(k).to_s << '</xdr:' << k.to_s << '>') end end + private # handles multiple inputs for setting the position of a marker diff --git a/lib/axlsx/drawing/view_3D.rb b/lib/axlsx/drawing/view_3D.rb index 0424baac..ab959c87 100644 --- a/lib/axlsx/drawing/view_3D.rb +++ b/lib/axlsx/drawing/view_3D.rb @@ -104,6 +104,7 @@ module Axlsx end private + # Note: move this to Axlsx module if we find the smae pattern elsewhere. def element_for_attribute(name, namespace='') val = Axlsx.instance_values_for(self)[name] diff --git a/lib/axlsx/stylesheet/styles.rb b/lib/axlsx/stylesheet/styles.rb index 72706e3b..a28785c9 100644 --- a/lib/axlsx/stylesheet/styles.rb +++ b/lib/axlsx/stylesheet/styles.rb @@ -489,6 +489,7 @@ module Axlsx end private + # Creates the default set of styles the exel requires to be valid as well as setting up the # Axlsx::STYLE_THIN_BORDER def load_default_styles diff --git a/lib/axlsx/workbook/worksheet/color_scale.rb b/lib/axlsx/workbook/worksheet/color_scale.rb index dc347a6a..b93240a5 100644 --- a/lib/axlsx/workbook/worksheet/color_scale.rb +++ b/lib/axlsx/workbook/worksheet/color_scale.rb @@ -92,6 +92,7 @@ module Axlsx end private + # There has got to be cleaner way of merging these arrays. def initialize_default_cfvos(user_cfvos) defaults = self.class.default_cfvos diff --git a/lib/axlsx/workbook/worksheet/data_validation.rb b/lib/axlsx/workbook/worksheet/data_validation.rb index 194c9a27..0cd28069 100644 --- a/lib/axlsx/workbook/worksheet/data_validation.rb +++ b/lib/axlsx/workbook/worksheet/data_validation.rb @@ -244,7 +244,8 @@ module Axlsx str << '</dataValidation>' end - private + private + def get_valid_attributes attributes = [:allowBlank, :error, :errorStyle, :errorTitle, :prompt, :promptTitle, :showErrorMessage, :showInputMessage, :sqref, :type ] diff --git a/lib/axlsx/workbook/worksheet/pane.rb b/lib/axlsx/workbook/worksheet/pane.rb index 9c8671e6..bff08bb5 100644 --- a/lib/axlsx/workbook/worksheet/pane.rb +++ b/lib/axlsx/workbook/worksheet/pane.rb @@ -125,6 +125,7 @@ module Axlsx finalize serialized_tag 'pane', str end + private def finalize diff --git a/lib/axlsx/workbook/worksheet/sheet_format_pr.rb b/lib/axlsx/workbook/worksheet/sheet_format_pr.rb index f7cff58c..e0b981ef 100644 --- a/lib/axlsx/workbook/worksheet/sheet_format_pr.rb +++ b/lib/axlsx/workbook/worksheet/sheet_format_pr.rb @@ -52,6 +52,7 @@ module Axlsx end private + def set_defaults @base_col_width = 8 @default_row_height = 18 diff --git a/lib/axlsx/workbook/worksheet/sheet_protection.rb b/lib/axlsx/workbook/worksheet/sheet_protection.rb index 9e27c8d8..d1aaf00c 100644 --- a/lib/axlsx/workbook/worksheet/sheet_protection.rb +++ b/lib/axlsx/workbook/worksheet/sheet_protection.rb @@ -79,6 +79,7 @@ module Axlsx end private + # Creates a password hash for a given password # @return [String] def create_password_hash(password) |
