diff options
| author | Randy Morgan (@morgan_randy) <[email protected]> | 2016-11-15 11:03:19 +0900 |
|---|---|---|
| committer | GitHub <[email protected]> | 2016-11-15 11:03:19 +0900 |
| commit | 84509970fa46e36cdf0a8e82f5dc5ba3774072f6 (patch) | |
| tree | 1340cb1c5f8d9fcb95c7c0f655d227dc0ca0e891 | |
| parent | 27f1507035f460471620ef7b3fe0b448211f0096 (diff) | |
| parent | 5a7e890c40e8ec2f9669eb130721397bc97f0d38 (diff) | |
| download | caxlsx-84509970fa46e36cdf0a8e82f5dc5ba3774072f6.tar.gz caxlsx-84509970fa46e36cdf0a8e82f5dc5ba3774072f6.zip | |
Merge pull request #494 from sato-s/sheet-title
Fix #472: worksheet name with underscore
| -rw-r--r-- | lib/axlsx/workbook/worksheet/worksheet.rb | 3 | ||||
| -rw-r--r-- | test/workbook/tc_workbook.rb | 6 |
2 files changed, 8 insertions, 1 deletions
diff --git a/lib/axlsx/workbook/worksheet/worksheet.rb b/lib/axlsx/workbook/worksheet/worksheet.rb index 6ef1a755..031a081f 100644 --- a/lib/axlsx/workbook/worksheet/worksheet.rb +++ b/lib/axlsx/workbook/worksheet/worksheet.rb @@ -27,7 +27,7 @@ module Axlsx yield self if block_given? end - serializable_attributes :sheet_id, :name, :state + serializable_attributes :sheet_id, :state # Initalizes page margin, setup and print options # @param [Hash] options Options passed in from the initializer @@ -597,6 +597,7 @@ module Axlsx add_autofilter_defined_name_to_workbook str << '<sheet ' serialized_attributes str + str << ('name="' << name << '" ') str << ('r:id="' << rId << '"></sheet>') end diff --git a/test/workbook/tc_workbook.rb b/test/workbook/tc_workbook.rb index 51dd01f4..ab400db1 100644 --- a/test/workbook/tc_workbook.rb +++ b/test/workbook/tc_workbook.rb @@ -136,4 +136,10 @@ class TestWorkbook < Test::Unit::TestCase doc = Nokogiri::XML(@wb.to_xml_string) assert_equal pivot_table.cache_definition.rId, doc.xpath("//xmlns:pivotCache").first["r:id"] end + + def test_worksheet_name_is_intact_after_serialized_into_xml + sheet = @wb.add_worksheet(:name => '_Example') + wb_xml = Nokogiri::XML(@wb.to_xml_string) + assert_equal sheet.name, wb_xml.xpath('//xmlns:workbook/xmlns:sheets/*[1]/@name').to_s + end end |
