summaryrefslogtreecommitdiffhomepage
diff options
context:
space:
mode:
authorMoses Hohman <[email protected]>2013-06-23 02:17:19 -0500
committerMoses Hohman <[email protected]>2013-06-23 02:17:19 -0500
commitc560d142d36c211154f03f271747f8756e75fc63 (patch)
treec492ecdefaf459824d5a24e76b6b0732c8149cd8
parent15e78a467348d744ee58039b484adb8083290fb9 (diff)
downloadcaxlsx-c560d142d36c211154f03f271747f8756e75fc63.tar.gz
caxlsx-c560d142d36c211154f03f271747f8756e75fc63.zip
fixed bad test case and bad code for dispBlanksAs (setting now actually makes it into XML)
This means there are many other test cases in the suite that are not verifying what they look like they're verifying.
-rw-r--r--lib/axlsx/drawing/chart.rb3
-rw-r--r--test/drawing/tc_chart.rb2
2 files changed, 2 insertions, 3 deletions
diff --git a/lib/axlsx/drawing/chart.rb b/lib/axlsx/drawing/chart.rb
index 5f7db77f..1da3a253 100644
--- a/lib/axlsx/drawing/chart.rb
+++ b/lib/axlsx/drawing/chart.rb
@@ -173,8 +173,7 @@ module Axlsx
str << '</c:legend>'
end
str << '<c:plotVisOnly val="1"/>'
- str << '<c:dispBlanksAs val="zero"/>'
- # str << '<c:dispBlanksAs val="' << display_blanks_as.to_s << '"/>'
+ str << '<c:dispBlanksAs val="' << display_blanks_as.to_s << '"/>'
str << '<c:showDLblsOverMax val="1"/>'
str << '</c:chart>'
str << '<c:printSettings>'
diff --git a/test/drawing/tc_chart.rb b/test/drawing/tc_chart.rb
index 50cb5d0c..751d2ae4 100644
--- a/test/drawing/tc_chart.rb
+++ b/test/drawing/tc_chart.rb
@@ -106,6 +106,6 @@ class TestChart < Test::Unit::TestCase
schema = Nokogiri::XML::Schema(File.open(Axlsx::DRAWING_XSD))
@chart.display_blanks_as = :span
doc = Nokogiri::XML(@chart.to_xml_string)
- assert(doc.xpath("//c:dispBlanksAs[@val='span']"))
+ assert_equal("span", doc.xpath("//c:dispBlanksAs").attr("val").value, "did not use the display_blanks_as configuration")
end
end