summaryrefslogtreecommitdiffhomepage
path: root/lib/axlsx/workbook/worksheet/cell_serializer.rb
diff options
context:
space:
mode:
authorGeremia Taglialatela <[email protected]>2023-06-06 17:54:58 +0200
committerGeremia Taglialatela <[email protected]>2023-06-06 17:54:58 +0200
commitb429bd3e7509eafa3f72fb918e691bb8dacc7b19 (patch)
treebd9e5826f7274279fb9a35b842581937ab40a9b3 /lib/axlsx/workbook/worksheet/cell_serializer.rb
parent2965ebd4c719ad34a75e70cb1640e94093c8c763 (diff)
downloadcaxlsx-b429bd3e7509eafa3f72fb918e691bb8dacc7b19.tar.gz
caxlsx-b429bd3e7509eafa3f72fb918e691bb8dacc7b19.zip
Invert nil checks to improve performance
Check for `nil` before checking for more expensive conditions which include a method call or an array scan. Also removes redundant comments on self-explanatory code
Diffstat (limited to 'lib/axlsx/workbook/worksheet/cell_serializer.rb')
-rw-r--r--lib/axlsx/workbook/worksheet/cell_serializer.rb2
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/axlsx/workbook/worksheet/cell_serializer.rb b/lib/axlsx/workbook/worksheet/cell_serializer.rb
index 30a2b5fe..9075c9c3 100644
--- a/lib/axlsx/workbook/worksheet/cell_serializer.rb
+++ b/lib/axlsx/workbook/worksheet/cell_serializer.rb
@@ -27,7 +27,7 @@ module Axlsx
if cell.is_text_run?
valid = RichTextRun::INLINE_STYLES - [:value, :type]
data = Axlsx.instance_values_for(cell).transform_keys(&:to_sym)
- data = data.select { |key, value| valid.include?(key) && !value.nil? }
+ data = data.select { |key, value| !value.nil? && valid.include?(key) }
RichText.new(cell.value.to_s, data).to_xml_string(str)
elsif cell.contains_rich_text?
cell.value.to_xml_string(str)