Huge refactoring

Do not create huge strings
Let Row inherit from SimpleTypedList
Optimized sanitizing
Optimized validation
And more..

1 files changed, 8 insertions, 10 deletions

diff --git a/lib/axlsx/workbook/worksheet/comments.rb b/lib/axlsx/workbook/worksheet/comments.rb
index 4023c4b8..dfc6d143 100644
--- a/lib/axlsx/workbook/worksheet/comments.rb
+++ b/lib/axlsx/workbook/worksheet/comments.rb
@@ -42,15 +42,15 @@ module Axlsx
       raise ArgumentError, "Comment require an author" unless options[:author]
       raise ArgumentError, "Comment requires text" unless options[:text]
       raise ArgumentError, "Comment requires ref" unless options[:ref]
-      @list << Comment.new(self, options)
-      yield @list.last if block_given?
-      @list.last
+      self << Comment.new(self, options)
+      yield last if block_given?
+      last
     end
 
     # A sorted list of the unique authors in the contained comments
     # @return [Array]
     def authors
-      @list.map { |comment| comment.author.to_s }.uniq.sort
+      map { |comment| comment.author.to_s }.uniq.sort
     end
 
     # The relationships required by this object
@@ -65,14 +65,12 @@ module Axlsx
     # @return [String]
     def to_xml_string(str="")
       str << '<?xml version="1.0" encoding="UTF-8"?>'
-      str << '<comments xmlns="' << XML_NS << '">'
-      str << '<authors>'
+      str << ('<comments xmlns="' << XML_NS << '"><authors>')
       authors.each do  |author|
-        str << '<author>' << author.to_s << '</author>'
+        str << ('<author>' << author.to_s << '</author>')
       end
-      str << '</authors>'
-      str << '<commentList>'
-      @list.each do |comment|
+      str << '</authors><commentList>'
+      each do |comment|
         comment.to_xml_string str
       end
       str << '</commentList></comments>'