diff options
| author | Zsolt Kozaroczy <[email protected]> | 2023-06-12 09:43:12 +0200 |
|---|---|---|
| committer | GitHub <[email protected]> | 2023-06-12 09:43:12 +0200 |
| commit | 63a58ba6e35f4807710ba5d8935400d7e502cb30 (patch) | |
| tree | 2950ea04955fbbe15da886844fb433ebfee60fba /lib | |
| parent | 506415434e1f5584001ab79ac9f028e5ba228ef9 (diff) | |
| parent | efe986dc759484cc6f82c4e926ff5128784e0fe8 (diff) | |
| download | caxlsx-63a58ba6e35f4807710ba5d8935400d7e502cb30.tar.gz caxlsx-63a58ba6e35f4807710ba5d8935400d7e502cb30.zip | |
Merge pull request #280 from tagliala/chore/remove-extra-to-s
Remove redundant `to_s` calls
Diffstat (limited to 'lib')
| -rw-r--r-- | lib/axlsx/workbook/worksheet/cell.rb | 5 | ||||
| -rw-r--r-- | lib/axlsx/workbook/worksheet/cell_serializer.rb | 4 |
2 files changed, 5 insertions, 4 deletions
diff --git a/lib/axlsx/workbook/worksheet/cell.rb b/lib/axlsx/workbook/worksheet/cell.rb index 4e667e06..67f84fbc 100644 --- a/lib/axlsx/workbook/worksheet/cell.rb +++ b/lib/axlsx/workbook/worksheet/cell.rb @@ -442,9 +442,10 @@ module Axlsx end end - # Returns the sanatized value - # TODO find a better way to do this as it accounts for 30% of + # Returns the sanitized value + # TODO: find a better way to do this as it accounts for 30% of # processing time in benchmarking... + # @return [String] The sanitized value def clean_value if (type == :string || type == :text) && !Axlsx.trust_input Axlsx.sanitize(::CGI.escapeHTML(@value.to_s)) diff --git a/lib/axlsx/workbook/worksheet/cell_serializer.rb b/lib/axlsx/workbook/worksheet/cell_serializer.rb index 0f7b0dc9..5567c4d6 100644 --- a/lib/axlsx/workbook/worksheet/cell_serializer.rb +++ b/lib/axlsx/workbook/worksheet/cell_serializer.rb @@ -90,7 +90,7 @@ module Axlsx # @param [String] str The string the serialized content will be appended to. # @return [String] def formula_serialization(cell, str = +'') - str << 't="str"><f>' << cell.clean_value.to_s.delete_prefix(FORMULA_PREFIX) << '</f>' + str << 't="str"><f>' << cell.clean_value.delete_prefix(FORMULA_PREFIX) << '</f>' str << '<v>' << cell.formula_value.to_s << '</v>' unless cell.formula_value.nil? end @@ -99,7 +99,7 @@ module Axlsx # @param [String] str The string the serialized content will be appended to. # @return [String] def array_formula_serialization(cell, str = +'') - str << 't="str">' << '<f t="array" ref="' << cell.r << '">' << cell.clean_value.to_s.delete_prefix(ARRAY_FORMULA_PREFIX).delete_suffix(ARRAY_FORMULA_SUFFIX) << '</f>' + str << 't="str">' << '<f t="array" ref="' << cell.r << '">' << cell.clean_value.delete_prefix(ARRAY_FORMULA_PREFIX).delete_suffix(ARRAY_FORMULA_SUFFIX) << '</f>' str << '<v>' << cell.formula_value.to_s << '</v>' unless cell.formula_value.nil? end |
